Re: [PATCH 0/9 v2] Fix thread-safety for elfutils

2024-07-18 Thread Milian Wolff
On Donnerstag, 18. Juli 2024 00:33:59 MESZ Aaron Merey wrote: > v1 can be found at > https://sourceware.org/pipermail/elfutils-devel/2023q3/006329.html > > Heather McIntyre is the original author of v1 of these patches. > Heather and myself co-wrote v2. Hey you all, this sounds very promising! I

Re: [PATCH 0/9 v2] Fix thread-safety for elfutils

2024-07-18 Thread Aaron Merey
Hi Milian, On Thu, Jul 18, 2024 at 6:14 AM Milian Wolff wrote: > > On Donnerstag, 18. Juli 2024 00:33:59 MESZ Aaron Merey wrote: > > v1 can be found at > > https://sourceware.org/pipermail/elfutils-devel/2023q3/006329.html > > > > Heather McIntyre is the original author of v1 of these patches. >

Re: [PATCH v2] backends: allocate enough stace for null terminator

2024-07-18 Thread Mark Wielaard
Hi Sergei, On Wed, 2024-07-17 at 23:03 +0100, Sergei Trofimovich wrote: > `gcc-15` added a new warning in https://gcc.gnu.org/PR115185: > > i386_regs.c:88:11: error: initializer-string for array of 'char' is too > long [-Werror=unterminated-string-initialization] >88 | "ax"

Re: [PATCH 1/9 v2] libelf: Fix deadlock in __libelf_readall

2024-07-18 Thread Mark Wielaard
On Wed, 2024-07-17 at 18:34 -0400, Aaron Merey wrote: > From: Heather McIntyre > > Apply locking during __libelf_readall. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark Wielaard > > --- > v2 changes: > > Add locking for all early returns in __libel

Re: [PATCH 2/9 v2] libelf: Fix deadlock in elf_cntl

2024-07-18 Thread Mark Wielaard
Hi, On Wed, 2024-07-17 at 18:34 -0400, Aaron Merey wrote: > From: Heather McIntyre > > * libelf/elf_cntl.c (elf_cntl): Move rwlock_wrlock, rwlock_unlock, > inside case switch statements. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark

Re: [PATCH 0/9 v2] Fix thread-safety for elfutils

2024-07-18 Thread Milian Wolff
On Donnerstag, 18. Juli 2024 17:56:39 MESZ Aaron Merey wrote: > Hi Milian, > > On Thu, Jul 18, 2024 at 6:14 AM Milian Wolff wrote: > > On Donnerstag, 18. Juli 2024 00:33:59 MESZ Aaron Merey wrote: > > > v1 can be found at > > > https://sourceware.org/pipermail/elfutils-devel/2023q3/006329.html >

Re: [PATCH 4/9 v2] libdw: make dwarf_getalt thread-safe

2024-07-18 Thread Mark Wielaard
Hi, On Wed, Jul 17, 2024 at 06:34:03PM -0400, Aaron Merey wrote: > From: Heather McIntyre > > * libdw/dwarf_getalt.c (dwarf_getalt): Add locking. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark Wielaard > > v2 changes: > > Write lock now appl

Re: [PATCH 5/9 v2] libdwP.h: Add locking to __libdw_dieabbrev,

2024-07-18 Thread Mark Wielaard
Hi, On Wed, Jul 17, 2024 at 06:34:04PM -0400, Aaron Merey wrote: > From: Heather McIntyre > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark Wielaard > > --- > > v2 changes: > This replaces patch "libdw: Add locking around __libdw_dieabbrev for > dwarf

Re: [PATCH 6/9 v2] libdw: Make libdw_find_split_unit thread-safe

2024-07-18 Thread Mark Wielaard
Hi, On Wed, Jul 17, 2024 at 06:34:05PM -0400, Aaron Merey wrote: > From: Heather McIntyre > > * (__libdw_find_split_unit): Add lock for cu->split. > > Signed-off-by: Heather S. McIntyre > Signed-off-by: Aaron Merey > Signed-off-by: Mark Wielaard > > --- > > v2 changes: > Locking appl

Re: [PATCH v2] backends: allocate enough stace for null terminator

2024-07-18 Thread Sergei Trofimovich
On Thu, 18 Jul 2024 18:49:54 +0200 Mark Wielaard wrote: > Hi Sergei, > > On Wed, 2024-07-17 at 23:03 +0100, Sergei Trofimovich wrote: > > `gcc-15` added a new warning in https://gcc.gnu.org/PR115185: > > > > i386_regs.c:88:11: error: initializer-string for array of 'char' is too > > long [

[PATCH] Add man pages for some libelf functions

2024-07-18 Thread Aaron Merey
Add man pages for elf32_offscn.3, elf64_offscn.3, elf_getscn.3 and elf_ndxscn.3. Signed-off-by: Aaron Merey --- doc/elf32_offscn.3 | 61 + doc/elf64_offscn.3 | 62 ++ doc/elf_getscn.3 | 55 +

[PATCH] Add man pages for some libelf functions

2024-07-18 Thread Aaron Merey
Add man pages for elf32_offscn.3, elf64_offscn.3, elf_getscn.3 and elf_ndxscn.3. Signed-off-by: Aaron Merey --- Reposting this patch with the new man pages added to doc/Makefile.am. doc/Makefile.am| 6 - doc/elf32_offscn.3 | 61 + doc/elf64_