[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread vvvvvv at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #4 from Aleksei Vetrov --- (In reply to Frank Ch. Eigler from comment #3) > Is there some reason not to just bump up that bitfield width from :24 to :32 > or more for now, until a deeper analysis of llvm informs us as to how wide >

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 Mark Wielaard changed: What|Removed |Added CC||roland at gnu dot org --- Comment #5

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #6 from Mark Wielaard --- So my preferred workaround: diff --git a/libdw/dwarf_getsrclines.c b/libdw/dwarf_getsrclines.c index df003c5f..69e10c7b 100644 --- a/libdw/dwarf_getsrclines.c +++ b/libdw/dwarf_getsrclines.c @@ -129,6 +12

Preparing for a 0.190 release end of next week

2023-10-26 Thread Mark Wielaard
Hi all, There are various patch reviews and outstanding bugs being worked on. And we'll try to get to all of them. But it would also be good to get a new release out. The last one was in March. There have been 70+ commits by 20 people since 0.189. Lets get a few more patches in and then aim for a

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #7 from Frank Ch. Eigler --- > So my preferred workaround: appears to be based on the assumption that truncated bitfields will not collide. Has this assumption been tested? -- You are receiving this mail because: You are on the

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #8 from Frank Ch. Eigler --- > The issue here is that we create (very) large arrays of struct Dwarf_Line_s > and we do that eagerly, see bug #27405 > So we would like to keep that struct as small as possible. Do we have an estimat

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread vvvvvv at google dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #9 from Aleksei Vetrov --- (In reply to Frank Ch. Eigler from comment #7) > So my preferred workaround: I like this workaround and it works in our use case. > appears to be based on the assumption that truncated bitfields will no

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #10 from Mark Wielaard --- (In reply to Frank Ch. Eigler from comment #7) > > So my preferred workaround: > > appears to be based on the assumption that truncated bitfields will not > collide. Has this assumption been tested? Mo

[Bug libdw/30967] Discriminator in Dwarf_Line_s may exceed 24 bits

2023-10-26 Thread fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=30967 --- Comment #11 from Frank Ch. Eigler --- > I'm more interested in this: what is worst that can happen on discriminator > collision? We are not using discriminator at all in ABI monitoring, so I'm > not familiar with its use cases. That's a g