[PATCH] debuginfod/debuginfod-client.c: use long for cache time configurations

2021-12-09 Thread Alexander Kanavin via Elfutils-devel
time_t is platform dependent and some of architectures e.g. x32, riscv32, arc use 64bit time_t even while they are 32bit architectures, therefore directly using integer printf formats will not work portably. Use a plain long everywhere as the intervals are small enough that it will not be problema

Re: [PATCH] debuginfod/debuginfod-client.c: correct string format on 32bit arches with 64bit time_t

2021-12-09 Thread Alexander Kanavin via Elfutils-devel
Alright, I just sent a patch that replaces time_t with long instead. I tested it on x86, x86-x32, x86-64. Alex On Wed, 8 Dec 2021 at 16:31, Mark Wielaard wrote: > Hi Alexander, > > On Sun, 2021-12-05 at 21:45 +0100, Alexander Kanavin wrote: > > I'm not sure; the point of this patch is simply to

Re: [PATCH] debuginfod/debuginfod-client.c: use long for cache time configurations

2021-12-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > x32, riscv32, arc use 64bit time_t even while they are 32bit > architectures, therefore directly using integer printf formats will not > work portably. > Use a plain long everywhere as the intervals are small enough > that it will not be problematic. lgtm! - FChE

right, trying --enable-sanitizer-address on armv7l

2021-12-09 Thread Mark Wielaard
Hi, I was trying the new --enable-sanitizer-address on our armv7l buildbot worker and it almost works as is, except for... debuginfod.cxx:3472:12: runtime error: reference binding to misaligned address 0x00561ec9 for type '', which requires 2 byte alignment 0x00561ec9: note: pointer points here

Re: right, trying --enable-sanitizer-address on armv7l

2021-12-09 Thread Mark Wielaard
Hi, On Thu, 2021-12-09 at 15:23 +0100, Mark Wielaard wrote: > I was trying the new --enable-sanitizer-address on our armv7l > buildbot worker and it almost works as is, except for... I was confusing address sanitizer and the undefined sanitizer. It is the undefined sanitizer that produces the fol

Re: right, trying --enable-sanitizer-address on armv7l

2021-12-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > I was trying the new --enable-sanitizer-address on our armv7l buildbot > worker and it almost works as is, except for... > > debuginfod.cxx:3472:12: runtime error: reference binding to misaligned > address 0x00561ec9 for type '', which requires 2 byte > alignment > [...] > But I don't unde

Re: patch rfc: PR28661: debuginfod thread-pool

2021-12-09 Thread Mark Wielaard
Hi Frank, On Wed, 2021-12-08 at 22:55 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > While I think this patch itself is fine, and works around the > libmicrohttpd bug that motivated it, I don't know how to test it > seriously in the testsuite. (We can certainly try few -C options for > parsi

Re: patch rfc: PR28661: debuginfod thread-pool

2021-12-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > If you can use ulimit -u or ulimit -T in the run-test.sh script then > please use that, but that probably requires launching sub-shells and > you quickly end up in shell-hell. A problem I found with that is that ulimit -u appears to be systemwide in the sense that a new process/thr

Re: right, trying --enable-sanitizer-address on armv7l

2021-12-09 Thread Mark Wielaard
Hi Frank, On Thu, 2021-12-09 at 10:47 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > > debuginfod.cxx:3472:12: runtime error: reference binding to > > misaligned > > address 0x00561ec9 for type '', which requires 2 byte > > alignment > > [...] > > But I don't understand why. It might be a bug

New buildbot CI worker setups

2021-12-09 Thread Mark Wielaard
Hi, I tweaked the configure options various buildbot do: https://builder.wildebeest.org/buildbot/#/builders?tags=elfutils elfutils-centos-x86_64: --enable-valgrind --enable-sanitize-undefined elfutils-debian-amd64: --enable-valgrind --enable-sanitize-undefined elfutils-debian-arm64: --ena

[Bug libelf/28666] memmove() reads out-of-range in elf32_xlatetom

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28666 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug libdw/28657] UBSan seems to report a divison-by-zero in dwfl_link_map_report

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28657 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug libelf/28666] memmove() reads out-of-range in elf32_xlatetom

2021-12-09 Thread evvers at ya dot ru via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28666 --- Comment #8 from Evgeny Vereshchagin --- Created attachment 13840 --> https://sourceware.org/bugzilla/attachment.cgi?id=13840&action=edit File triggering an "invalid read" I've just added a file triggering that issue. ``` $ git describe

[Bug libdw/28659] UBSan seems to complain about an "integer overflow" in dwfl_segment_report_module

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28659 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug libdw/28655] There seems to be a memory leak in file_read_elf

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28655 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[Bug libdw/28677] New: Bad dynamic entry conversion in dwfl_link_map_report

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28677 Bug ID: 28677 Summary: Bad dynamic entry conversion in dwfl_link_map_report Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 C

[Bug libelf/28666] memmove() reads out-of-range in elf32_xlatetom

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28666 --- Comment #9 from Mark Wielaard --- (In reply to Evgeny Vereshchagin from comment #8) > Created attachment 13840 [details] > File triggering an "invalid read" > > I've just added a file triggering that issue. Thanks, I opened a new bug rep

[Bug libdw/28659] UBSan seems to complain about an "integer overflow" in dwfl_segment_report_module

2021-12-09 Thread evvers at ya dot ru via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28659 --- Comment #4 from Evgeny Vereshchagin --- > But it comes with a horribly proprietary license Unfortunately LGTM (like many other CI services) is tightly coupled with GitHub (where it can be used for automated analysis of open source project

[PATCH] libdwfl: Don't try to convert too many dyns in dwfl_link_map_report

2021-12-09 Thread Mark Wielaard
When trying to read (corrupt) dynamic entries from a core file we only want to read and convert the entries we could read. Also make sure we don't try to allocate too bug a buffer. Signed-off-by: Mark Wielaard --- libdwfl/ChangeLog | 6 ++ libdwfl/link_map.c | 14 +- 2 files ch

[Bug libdw/28677] Bad dynamic entry conversion in dwfl_link_map_report

2021-12-09 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28677 Mark Wielaard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigne

[Bug libdw/28660] ASan seems to complain about a "heap-buffer-overflow"

2021-12-09 Thread evvers at ya dot ru via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28660 --- Comment #3 from Evgeny Vereshchagin --- Looks like it keeps popping up with all the patches applied ``` 0a2c8345 libdwfl: Don't try to convert too many dyns in dwfl_link_map_report ea8ce550 libdwfl: Don't install an Elf handle in a Dwfl_Mo

[Bug libdw/28660] ASan seems to complain about a "heap-buffer-overflow"

2021-12-09 Thread evvers at ya dot ru via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28660 --- Comment #4 from Evgeny Vereshchagin --- Created attachment 13842 --> https://sourceware.org/bugzilla/attachment.cgi?id=13842&action=edit File triggering an "invalid read" I've just attached a file triggering the issue: ``` autoreconf -

[Bug libdw/28677] Bad dynamic entry conversion in dwfl_link_map_report

2021-12-09 Thread evvers at ya dot ru via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28677 Evgeny Vereshchagin changed: What|Removed |Added CC||evvers at ya dot ru --- Comment

Re: patch rfc: PR28661: debuginfod thread-pool

2021-12-09 Thread Frank Ch. Eigler via Elfutils-devel
Hi, Mark - > So I would recommend to simply add a testcase that just uses no-option, > -C and -C 256 (or take any arbitrary number, 1 might be an interesting > corner case) and see that if you have 4 (8, 16, ...?) debuginfod-find > (or curl metric) processes doing some parallel queries works as >