Re: [PATCH] debuginfod: PR27917 - protect against federation loops

2021-08-20 Thread Di Chen via Elfutils-devel
Hey Frank, 1) moved the XFF check to handle_buildid. 2) replace "livelock" with "deadlock" in the commit message. - dichen On Thu, Aug 19, 2021 at 6:55 AM Frank Ch. Eigler wrote: > Hi - > > > This patch aims to reduce the risk by adding an option to debuginfod > > that functions kind of like

obv patch: debuginfod-client-config.7 man page packaging

2021-08-20 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Pushing momentarily: commit dc6ddd8ba061c0486a2c4b5a17ddd086d5e3a32d (HEAD -> master) Author: Frank Ch. Eigler Date: Fri Aug 20 13:54:55 2021 -0400 PR27950 - package new debuginfod-client-config.7 man page in rpm The template rpm spec file needs to include the new .7 page in

[PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-20 Thread Saleem Abdulrasool via Elfutils-devel
This header is a BSD header that is also available in glibc. However, this is a not a standard C header and was used for `__CONCAT`. Because this is not a standard header, not all libc implementations provide the header. Remove the usage of the header and always use the previously fallback path.

[PATCH] debuginfod, elfclassify: remove unnecessary header inclusion

2021-08-20 Thread Saleem Abdulrasool via Elfutils-devel
`error.h`'s inclusion was centralised into the `system.h` header. As the implementation currently includes `system.h` already, the inclusion of `error.h` is unnecessary. This prepares for a future portability change to allow elfutil to build with alternate libc implementations. Signed-off-by: Sa

[PATCH] handle libc implemntations which do not provide `error.h`

2021-08-20 Thread Saleem Abdulrasool via Elfutils-devel
Introduce a configure time check for the presence of `error.h`. In the case that `error.h` is not available, we can fall back to `err.h`. Although `err.h` is not a C standard header (it is a BSD extension), many libc implementations provide. If there are targets which do not provide an implementa

Re: [PATCH] handle libc implemntations which do not provide `error.h`

2021-08-20 Thread Saleem Abdulrasool via Elfutils-devel
Hi, Sorry, this change is missing a modification that I seemed to have left out accidentally. I missed the inclusion of `err.h` in the `HAVE_ERR_H` when I was staging the changes locally. I'll send out a new version of this patch. On Fri, Aug 20, 2021 at 11:23 AM Saleem Abdulrasool wrote: > >

[PATCH v2] handle libc implemntations which do not provide `error.h`

2021-08-20 Thread Saleem Abdulrasool via Elfutils-devel
Introduce a configure time check for the presence of `error.h`. In the case that `error.h` is not available, we can fall back to `err.h`. Although `err.h` is not a C standard header (it is a BSD extension), many libc implementations provide. If there are targets which do not provide an implementa