Re: patch rfc - valgrind vs. debuginfod

2021-07-02 Thread Mark Wielaard
Hi Frank, On irc we discussed some issues with trying to disable debuginfod client for valgrind while actually using it in the to be tested executable. The main issue is that valgrind and the test executable are actually one and the same. So disabling or enabling DEBUGINFOD_URLS for one also disab

Re: patch rfc - valgrind vs. debuginfod

2021-07-02 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > On irc we discussed some issues with trying to disable debuginfod > client for valgrind while actually using it in the to be tested > executable. The main issue is that valgrind and the test executable are > actually one and the same. So disabling or enabling DEBUGINFOD_URLS for > one also

PR: 25978

2021-07-02 Thread Noah Sanci via Elfutils-devel
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog index 286c910a..06d03e72 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,3 +1,9 @@ +2021-06-28 Noah Sanci + + PR25978 + * debuginfod.cxx: Added command line options + --fdcache-prefetch-fds/mbs and associated metrics/funct

Re: [PATCH] libdwfl: add dwfl_local_find_debuginfo callback

2021-07-02 Thread Mark Wielaard
Hi Nick, Sorry for the late reply. On Sun, Jun 13, 2021 at 11:27:02AM +0800, Nick Gasson via Elfutils-devel wrote: > This patch adds a variant of dwfl_standard_find_debuginfo that only > searches the local filesystem and does not fall back to debuginfod. > > In my application I am using libdw to

Re: [PATCH] debuginfod-client: Fix client dereference when calloc fails.

2021-07-02 Thread Mark Wielaard
On Fri, Jun 18, 2021 at 03:02:43PM +0200, Mark Wielaard wrote: > When the calloc call in debuginfod_begin fails we should skip all > initialization of the client handle. Pushed.

Re: [PATCH] strip: Always check gelf_update results.

2021-07-02 Thread Mark Wielaard
On Fri, Jun 18, 2021 at 03:06:32PM +0200, Mark Wielaard wrote: > +2021-06-18 Mark Wielaard > + > + * strip.c (remove_debug_relocations): Check gelf_update results. > + (update_section_size): Likewise. Pushed.

Re: [PATCH] unstrip: Always check gelf_getrel[a] results

2021-07-02 Thread Mark Wielaard
On Fri, Jun 18, 2021 at 03:08:48PM +0200, Mark Wielaard wrote: > +2021-06-18 Mark Wielaard > + > + * unstrip.c (adjust_relocs): Check gelf_getrel and geld_getrela. > + Pushed.