Re: [PATCH] libdw: Don't free uninitialized Dwarf_Abbrev_Hash's of "fake" CUs.

2019-11-01 Thread Mark Wielaard
On Thu, Oct 31, 2019 at 06:42:18PM -0500, Jonathon Anderson wrote: > fake_{loc,loclists,addr}_cu are Dwarf_CUs that are created separate from > all the others, so their contents are minimal and mostly initialized by > a calloc. On dwarf_end however, they are freed through the same code path > as al

[PATCH] libdw: Don't free uninitialized Dwarf_Abbrev_Hash's of "fake" CUs.

2019-11-01 Thread Jonathon Anderson
fake_{loc,loclists,addr}_cu are Dwarf_CUs that are created separate from all the others, so their contents are minimal and mostly initialized by a calloc. On dwarf_end however, they are freed through the same code path as all the others, so they call DAH_free like all the others. This changes that

Re: [PATCH] libdw: Don't free uninitialized Dwarf_Abbrev_Hash's of "fake" CUs.

2019-11-01 Thread Mark Wielaard
Hi Jonathon, On Fri, 2019-11-01 at 08:14 -0500, Jonathon Anderson wrote: > How about a bit of both, I'll be happy if I don't initialize > `unit_type`. > Does this work? Looks perfect. Pushed to master. Thanks, Mark