Re: Suggestion: a new "nature" field in Trac

2011-02-23 Thread mmcnickle
On Feb 22, 11:22 am, Russell Keith-Magee wrote: >  2) Directing people who are inclined to be altruistic to the right place. For Firefox bugs, each patch can be flagged as follows: Request a review from anyone: review=? Request a review from someone specific: russellm: review? Russel hates th

Benchmarking change to query.get() #15361

2011-02-24 Thread mmcnickle
Hi All, Background to this post is available at http://code.djangoproject.com/ticket/15361 I've created a better benchmark in order to test where the change in the above ticket causes a performance regression. These are the results of those tests. First of all, the results are based on query.ge

Re: Benchmarking change to query.get() #15361

2011-02-25 Thread mmcnickle
On Feb 24, 11:40 pm, Russell Keith-Magee wrote: > Optimizing Django's retrieval code for the bad design > case strikes me as equally bad design. I say document this and leave > the code as is. Ok, I'll write a documentation patch for this for the optimisation section. Good job for catching this

Re: "needsinfo": resolution vs. triage stage

2011-02-25 Thread mmcnickle
On Feb 25, 3:17 am, Gabriel Hurley wrote: >    - May intimidate new contributors to see that their ticket was "closed". >    - Doesn't discount the fact that there may be a valid issue here which we >    don't want to forget about. I wouldn't underestimate either of these 2 points. The PHP core

#15575: MultipleObjectMixin.paginate_queryset always returns is_paginated=True, despite docs saying otherwise

2011-03-11 Thread mmcnickle
http://code.djangoproject.com/ticket/15575 Should the patch fix the documentation to match tested behaviour (one passing test in generic_views specifically tests this case), or should the code be patched to meet the expectation of the documentation? -- Martin -- You received this message becaus