Django security releases issued: 3.2.2, 3.1.10, and 2.2.22

2021-05-06 Thread Mariusz Felisiak
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/may/06/security-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and st

Re: Fellow Reports - April 2021

2021-05-06 Thread Mariusz Felisiak
Week ending May 2, 2021 *Triaged: * https://code.djangoproject.com/ticket/32682 - Deleting objects after searching related many to many field crashes the admin page (accepted) https://code.djangoproject.com/ticket/32685 - Add feature to preserve order in .filter(field__in=list) query (won

Re: On adding comments to database schema

2021-05-06 Thread Jared Chung
KimSoungRyoul would you like help with writing the docs and tests for this? I'd like to contribute to Django in some way and this is a feature my company would greatly value (we have Data Scientists and DBAs interacting with db tables managed by Django, so having comment documentation at the DB

Re: On adding comments to database schema

2021-05-06 Thread Jared Chung
KimSoungRyoul it looks like there is feedback on the PR you created (PR #12605 ) and Marius also pointed out that docs and tests are missing. Would you like help with the docs and tests? We've recently added some data scientists and dbas to our team

Re: On adding comments to database schema

2021-05-06 Thread Tom Carrick
It's funny that you bring this up, I was actually looking at this today and thinking about picking it up next week. Jared, the PR was closed without any comment from the author and is seemingly abandoned. I think it's safe for you to assign the ticket to yourself and continue the work in a new PR

Re: APPEND_SLASH behavior

2021-05-06 Thread Florian Apolloner
Hi, I took a quick glance (literally just that) at the pull requests. I do like the one that offers a way to abort early inside a prefix -- this is a nice optimization and as well might open interesting options for specialized catch all views. I am not convinced about the backtracking PR, which

Re: APPEND_SLASH behavior

2021-05-06 Thread Tidiane Dia
Hi, thanks for giving it a look. The PR are based on existing tickets so these are not my ideas. The relevant ticket for the backtracking URL contains valuable information about its benefits and why the author requested the feature. The idea is to

Re: APPEND_SLASH behavior

2021-05-06 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
> > That said, I think doing this in process_response would be preferable over > doing it in process_request so the extra checks when the URL is valid (the > common case) are reduced. Resolving URLs can take a bit, especially when > the urlconf is long and as such I'd like to get that check out of