translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Matthias Kestenholz
Hello everyone, The resolution of https://code.djangoproject.com/ticket/30241 in https://github.com/django/django/commit/4400d8296d268f5a8523cd02ddc33b12219b2535 introduced a new and in my opinion backwards incompatible requirement through the system checks framework. Previously*, overriding LANG

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Adam Johnson
Hi Matthias, I can see why this is annoying. At least the resolution is easy by setting LANGUAGES_BIDI = []. I do agree that it should be in the release notes, although it's quite hard to miss a new system check's output when upgrading. I see it was only at the last review of the PR ( https://git

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Matthias Kestenholz
Hi Adam Thanks for your answer. I'll try to convince you (and others) that the error in question does not make sense, not even when downgraded to a warning. There are system checks which provide great value such as django.contrib.admin checking whether templates, context processors etc. are confi

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Tobias McNulty
I am curious, what is the reasoning behind disallowing LANGUAGES_BIDI from containing languages not in LANGUAGES in the first place? If as Matthias says it is never iterated over, I'm unclear what problems this might cause, though I agree the fix is simple enough... At least perhaps the last para

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Adam Johnson
Other ideas: - Bypass the check in the case that LANGAUGES_BIDI is the same as the one in global_settings - probably not the best idea, but would stop all projects having to set LANGUAGES_BIDI = [] to avoid the check - Change startproject so that LANGUAGES_BIDI is set up as the empty l

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Tobias McNulty
Having thought about this a little more, I may have found in answer to my own question. :-) The reasoning would seem to be that, by overriding LANGUAGES but not LANGUAGES_BIDI, you risk introducing an inconsistency between the language code *format* in these two settings (a la LANGUAGE_CODE and th

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Matthias Kestenholz
Checking that entries in LANGUAGES and LANGUAGES_BIDI are well formed certainly makes sense! I wouldn't want to back out this part of the change. All settings come with a certain risk of inconsistencies or with unexpected behavior. That being said, this particular change just seems so patronizing

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Mariusz Felisiak
We can also remove *LANGUAGES_BIDI *from *global_settings.py*, check if *LANGUAGES_BIDI *is overridden in *Settings.__init__()* and if not then set it to a subset of RTL languages from *LANGUAGES*. This should solve all issues, IMO. -- You received this message because you are subscribed to th

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Mariusz Felisiak
Sorry for technical description. W dniu wtorek, 9 kwietnia 2019 15:24:59 UTC+2 użytkownik Mariusz Felisiak napisał: > > We can also remove *LANGUAGES_BIDI *from *global_settings.py*, check if > *LANGUAGES_BIDI > *is overridden in *Settings.__init__()* and if not then set it to a > subset of RT

Re: translation.E005 / Should LANGUAGES_BIDI be a strict subset of LANGUAGES?

2019-04-09 Thread Mariusz Felisiak
I prepared PoC: https://github.com/django/django/pull/11190. W dniu wtorek, 9 kwietnia 2019 15:25:24 UTC+2 użytkownik Mariusz Felisiak napisał: > > Sorry for technical description. > > W dniu wtorek, 9 kwietnia 2019 15:24:59 UTC+2 użytkownik Mariusz Felisiak > napisał: >> >> We can also remove *

Re: Queries about the project idea Improving the Less Popular Backends

2019-04-09 Thread Dingfan Zhao
Hello, Thanks for your reply! I am working on the proposal now since the deadline is quite tight. I finished the proposal just now and hope you could give me some advice on it. https://docs.google.com/document/d/1tlGWuf_uBS-1GvxwMoSyyh5xUmB4b5gVg4vRFGaMDZg/edit I will start contributing to s

GSoC 2018

2019-04-09 Thread makina
Hello, Django doesn't have any projects in 2018. https://summerofcode.withgoogle.com/archive/2018/organizations/5080222944722944/ Does it mean there were no quality applicants in 2018? Thank you -- You received this message because you are subscribed to the Google Groups "Django developers

Re: Queries about the project idea Improving the Less Popular Backends

2019-04-09 Thread Asif Saif Uddin
You are too late to propose the proposal for review. Now it's your call fix as many good issues related to your proposal so that the core mentors can gauge your ability to be selected for gsoc this year. if you could contribute some good patches you might be a very good candidate for gsoc next

Re: GSoC 2018

2019-04-09 Thread Asif Saif Uddin
yes, there wasn't anyone selected. On Wednesday, April 10, 2019 at 3:24:50 AM UTC+6, makina wrote: > > Hello, > > Django doesn't have any projects in 2018. > https://summerofcode.withgoogle.com/archive/2018/organizations/5080222944722944/ > Does it mean there were no quality applicants in 2018?