You could use
```
if settings_dict.get('NAME') and len(settings_dict['NAME'])
```
if you wanted to prevent a KeyError too.
On Sunday, January 21, 2018 at 8:56:40 AM UTC+1, askpr...@gmail.com wrote:
>
> Hello !
>
> I have updated the PR as per Adam's review. However, I have not changed
> L155 in b
Please keep the conversation just on the pull request, and don't bug for
review after a day. There are many patches to review, and half the work is
done by volunteers in their spare time (I am one). Beware that there are 11,195
people subscribed to this mailing list.
On 21 January 2018 at 07:56,
Hey Collin,
I posted a new PR: https://github.com/django/django/pull/9609
Let me know what your thoughts are.
I also updated the ticket.
Cheers,
Andrew
On Thursday, January 18, 2018 at 6:57:06 AM UTC-8, Collin Anderson wrote:
>
> Hi Andrew,
>
> Sure, do you want propose some tests? You cou
Hi Carlton,
On Sat, Jan 20, 2018 at 9:13 AM, Carlton Gibson
wrote:
> Hi Raffaele,
>
> Thanks for both your effort and your patience.
>
> There are around 60 patches needing review (or just reviewed or being
> improved or...) at the moment, so it can take a while to get to.
>
> I will look at thi
