Re: To keep or not to keep: logging of undefined template variables

2017-06-20 Thread Vlastimil Zíma
-1 to the removal. I was annoyed by the logging at first, but then I started to clean individual logs. Half way through, I found several usages of long removed variables, one unused template (as a side effect) and I updated several views to always provide defined context variables. All in all,

Re: To keep or not to keep: logging of undefined template variables

2017-06-20 Thread Anthony King
-1 for removing logs. Like Vlastimil, it's helped me spot a couple of stray bugs. What I'd actually like to see is this becoming stricter, with the end goal of errors raising when using undefined variables. For the verbosity, perhaps there's a middle ground? only log once per variable access per

django.core.signing and safe characters

2017-06-20 Thread Ole Laursen
Hi! Maybe this has no practical implications, but this has been bugging me for a couple of years now, ever since I started using django.core.signing to generate tokens: if you take a look at https://github.com/django/django/blob/master/django/core/signing.py the comment at the top says T

Re: django.core.signing and safe characters

2017-06-20 Thread Florian Apolloner
Hi, On Tuesday, June 20, 2017 at 12:18:21 PM UTC+2, Ole Laursen wrote: > > Yet, : is specifically mentioned as a reserved character: > It depends on the context. The assumption here is that the encoded data is always used as part of the path/querystring, for which rfc1738 says: Within the and

Re: should nonexistent template filter arguments resolve to string_if_invalid rather than raise VariableDoesNotExist?

2017-06-20 Thread allejjandrozf
# Some examples here for illustrate better my point of view: from django.template import Context, Template # CASE_1: shouldn't raise an exception because 'foo' variable exists in the context and 'default' filter # shouldn't be invoked, Template('{{ foo|default:notreal }}').render(Context({'foo':