Re: Ticket 2273: django.contrib.auth.models.User: username is case-sensitive

2017-04-17 Thread Tobias McNulty
I'm surprised that (as far as I can see) this idea hasn't been discussed in the ~11 year (!) history of this ticket. It was alluded to ~3 years go by mkhalil28 , but was missing the backwards-compatible 'except' bit and didn't get any follow-up

Re: [Feature Request] Shorthand syntax for filtering aggregations

2017-04-17 Thread Tom Forbes
Hey Simon, Thanks for your reply, I actually agree after thinking about it. Adding a filter/exclude method and getting it to work correctly in the way people would expect is be pretty complex. Adding an argument that takes a Q object would suffice for now at least. I'm happy to implement this, but

Re: [Feature Request] Shorthand syntax for filtering aggregations

2017-04-17 Thread charettes
Hey Tom, Overriding Aggregate.as_sql() to branch on connection.features to build the FILTER clause shouldn't be an issue. I think you could rely on super().as_sql(..., filter=filter_sql) extra parameter when the connection supports the FILTER statement and fallback to self.clone(), clone.source

Re: Feature idea: forms signals

2017-04-17 Thread David Seddon
Hi JP, That's a good point, sorry I didn't make it clear. The fork is installed from within the requirements file but you can also see it here, on the ticket_27923 branch: https://github.com/seddonym/django/tree/ticket_27923 I've updated the README to help. I'd be interested to hear if anyone

Re: #26369: default formfield callback override

2017-04-17 Thread David Seddon
Hi Jamesie, I recently proposed adding a post_init signal for forms (https://groups.google.com/forum/#!topic/django-developers/SviNiWy3Bjc). Here's an example of how you might adjust the forms: https://github.com/seddonym/formsignals/blob/master/formsignals/priority/receivers.py If such a sig

Re: #26369: default formfield callback override

2017-04-17 Thread Jamesie Pic
Hi David, Yep, I'm with you on this, another good reason to close this PR. I'm building DAL's next feature on your fork, so you'll have my feedback for sure at some point ;) Best <3 -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions

Re: I would like to discuss my proposal for a working way to call .add() on an m2m with through= model

2017-04-17 Thread Luis Masuelli
I'm quite happy to see the topic is at least being considered! <3. Although I suggested a solution, I like the solution posted by Collin in the PR (I'd prefer solutions not involving signature changes in methods, but anyway those signature changes Colin posted are not so... obtrusive). I'd like

Re: Ticket 2273: django.contrib.auth.models.User: username is case-sensitive

2017-04-17 Thread Info-Screen
I might be able to try to implement this. I'm new to django, but let's try On Monday, April 17, 2017 at 4:13:23 PM UTC+2, Tobias McNulty wrote: > > I'm surprised that (as far as I can see) this idea hasn't been discussed > in the ~11 year (!) history of this ticket. It was alluded to ~3 years go