Re: Adding a database-agnostic JSONField into Django

Hi, Le jeudi 23 juin 2016, Aymeric Augustin a écrit : > On 23 Jun 2016, at 15:40, Tim Graham wrote: > > Marc said, "I'm happy for JSONField to be made a core field on the > > condition that it's underlying support is more than a text blob on all > > our main databases. It sounds like this will so

Re: Adding a database-agnostic JSONField into Django

On 24 Jun 2016, at 09:01, Raphael Hertzog wrote: > Why would you want to discourage people? Well, this seemed to be the latest decision, but I don’t care much myself. > What would be the next logical step if I want to work on this? > > Is there a need for a DEP to discuss the interface provid

Re: Adding a database-agnostic JSONField into Django

On Friday 24 June 2016 10:01:36 Raphael Hertzog wrote: > Hi, > > Le jeudi 23 juin 2016, Aymeric Augustin a écrit : > > On 23 Jun 2016, at 15:40, Tim Graham wrote: > > > Marc said, "I'm happy for JSONField to be made a core field on the > > > condition that it's underlying support is more than a t

Re: Adding a database-agnostic JSONField into Django

Le vendredi 24 juin 2016, Aymeric Augustin a écrit : > On 24 Jun 2016, at 09:01, Raphael Hertzog wrote: > > Why would you want to discourage people? > Well, this seemed to be the latest decision, but I don’t care much myself. AFAIK only Marc Tamlyn insisted on such a requirement to have native JS

Re: Adding a database-agnostic JSONField into Django

Hi, Le vendredi 24 juin 2016, Shai Berger a écrit : > > Why would you want to discourage people? In the recent thread "Extending > > JSONField serialization", you said yourself that the use-case for a > > JSONField is clearly to store and retrieve data and not to make queries on > > it with smart

change commit message format to present tense?

A few contributors indicated in #django-dev that it could be beneficial to change our commit message format to match git's guidelines of present tense (instead of our current past tense convention) as it would be one less thing to remember when contributing to Django. Besides consistency with th

Re: change commit message format to present tense?

On 06/24/2016 10:55 AM, Tim Graham wrote: > A few contributors indicated in #django-dev that it could be beneficial > to change our commit message format to match git's guidelines of present > tense (instead of our current past tense convention) as it would be one > less thing to remember when cont

Re: change commit message format to present tense?

I'm not entirely sure because my memory sucks, but odds are that I started the current standard of using past-tense. FWIW I no longer care even at all, I think as long as commit messages are clear we I don't care what tense they are. Following the standard git way seems totally OK to me. Jacob O

Re: change commit message format to present tense?

I don't mind either way. If everybody seems to use present tense these days, yeah, let's do that as well. As long as the general style of the commit messages stays: Fixes|Refs #12345 -- Make it work My 2¢ /Markus On Fri, Jun 24, 2016 at 11:04:39AM -0600, Jacob Kaplan-Moss wrote: I'm not entire

Re: change commit message format to present tense?

I'm in support of this as well. Is the suggestion to change the format to: A) Fixes #12345 -- Add support for ... / Validate that / etc. OR B) Fixes #12345 -- Adds support for ... / Validates that ... / etc. OR C) Something else? I assume (A) but others may interpret this differently? O

Re: change commit message format to present tense?

To be clear, the recommended git style is not present tense, it is imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the frobnicator", it should be "Fix #12345 -- Regulate the frobnicator." Carl On 06/24/2016 11:45 AM, Tobias McNulty wrote: > I'm in support of this as well. Is the

Re: change commit message format to present tense?

On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer wrote: > To be clear, the recommended git style is not present tense, it is > imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the > frobnicator", it should be "Fix #12345 -- Regulate the frobnicator." > Do you have a link to an autho

Re: change commit message format to present tense?

On Fri, Jun 24, 2016, Jon Dufresne wrote: >On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer wrote: > >> To be clear, the recommended git style is not present tense, it is >> imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the >> frobnicator", it should be "Fix #12345 -- Regulate th

Re: change commit message format to present tense?

On 06/24/2016 12:15 PM, Jon Dufresne wrote: > On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer > wrote: > > To be clear, the recommended git style is not present tense, it is > imperative mood. So it should _not_ be "Fixes #12345 -- Regulates the > frobnicator", i

Re: change commit message format to present tense?

This post by Tim Pope is considered the "definitive guide to commit messages" as far as I'm aware. http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html +1 to adopting this style. On 24 June 2016 at 19:15, Jon Dufresne wrote: > On Fri, Jun 24, 2016 at 10:48 AM, Carl Meyer wrote

Re: change commit message format to present tense?

> On 24 Jun 2016, at 20:23, Carl Meyer wrote: > > The style that is most commonly recommended is described in the most > detail (with reasoning) in these blog posts: > > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html > http://chris.beams.io/posts/git-commit/ Yes, let’s do

Re: change commit message format to present tense?

With the idea of saving characters in the first line, would "Fix #XXX: Message" be better than ""Fix #XXX -- Message" also? This saves two characters without any loss of readability as far as I see. On Friday, June 24, 2016 at 4:44:10 PM UTC-4, Aymeric Augustin wrote: > > > On 24 Jun 2016, at 20

Re: change commit message format to present tense?

On 06/24/2016 03:04 PM, Tim Graham wrote: > With the idea of saving characters in the first line, would "Fix #XXX: > Message" be better than ""Fix #XXX -- Message" also? This saves two > characters without any loss of readability as far as I see. Seems reasonable to me. Carl -- You received thi

Re: change commit message format to present tense?

> On 24 Jun 2016, at 23:27, Carl Meyer wrote: > > On 06/24/2016 03:04 PM, Tim Graham wrote: >> With the idea of saving characters in the first line, would "Fix #XXX: >> Message" be better than ""Fix #XXX -- Message" also? This saves two >> characters without any loss of readability as far as I se

Re: Adding a database-agnostic JSONField into Django

I would like it. I honestly one use JsonField to store json data, not really to query it, and having postgres store it a very efficient way is a very nice plus compared to plain text storage. Then the postgres features to query json data are godlike but I wouldn't mind trading something to allo