CSRF middleware calculates new tokens that are never used

2015-04-24 Thread jaycox
It was requested of me that I post this here to get some more eyes on it: Django ticket: https://code.djangoproject.com/ticket/24696 Pull request: https://github.com/django/django/pull/4550 I noticed that the csrf middleware will always calculate a new csrf token for any request that does not in

Re: CSRF middleware calculates new tokens that are never used

2015-04-24 Thread Carl Meyer
Hi Jay, On 04/24/2015 12:29 PM, jay...@linear3d.com wrote: > It was requested of me that I post this here to get some more eyes on it: > > Django ticket: https://code.djangoproject.com/ticket/24696 > Pull request: https://github.com/django/django/pull/4550 > > I noticed that the csrf middleware

System check is using the default database connection for all the models

2015-04-24 Thread Ion Scerbatiuc
Hello, Wasn't sure if this is a bug or not, and I couldn't find any related tickets on https://code.djangoproject.com We have the following database set-up: - the default database is MySQL - two additional databases are PostGIS The system check framework (either `manage.py check` or `man

Re: CSRF middleware calculates new tokens that are never used

2015-04-24 Thread jaycox
On Friday, April 24, 2015 at 12:18:08 PM UTC-7, Carl Meyer wrote: > > > Wow. I'm surprised that generating a CSRF token is that expensive, but > it doesn't really matter; if it doesn't need to be done for a given > request, there's no reason to do it. > > Most of that time is spent in posix.ur

Potentially inconsistent behavior between test client and normal WSGI requests

2015-04-24 Thread Matt Hooks
Hi all, As I was fixing an issue in our API related to url encodings, I noticed a problem should have been caught by a test that was somehow passing. (Remember, make sure your test can fail!) If you had some path /some/path/Spam%20Ham, and a URL pattern to capture /some/path/(?P.+)$, it's not

Re: Potentially inconsistent behavior between test client and normal WSGI requests

2015-04-24 Thread Florian Apolloner
On Friday, April 24, 2015 at 10:51:12 PM UTC+2, Matt Hooks wrote: > > (The behavior of the development server is similar to the test client, > although I haven't investigated for what exact reason.) > To be honest, even on my production machines I have this behavior -- so the question is which

Re: Potentially inconsistent behavior between test client and normal WSGI requests

2015-04-24 Thread Matt Hooks
Took me a few minutes to narrow down the right environment to recreate this. I'm seeing this "issue" with Gunicorn (latest version ,19.3.0), and only when using the gaiohttp async worker (again latest version of aiohttp, 0.15.3). I've tracked it down to the troublesome line in aiohttp, but I