Re: AbstractUser to get more abstract

2013-09-25 Thread Marc Tamlyn
Thanks for compiling a more complete solution. The biggest disadvantage as I see it is that is adds even more complexity to the implementation of those forms. In particular the `setattr` on the form class of a `clean_` method is a really nasty code smell. The code in the `create_user`/`create_supe

Re: AbstractUser to get more abstract

2013-09-25 Thread Luke Sneeringer
On Sep 25, 2013, at 2:58 AM, Marc Tamlyn wrote: > Thanks for compiling a more complete solution. > > The biggest disadvantage as I see it is that is adds even more complexity to > the implementation of those forms. In particular the `setattr` on the form > class of a `clean_` method is a real

Re: AbstractUser to get more abstract

2013-09-25 Thread Luke Sneeringer
On Sep 25, 2013, at 2:58 AM, Marc Tamlyn wrote: > Other things which appear to be bugs to me: > - You automatically register an admin class for any custom user model, which > is likely to break validation. > - If I set first_name and last_name as REQUIRED_FIELDS then your admin class > will br

Re: Hyperlink CSS on djangoproject.com

2013-09-25 Thread Daniele Procida
On Tue, Sep 24, 2013, Marc Tamlyn wrote: >As someone who has color blindness (off the top of my head I can't remember >the exact condition, but it's not simple red-green that 1 in 8 men have) it >looks fine to me. Personally I like the distinction between the external >and internal links. It's n

Re: Hyperlink CSS on djangoproject.com

2013-09-25 Thread Tim Graham
See also ticket #14834 "Colour issues in CSS - particularly documentation." However, it may not be worth working on this right now as I believe there's an initiative to redesign djangoproject.com (although it's been nearly a year since the email thread on the topic has been updated). see https

Add strutctured settings module to django 1.7?

2013-09-25 Thread VernonCole
I find myself using up lots of time and keystrokes explaining about the benefits and methods of a structured settings module in django. For example: Using-a-Structured-Settings-environment It occurs to me that li

Re: Add strutctured settings module to django 1.7?

2013-09-25 Thread Russell Keith-Magee
On Thu, Sep 26, 2013 at 4:21 AM, VernonCole wrote: > I find myself using up lots of time and keystrokes explaining about the > benefits and methods of a structured settings module in django. > For example: > Using-a-Structured-Settings-environment

Re: Add strutctured settings module to django 1.7?

2013-09-25 Thread Michael Mior
Given that, what about incorporating something like DJ-Database-URL[1] into Django? It would be great if this could be the default if DATABASES was left unspecified. [1] https://github.com/kennethreitz/dj-database-url Le mercredi 25 septembre 2013 19:45:20 UTC-4, Russell Keith-Magee a écrit : >