#3011 - Custom User Models -- Call for final review

2012-09-15 Thread Russell Keith-Magee
Hi all, The implementation of custom User models is now ready for final review, prior to commit to trunk. The code is available in my Github repo, in the t3011 branch. https://github.com/freakboy3742/django/tree/t3011 The diff is available here: https://github.com/freakboy3742/django/compare/m

Re: #3011 - Custom User Models -- Call for final review

2012-09-15 Thread Jacob Kaplan-Moss
Hey Russ -- I took the liberty of opening up a pull request (https://github.com/django/django/pull/370) so that I can leave comments inline. Hope you don't mind. Jacob On Sat, Sep 15, 2012 at 7:34 AM, Russell Keith-Magee wrote: > Hi all, > > The implementation of custom User models is now ready

Re: #3011 - Custom User Models -- Call for final review

2012-09-15 Thread Anssi Kääriäinen
On 15 syys, 15:34, Russell Keith-Magee wrote: > Hi all, > > The implementation of custom User models is now ready for final > review, prior to commit to trunk. > > The code is available in my Github repo, in the t3011 branch. > > https://github.com/freakboy3742/django/tree/t3011 > > The diff is av

Re: #3011 - Custom User Models -- Call for final review

2012-09-15 Thread Anssi Kääriäinen
On 15 syys, 18:59, Anssi Kääriäinen wrote: > With the above commits I can do this: > > class MyUser(AbstractUser): >     employee_no = models.CharField(max_length=5) >     some_other_field = models.TextField(null=True, blank=True) >     REQUIRED_FIELDS = AbstractUser.REQUIRED_FIELDS + ['employee_n

Re: Testing django 1.5 with firebirdsql

2012-09-15 Thread Anssi Kääriäinen
On 15 syys, 01:05, maxi wrote: > BTW, I've another issue related to one specific test. > In test/regressiontests/model_fields/models.py there is a model > defined as: > > class BigD(models.Model): >     d = models.DecimalField(max_digits=38, decimal_places=30) > > Firebird doesn't accept that defi

Re: #3011 - Custom User Models -- Call for final review

2012-09-15 Thread Russell Keith-Magee
On Sat, Sep 15, 2012 at 11:59 PM, Anssi Kääriäinen wrote: > On 15 syys, 15:34, Russell Keith-Magee > wrote: >> Hi all, >> >> The implementation of custom User models is now ready for final >> review, prior to commit to trunk. >> >> The code is available in my Github repo, in the t3011 branch. >>

end of "coming soon" in the tutorial? - tutorial 5 feedback needed!

2012-09-15 Thread Tim Graham
Katie Miller and Ben Sturmfels have written a fifth tutorial covering making "polls" a reusable app. I've given it an initial review, but I'm hoping we can get a few more people to give it a look and/or try it out, particularly if you are an expert in packaging (which I'm not). Thanks guys!

Re: #3011 - Custom User Models -- Call for final review

2012-09-15 Thread Russell Keith-Magee
On Sun, Sep 16, 2012 at 1:07 AM, Anssi Kääriäinen wrote: > On 15 syys, 18:59, Anssi Kääriäinen wrote: >> With the above commits I can do this: >> >> class MyUser(AbstractUser): >> employee_no = models.CharField(max_length=5) >> some_other_field = models.TextField(null=True, blank=True) >>