Re: RFC: #12815/#12816 -- TemplateResponse and render() shortcut

2010-11-28 Thread Jacob Kaplan-Moss
Hi Russ -- On Sun, Nov 28, 2010 at 1:13 AM, Russell Keith-Magee wrote: > For your consideration, I present a patch to resolve #12815 and > #12816, adding a TemplateResponse and a render() shortcut. Good stuff. A couple of things though: * I'm really not a fan of "bake()" and ".baked" -- it rea

Re: Question on ImageField width_field/height_field motivations

2010-11-28 Thread Jacob Kaplan-Moss
On Sat, Nov 27, 2010 at 1:55 AM, Tim Diggins wrote: > wondering why ImageField doesn't rely on width_field and height_field > (if present and populated) for the dimensions? (i.e. from ImageField's > perspective these seem to be "write-only" fields). > > This seems pretty unperformant (moving to ri

Re: Could the comments framework be more generic?

2010-11-28 Thread subs...@gmail.com
Heh, already put a few hours doing something like this. There's some django-discus attempts out there--have you looked at them? I haven't bothered to notice if any use the comments framework but it sure would be handy to make comments out of discus or backtype feeds or variants thereof. But whethe

Re: RFC: #12815/#12816 -- TemplateResponse and render() shortcut

2010-11-28 Thread sago
*very nice* Russ. Congrats and thanks! Totally removes a wart I've just got used to working around. "bake" is a pretty universal verb for this, afaict. I wouldn't say it was clever or new. "fry" however (in Jacob's post) was new to me and required googling. Ian. -- You received this message bec

Re: Pluggable encryption for django auth (design proposal)

2010-11-28 Thread Christophe Pettus
On Nov 27, 2010, at 10:29 PM, Tom X. Tobin wrote: > The point is that I'm *not* assuming hardware of equivalent speed. > I'm assuming that a worst-case attacker has hardware significantly > faster than your webserver at their disposal, so I was curious if the > purported benefit still held in that

Unexpected behaviour when providing bad input to CheckboxInput

2010-11-28 Thread Dan Fairs
Hi, I've come across some interesting behaviour if you intentionally supply bad data to a model formset whose forms use CheckboxInputs. Basically, it's possible to have custom validation code on the form class which ensures the boolean field's input is False, have this validation pass, but then

Re: Pluggable encryption for django auth (design proposal)

2010-11-28 Thread Tom X. Tobin
On Sun, Nov 28, 2010 at 12:11 PM, Christophe Pettus wrote: >> I'm not arguing that a salt helps against brute-forcing a *single* >> password (it doesn't), but it does in fact help against someone trying >> to brute-force your entire password database (or any subset of more >> than one password), s

Re: Could the comments framework be more generic?

2010-11-28 Thread Kevin Renskers
The existing apps use the JavaScript interface offered by Disqus. This does not integrate with apps that expect Django's comments app. I've made good progress on my comments app extension that uses Disqus, but now I am at a point where the models are working against me. Code is on bitbucket: http:

Re: Pluggable encryption for django auth (design proposal)

2010-11-28 Thread Christophe Pettus
On Nov 28, 2010, at 10:26 AM, Tom X. Tobin wrote: > No, I'm not thinking of rainbow tables. The key word here is > *single*. As I said before, a salt *does* help against an attacker > trying to brute-force multiple passwords from your database, since he > can't simply test each brute-force resul

Re: RFC: #12815/#12816 -- TemplateResponse and render() shortcut

2010-11-28 Thread Ivan Sagalaev
On 11/28/2010 10:13 AM, Russell Keith-Magee wrote: For your consideration, I present a patch to resolve #12815 and #12816, adding a TemplateResponse and a render() shortcut. Thank you! - The render() shortcut doesn't use TemplateResponse. Since render() and TemplateReponse() have exactly th

#12180: Test case advice

2010-11-28 Thread Christophe Pettus
Hi, I'm updating the patch for #12180 to work with the dev version of 1.3, and preparing a test case for it. Being new to the Django test suite, it's not clear to me how to introduce a backend-specific and settings-file-specific test (the test case requires PostgreSQL 8.2+ and AUTOCOMMIT: True

Re: Could the comments framework be more generic?

2010-11-28 Thread Kevin Renskers
Whoops, url should be https://bitbucket.org/bolhoed/django_disqus_comments. On Nov 28, 7:29 pm, Kevin Renskers wrote: > The existing apps use the JavaScript interface offered by Disqus. This > does not integrate with apps that expect Django's comments app. > > I've made good progress on my commen

Re: Could the comments framework be more generic?

2010-11-28 Thread Thejaswi Puthraya
Hi, I am the student who worked on improving the comments framework a couple of years back and have been absconding since then ;-) Personally, I would love to see the comments app out of contrib because of the need to maintain backwards compatibility especially for an app with very few users. On N

Re: #12180: Test case advice

2010-11-28 Thread Shai Berger
Hi, On Sunday 28 November 2010, Christophe Pettus wrote: > > I'm updating the patch for #12180 to work with the dev version of 1.3, and > preparing a test case for it. Being new to the Django test suite, it's > not clear to me how to introduce a backend-specific and > settings-file-specific test