Re: [PR] [optimization] Removed unused code [tomcat]

2025-03-26 Thread via GitHub
rmaucher commented on PR #833: URL: https://github.com/apache/tomcat/pull/833#issuecomment-2755690885 The purpose of the code is to check the configuration. For clarity, I would like to keep it that way. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [optimization] Removed unused code [tomcat]

2025-03-26 Thread via GitHub
rmaucher closed pull request #833: [optimization] Removed unused code URL: https://github.com/apache/tomcat/pull/833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Changed string comparison - need to use equals() instead of == or != [tomcat]

2025-03-26 Thread via GitHub
rmaucher closed pull request #834: Changed string comparison - need to use equals() instead of == or != URL: https://github.com/apache/tomcat/pull/834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] [optimization] Removed unused code [tomcat]

2025-03-26 Thread via GitHub
dk2k opened a new pull request, #833: URL: https://github.com/apache/tomcat/pull/833 the result of call Pattern.compile() isn't used. Variable int flags is redundant as a result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Changed string comparison - need to use equals() instead of == or != [tomcat]

2025-03-26 Thread via GitHub
dk2k commented on PR #834: URL: https://github.com/apache/tomcat/pull/834#issuecomment-2755612999 @rmaucher Purpose like what? == comparison is OK when both strings are interned, and I don't think it's the case. And it's safe to use equals() for interned strings anyway -- This is an a

[PR] Changed string concatenations to chained calls of append() [tomcat]

2025-03-26 Thread via GitHub
dk2k opened a new pull request, #835: URL: https://github.com/apache/tomcat/pull/835 Justification: each string concatenation becomes an anonimous stringbuilder, from which toString() result is used. It's about performance. -- This is an automated message from the Apache Git Service. T

Re: [PR] Changed string comparison - need to use equals() instead of == or != [tomcat]

2025-03-26 Thread via GitHub
markt-asf commented on PR #834: URL: https://github.com/apache/tomcat/pull/834#issuecomment-2755623844 There should be an explanation for each of those in the spot bugs exclusion file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Changed string comparison - need to use equals() instead of == or != [tomcat]

2025-03-26 Thread via GitHub
dk2k opened a new pull request, #834: URL: https://github.com/apache/tomcat/pull/834 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

Re: [PR] Changed string comparison - need to use equals() instead of == or != [tomcat]

2025-03-26 Thread via GitHub
rmaucher commented on PR #834: URL: https://github.com/apache/tomcat/pull/834#issuecomment-2755594755 This is most likely on purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Expanding Parallel Deployment section of Tomcat Docs [tomcat]

2025-03-26 Thread via GitHub
markt-asf closed pull request #832: Expanding Parallel Deployment section of Tomcat Docs URL: https://github.com/apache/tomcat/pull/832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Expanding Parallel Deployment section of Tomcat Docs [tomcat]

2025-03-26 Thread via GitHub
markt-asf commented on PR #832: URL: https://github.com/apache/tomcat/pull/832#issuecomment-2753632042 Nothing to do on your part. Thanks for the work you put into this. I've added a new runtime attribute section to the configuration documentation that documents the request and servlet cont

(tomcat) 01/02: Deprecate unused code

2025-03-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3265f22c60a9abd531dc66d57b6d1a5de9b0348a Author: Mark Thomas AuthorDate: Wed Mar 26 08:53:37 2025 + Deprecate unus

(tomcat) 02/02: Remove reference to deprecated code

2025-03-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 58cc087c20634a4e109d149981a63e18e64e99e9 Author: Mark Thomas AuthorDate: Wed Mar 26 08:53:49 2025 + Remove referen

(tomcat) branch main updated (d4086a2967 -> 58cc087c20)

2025-03-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from d4086a2967 Document the runtime attributes available to web applications. new 3265f22c60 Deprecate unused code

[Bug 69631] New: java.nio.channels.WritePendingException when using https-openssl-nio2 and virtual threads

2025-03-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69631 Bug ID: 69631 Summary: java.nio.channels.WritePendingException when using https-openssl-nio2 and virtual threads Product: Tomcat 11 Version: unspecified Hardware: PC

(tomcat) branch 10.1.x updated: Add simple Java Compiler for JSP

2025-03-26 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 5ff35e2bef Add simple Java Compiler for JSP 5ff35e

(tomcat) branch 11.0.x updated: Add simple Java Compiler for JSP

2025-03-26 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 79241fdb9b Add simple Java Compiler for JSP 79241f

(tomcat) branch 11.0.x updated: Document the runtime attributes available to web applications.

2025-03-26 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new f2223e2509 Document the runtime attributes availa

[Bug 69632] Cozy Home Spheres

2025-03-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69632 nekon changed: What|Removed |Added URL||https://www.weddingbee.com/

[Bug 69632] New: Cozy Home Spheres

2025-03-26 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69632 Bug ID: 69632 Summary: Cozy Home Spheres Product: Tomcat Native Version: unspecified Hardware: PC Status: NEW Severity: normal Priority: P2 Component