[Bug 66279] Tomcat

2022-10-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66279 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[GitHub] [tomcat] markt-asf commented on pull request #561: Introduce a method to skip the web.xml files scan.

2022-10-24 Thread GitBox
markt-asf commented on PR #561: URL: https://github.com/apache/tomcat/pull/561#issuecomment-1288563327 `webConfig()` does a lot more than just process web.xml files. The proposed method name is not appropriate. Please discuss the problem you are trying to solve on the mailing list be

[GitHub] [tomcat] markt-asf closed pull request #561: Introduce a method to skip the web.xml files scan.

2022-10-24 Thread GitBox
markt-asf closed pull request #561: Introduce a method to skip the web.xml files scan. URL: https://github.com/apache/tomcat/pull/561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #36: Improve composability when using from other tools

2022-10-24 Thread GitBox
aooohan commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1288571178 I like this PR, but I don't like the change of the Migration class as this change made a bit numerous and a bit hassle. I think we could add a field to identify whether ha

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

2022-10-24 Thread GitBox
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1288624526 The migrator was stateless in terms of the result, so I figured that was a goal, which is why I went with method returns. Would this method throw if execute()

[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #36: Improve composability when using from other tools

2022-10-24 Thread GitBox
aooohan commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1288655837 Hi @DanielThomas , > The migrator was stateless in terms of the result, so I figured that was a goal, which is why I went with method returns. On the contrary, I

[GitHub] [tomcat] m0ver commented on pull request #561: Introduce a method to skip the web.xml files scan.

2022-10-24 Thread GitBox
m0ver commented on PR #561: URL: https://github.com/apache/tomcat/pull/561#issuecomment-1288977267 Thanks Mark! I'm using tomcat embed server as one of web servers in my application. Just notice that `webConfig()` needs to process a lot of things related web.xml which seems not to b

[Bug 66279] Remote application deployment is failing

2022-10-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66279 Christopher Schultz changed: What|Removed |Added Summary|Tomcat |Remote application

Re: [DISCUSS] EOL date for 8.5.x

2022-10-24 Thread jean-frederic clere
On 10/7/22 11:27, Mark Thomas wrote: Based on the above I think EOL for 8.5.x should be either 31 March 2024 +1 -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-m

svn commit: r1904814 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

2022-10-24 Thread schultz
Author: schultz Date: Mon Oct 24 17:46:00 2022 New Revision: 1904814 URL: http://svn.apache.org/viewvc?rev=1904814&view=rev Log: Add presentations from ApacheCon NA 2022. Modified: tomcat/site/trunk/docs/presentations.html tomcat/site/trunk/xdocs/presentations.xml Modified: tomcat/site/t

[GitHub] [tomcat] markt-asf commented on pull request #561: Introduce a method to skip the web.xml files scan.

2022-10-24 Thread GitBox
markt-asf commented on PR #561: URL: https://github.com/apache/tomcat/pull/561#issuecomment-1289423840 The discussion belongs on the mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

svn commit: r1904816 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2022-10-24 Thread markt
Author: markt Date: Mon Oct 24 19:26:31 2022 New Revision: 1904816 URL: http://svn.apache.org/viewvc?rev=1904816&view=rev Log: Add superseded marker to 10.0.x Modified: tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/xdocs/whichversion.xml Modified: tomcat/site/trunk/docs/whic

[Bug 66320] NPE in checkResources

2022-10-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66320 Peter Rader changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

2022-10-24 Thread GitBox
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1289903755 Great, I'll make those changes! > BTW, for the use of migrators, I believe that a task should correspond to a migrator, rather than one migrator being used repe

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

2022-10-24 Thread GitBox
DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1289917738 All done here @aooohan. Let me know if there's anything else you'd like changed. -- This is an automated message from the Apache Git Service. To respond to the mess