Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
Hi, A long time ago (in this galaxy, not another one), Tomcat has added the capability to have multiple accept threads. I have no idea what test revealed that Tomcat was somehow not accepting sockets fast enough, and maybe it could be the case in crazy microbenchmarks, but this is not going to hap

Re: Multi threaded accept and polling

2019-05-09 Thread Mark Thomas
On 09/05/2019 12:45, Rémy Maucherat wrote: > Hi, > > A long time ago (in this galaxy, not another one), Tomcat has added the > capability to have multiple accept threads. I have no idea what test > revealed that Tomcat was somehow not accepting sockets fast enough, and > maybe it could be the case

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 2:36 PM Mark Thomas wrote: > accept() is effectively synchronized at the OS level. > > I recall doing some testing on this and there was a small gain in > throughput when testing on localhost without keep-alive if I used two > accept threads. Essentially, one thread was acc

[tomcat] branch master updated: Remove acceptorThreadCount attribute

2019-05-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e9e9b22 Remove acceptorThreadCount attribute e9e9

[tomcat] branch 8.5.x updated: Sync NIO2 IO code with trunk

2019-05-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6f354d0 Sync NIO2 IO code with trunk 6f354d0 is des

Re: Multi threaded accept and polling

2019-05-09 Thread Mark Thomas
On 09/05/2019 14:38, Rémy Maucherat wrote: >> +1 to hard-coding to a single acceptor thread and removing the plumbing >> that supports more than that. > > Ok, done. Great. > So I suppose you prefer keeping the ability to have multiple poller threads > for NIO ? NIO defaults to 1 anyway. I a

buildbot success in on tomcat-85-trunk

2019-05-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1765 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchS

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 4:47 PM Mark Thomas wrote: > On 09/05/2019 14:38, Rémy Maucherat wrote: > > > > >> +1 to hard-coding to a single acceptor thread and removing the plumbing > >> that supports more than that. > > > > Ok, done. > > Great. > > > So I suppose you prefer keeping the ability to h

[tomcat] branch master updated: Avoid possible NPE on commit

2019-05-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 659b28c Avoid possible NPE on commit 659b28c is d

Re: Multi threaded accept and polling

2019-05-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy and Mark, On 5/9/19 12:32, Rémy Maucherat wrote: > On Thu, May 9, 2019 at 4:47 PM Mark Thomas > wrote: > >> On 09/05/2019 14:38, Rémy Maucherat wrote: >> >> >> +1 to hard-coding to a single acceptor thread and removing the plumbi

Re: Multi threaded accept and polling

2019-05-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/9/19 12:49, Mark Thomas wrote: > On 09/05/2019 17:44, Christopher Schultz wrote: >> Rémy and Mark, >> >> On 5/9/19 12:32, Rémy Maucherat wrote: >>> On Thu, May 9, 2019 at 4:47 PM Mark Thomas >>> wrote: >> On 09/05/2019 14:38, Rém

Re: Multi threaded accept and polling

2019-05-09 Thread Mark Thomas
On 09/05/2019 17:44, Christopher Schultz wrote: > Rémy and Mark, > > On 5/9/19 12:32, Rémy Maucherat wrote: >> On Thu, May 9, 2019 at 4:47 PM Mark Thomas >> wrote: > >>> On 09/05/2019 14:38, Rémy Maucherat wrote: >>> >>> >>> > +1 to hard-coding to a single acceptor thread and removing >

Punishing bad clients with delays

2019-05-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, What are the options we might have to "punish" an HTTP client that we don't like for some reason? Specifically, I'd like to be able to write a servlet that ties-up the response to the client for a while for some bad behavior. For example, mayb

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 6:44 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy and Mark, > > On 5/9/19 12:32, Rémy Maucherat wrote: > > On Thu, May 9, 2019 at 4:47 PM Mark Thomas > > wrote: > > > >> On 09/05/2019 14:38, Rémy

[GitHub] [tomcat] rmaucher opened a new pull request #163: Remove multiple pollers from NIO

2019-05-09 Thread GitBox
rmaucher opened a new pull request #163: Remove multiple pollers from NIO URL: https://github.com/apache/tomcat/pull/163 NIO2 manages without it, so it should work fine overall. This allows removing a lot of complexity and disconnect between channel <-> wrapper <-> poller, as both now

[tomcat] 02/03: Fix Javadoc warning

2019-05-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e838da5109fdad1331cb3a6a51c3860b01ee9896 Author: Mark Thomas AuthorDate: Thu May 9 20:29:35 2019 +0100 Fix Javadoc w

[tomcat] 01/03: Fix Javadoc warnings

2019-05-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 97e7bfbbb492a337044adf377a1d1ee9b0f8be2e Author: Mark Thomas AuthorDate: Thu May 9 20:28:59 2019 +0100 Fix Javadoc w

[tomcat] branch master updated (659b28c -> cfc165d)

2019-05-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 659b28c Avoid possible NPE on commit new 97e7bfb Fix Javadoc warnings new e838da5 Fix Javadoc warning

[tomcat] 03/03: Add @Deprecated to deprecated methods to silence IDE warnings

2019-05-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cfc165d667e7dda1389396b20d58ee06316340fb Author: Mark Thomas AuthorDate: Thu May 9 20:30:23 2019 +0100 Add @Deprecat

buildbot failure in on tomcat-trunk

2019-05-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4322 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Fix javadoc too.

2019-05-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new df2424e Fix javadoc too. df2424e is described bel

buildbot success in on tomcat-trunk

2019-05-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4323 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

Re: [tomcat] branch master updated: Make sure timeout elapses before calling a timeout

2019-05-09 Thread Mark Thomas
On 05/05/2019 09:37, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

[GitHub] [tomcat] farnulfo opened a new pull request #164: Create .travis.yml

2019-05-09 Thread GitBox
farnulfo opened a new pull request #164: Create .travis.yml URL: https://github.com/apache/tomcat/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [tomcat] farnulfo closed pull request #164: Create .travis.yml

2019-05-09 Thread GitBox
farnulfo closed pull request #164: Create .travis.yml URL: https://github.com/apache/tomcat/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL