svn commit: r1811170 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 08:27:39 2017 New Revision: 1811170 URL: http://svn.apache.org/viewvc?rev=1811170&view=rev Log: Add jfclere's TomcatCon London slides Modified: tomcat/site/trunk/docs/presentations.html tomcat/site/trunk/xdocs/presentations.xml Modified: tomcat/site/trunk/d

svn commit: r1811174 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 09:11:38 2017 New Revision: 1811174 URL: http://svn.apache.org/viewvc?rev=1811174&view=rev Log: Deprecate some unused code that overrides a method that has been deprecated in Java 9 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.ja

svn commit: r1811175 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 09:12:54 2017 New Revision: 1811175 URL: http://svn.apache.org/viewvc?rev=1811175&view=rev Log: Deprecate some unused code that overrides a method that has been deprecated in Java 9 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/jav

svn commit: r1811176 - /tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 09:15:25 2017 New Revision: 1811176 URL: http://svn.apache.org/viewvc?rev=1811176&view=rev Log: Long.valueOf() is better than new Long() Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java Modified: tomcat/trunk/java/org/apache/tomcat/util

svn commit: r1811177 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/SSLHostConfig.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 09:15:51 2017 New Revision: 1811177 URL: http://svn.apache.org/viewvc?rev=1811177&view=rev Log: Long.valueOf() is better than new Long() Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/SSLHostConfig.java

svn commit: r1811198 - in /tomcat/trunk/java/org/apache/catalina: filters/ ha/session/ loader/ mbeans/ realm/ security/ session/ startup/ storeconfig/ util/ valves/ valves/rewrite/

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 12:44:21 2017 New Revision: 1811198 URL: http://svn.apache.org/viewvc?rev=1811198&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in o.a.catalina Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfP

svn commit: r1811199 - in /tomcat/trunk/java/org/apache/jasper: ./ compiler/ runtime/

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 12:50:14 2017 New Revision: 1811199 URL: http://svn.apache.org/viewvc?rev=1811199&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in o.a.jasper Modified: tomcat/trunk/java/org/apache/jasper/JspCompilationCon

svn commit: r1811200 - in /tomcat/trunk/java/org/apache/juli: ClassLoaderLogManager.java FileHandler.java logging/DirectJDKLog.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 12:51:53 2017 New Revision: 1811200 URL: http://svn.apache.org/viewvc?rev=1811200&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in o.a.juli Modified: tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager

svn commit: r1811201 - in /tomcat/trunk/java/org/apache/naming/factory: BeanFactory.java EjbFactory.java FactoryBase.java ResourceFactory.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 12:55:10 2017 New Revision: 1811201 URL: http://svn.apache.org/viewvc?rev=1811201&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in o.a.naming Modified: tomcat/trunk/java/org/apache/naming/factory/BeanFacto

request.getServerPort with RemoteIpValve

2017-10-05 Thread Niki Dokovski
Hi, May I ask for your opinion on the following case: When RemoteIpValve is enabled getServerPort returns inconsistent value depending on the presence of protocolHeader (“x-forwarded-proto” by default) Here is a short example 1) no x-forwarded-proto curl -H "Host: myserverhost:32279" -H "x-forw

buildbot failure in on tomcat-trunk

2017-10-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2736 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1811203 - in /tomcat/trunk/java/org/apache/tomcat: ./ dbcp/dbcp2/ dbcp/pool2/impl/ util/digester/ util/modeler/ util/net/ util/net/jsse/ websocket/ websocket/pojo/ websocket/server/

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 13:08:33 2017 New Revision: 1811203 URL: http://svn.apache.org/viewvc?rev=1811203&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in o.a.tomcat Modified: tomcat/trunk/java/org/apache/tomcat/SimpleInstanceMan

svn commit: r1811205 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc: naming/GenericNamingResourcesFactory.java pool/ConnectionPool.java pool/PoolProperties.java pool/PooledC

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 13:13:44 2017 New Revision: 1811205 URL: http://svn.apache.org/viewvc?rev=1811205&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in jdbc-pool Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apac

svn commit: r1811204 - in /tomcat/trunk/test/org/apache: catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java catalina/loader/TestWebappClassLoaderWeaving.java catalina/tribes/demos/Channel

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 13:13:27 2017 New Revision: 1811204 URL: http://svn.apache.org/viewvc?rev=1811204&view=rev Log: Fix some more deprecation warnings when building with Java 9. Use of Class.newInstance() in test code Modified: tomcat/trunk/test/org/apache/catalina/loader/TestWeba

svn commit: r1811206 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 13:20:14 2017 New Revision: 1811206 URL: http://svn.apache.org/viewvc?rev=1811206&view=rev Log: Update test to fix failure after newInstance() refactoring Modified: tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java Modified: tomcat/tru

buildbot success in on tomcat-trunk

2017-10-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2739 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

Re: svn commit: r1811200 - in /tomcat/trunk/java/org/apache/juli: ClassLoaderLogManager.java FileHandler.java logging/DirectJDKLog.java

2017-10-05 Thread Konstantin Kolinko
See "Re:r1791050" thread, 12 Apr 2017. You should use getConstructor() here! Methods newInstance(), getConstructor() use a public constructor, but getDeclared*() may return a non-public method and using it requires additional privileges (checkMemberAccess(this, Member.DECLARED)). Javadoc: http:/

Re: svn commit: r1811200 - in /tomcat/trunk/java/org/apache/juli: ClassLoaderLogManager.java FileHandler.java logging/DirectJDKLog.java

2017-10-05 Thread Mark Thomas
On 5 October 2017 15:43:56 BST, Konstantin Kolinko wrote: >See "Re:r1791050" thread, 12 Apr 2017. You should use getConstructor() >here! > >Methods newInstance(), getConstructor() use a public constructor, but >getDeclared*() may return a non-public method and using it requires >additional privi

[GitHub] tomcat pull request #76: added SessionInitializerFilter

2017-10-05 Thread isapir
GitHub user isapir opened a pull request: https://github.com/apache/tomcat/pull/76 added SessionInitializerFilter This Filter initializes the HttpSession object for the Request, which is required for certain operations with WebSocket requests where it is too late to initialize the

[GitHub] tomcat issue #76: added SessionInitializerFilter

2017-10-05 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/76 Actually, I just noticed that `javax.servlet.Filter` added default no-op `init()` and `destroy()` (yay!), so this Filter can be modified to implement `javax.servlet.Filter` instead of extending `javax.

[GitHub] tomcat issue #76: added SessionInitializerFilter

2017-10-05 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/76 I updated accordingly to save a few CPU cycles and a few bytes of memory for each Request that hits the Filter. Cumulative change can be seen at https://github.com/apache/tomcat/pull/76/file

[GitHub] tomcat issue #76: added SessionInitializerFilter

2017-10-05 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/76 p.s. I noticed that you sometimes backport code to 8.5 and even further back. If you accept this patch, and if you want to backport, I can issue a different patch since this one will not work on 8.x w

svn commit: r1811220 - in /tomcat/trunk: java/org/apache/catalina/filters/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/loader/ java/org/apache/catalina/mbeans/ java/org/apache/catali

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 18:19:57 2017 New Revision: 1811220 URL: http://svn.apache.org/viewvc?rev=1811220&view=rev Log: getDeclaredConstructor() -> getConstructor() Modified: tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilterBase.java tomcat/trunk/java/org/apache/ca

svn commit: r1811226 - in /tomcat/trunk/java/org/apache/tomcat/util/scan: LocalStrings.properties StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 18:50:26 2017 New Revision: 1811226 URL: http://svn.apache.org/viewvc?rev=1811226&view=rev Log: Start to improved Java 9 JAR scanning Make StandardJarScanner easier to extend Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/LocalStrings.properties tom

svn commit: r1811229 - /tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 19:02:06 2017 New Revision: 1811229 URL: http://svn.apache.org/viewvc?rev=1811229&view=rev Log: Start to improved Java 9 JAR scanning Make StandardJarScanner easier to extend Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.jav

svn commit: r1811231 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 19:03:12 2017 New Revision: 1811231 URL: http://svn.apache.org/viewvc?rev=1811231&view=rev Log: Start to improved Java 9 JAR scanning Make StandardJarScanner easier to extend Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.jav

svn commit: r1811235 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 19:21:18 2017 New Revision: 1811235 URL: http://svn.apache.org/viewvc?rev=1811235&view=rev Log: Avoid duplicate processing Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/St

svn commit: r1811236 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 19:21:55 2017 New Revision: 1811236 URL: http://svn.apache.org/viewvc?rev=1811236&view=rev Log: Avoid duplicate processing Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Propc

svn commit: r1811238 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 19:22:26 2017 New Revision: 1811238 URL: http://svn.apache.org/viewvc?rev=1811238&view=rev Log: Avoid duplicate processing Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Propc

svn commit: r1811241 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 19:35:23 2017 New Revision: 1811241 URL: http://svn.apache.org/viewvc?rev=1811241&view=rev Log: Start to improved Java 9 JAR scanning Make StandardJarScanner easier to extend Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.jav

svn commit: r1811246 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 20:02:13 2017 New Revision: 1811246 URL: http://svn.apache.org/viewvc?rev=1811246&view=rev Log: Create file from correct String Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/trunk/java/org/apache/tomcat/util/sc

svn commit: r1811247 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 20:02:47 2017 New Revision: 1811247 URL: http://svn.apache.org/viewvc?rev=1811247&view=rev Log: Create file from correct String Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

svn commit: r1811248 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 20:03:07 2017 New Revision: 1811248 URL: http://svn.apache.org/viewvc?rev=1811248&view=rev Log: Create file from correct String Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

svn commit: r1811249 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 20:03:40 2017 New Revision: 1811249 URL: http://svn.apache.org/viewvc?rev=1811249&view=rev Log: Create file from correct String Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/tc7.0.x/trunk/java/org/apa

buildbot failure in on tomcat-7-trunk

2017-10-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/905 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1811264 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2017-10-05 Thread markt
Author: markt Date: Thu Oct 5 21:57:08 2017 New Revision: 1811264 URL: http://svn.apache.org/viewvc?rev=1811264&view=rev Log: Fix silly refactoring error Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/

buildbot success in on tomcat-7-trunk

2017-10-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/907 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 59703] RFC 6265 Cookie Processor doesn't allow cookie domains with a leading dot.

2017-10-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59703 --- Comment #4 from jer...@noskilz.com --- It'd probably be good to have also included this as breaking backwards compatibility. The widespread configuration documentation in the wild for cookie subdomains that says to use the .example.com defi

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2017-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration.

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2017-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration.

[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2017-10-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

Re: [ANN] Apache Tomcat 7.0.82 released

2017-10-05 Thread vishal suvagia
Hi,   This is in relation to 7.0.82 release announcement. Currently Ranger uses Tomcat as an embedded server, and we currently use  the 7.0 bits and build 7.0.77, we are planning to use the latest updated bits i.e as of now 7.0.82.               Hence I tried an upgrade to that version and did a