svn commit: r1493690 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 09:24:11 2013 New Revision: 1493690 URL: http://svn.apache.org/r1493690 Log: FindBugs false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/viewv

svn commit: r1493691 - /tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 09:27:20 2013 New Revision: 1493691 URL: http://svn.apache.org/r1493691 Log: Any post-7.0.x issues can be fixed now in trunk Removed: tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml - To

svn commit: r1493729 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ test/org/apache/catalina/authenticator/ test/org/apache/catalina/startup/

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 12:23:51 2013 New Revision: 1493729 URL: http://svn.apache.org/r1493729 Log: Servlet 3.1 - Switch to using 303 rather than 302 redirects for HTTP/1.1 requests Modified: tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java tomcat/trunk/

The future of Realm's allRolesMode

2013-06-17 Thread Mark Thomas
Servlet 3.1 has introduced the new special role of "**" to mean any authenticated user. With this new feature, Tomcat's allRolesMode attribute on the Realm is no longer necessary. My preference is to remove the allRolesMode attribute and supporting code in Tomcat 8. Are they any objections (wi

svn commit: r1493740 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 12:36:52 2013 New Revision: 1493740 URL: http://svn.apache.org/r1493740 Log: Fix indents Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticat

svn commit: r1493801 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java test/org/apache/catalina/authenticator/TestFormAuthenticator.java

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 15:00:56 2013 New Revision: 1493801 URL: http://svn.apache.org/r1493801 Log: Servlet 3.1. If GET is not protected but other methods are, the redirect after authentication (that now always uses a GET) fails. Because it is unprotected it is not passed to the FORM aut

Re: svn commit: r1493801 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java test/org/apache/catalina/authenticator/TestFormAuthenticator.java

2013-06-17 Thread Mark Thomas
On 17/06/2013 16:00, ma...@apache.org wrote: Author: markt Date: Mon Jun 17 15:00:56 2013 New Revision: 1493801 URL: http://svn.apache.org/r1493801 Log: Servlet 3.1. If GET is not protected but other methods are, the redirect after authentication (that now always uses a GET) fails. Because it i

Re: MD5Encoder.encode versus HexUtils.toHexString

2013-06-17 Thread Christopher Schultz
Mark, On 6/16/13 12:04 PM, Mark Thomas wrote: > On 15/06/2013 16:39, Christopher Schultz wrote: >> All, >> >> While looking into a patch for BasicRealm, I noticed that there are two >> classes that convert byte[] to a hex-encoded string (e.g. byte[] { 1, 2, >> a, b ] -> "12ab"): HexUtils and MD5En

Re: MD5Encoder.encode versus HexUtils.toHexString

2013-06-17 Thread Christopher Schultz
Chris, On 6/17/13 11:38 AM, Christopher Schultz wrote: >> Mark Thomas wrote >>> I haven't actually written any performance tests, but looking at the >>> code it seems that HexUtils.toHexString would execute slightly faster >>> for a 16-byte array because of repeated integer multiplication in the l

[Bug 55108] New: Wasted work in "AbstractReplicatedMap.excludeFromSet"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55108 Bug ID: 55108 Summary: Wasted work in "AbstractReplicatedMap.excludeFromSet" Product: Tomcat 7 Version: 7.0.41 Hardware: PC OS: Linux Status: NEW Se

[Bug 55108] Wasted work in "AbstractReplicatedMap.excludeFromSet"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55108 Adrian Nistor changed: What|Removed |Added Keywords||PatchAvailable CC|

[Bug 55109] New: Wasted work in "WebdavServlet.isLocked"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55109 Bug ID: 55109 Summary: Wasted work in "WebdavServlet.isLocked" Product: Tomcat 7 Version: 7.0.41 Hardware: PC OS: Linux Status: NEW Severity: normal

[Bug 55109] Wasted work in "WebdavServlet.isLocked"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55109 Adrian Nistor changed: What|Removed |Added Keywords||PatchAvailable CC|

[Bug 55110] New: Wasted work in "TestNonLoginAndBasicAuthenticator.doTestBasic"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55110 Bug ID: 55110 Summary: Wasted work in "TestNonLoginAndBasicAuthenticator.doTestBasic" Product: Tomcat 7 Version: 7.0.41 Hardware: PC OS: Linux

[Bug 55110] Wasted work in "TestNonLoginAndBasicAuthenticator.doTestBasic"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55110 --- Comment #1 from Adrian Nistor --- Created attachment 30451 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30451&action=edit patch2 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 55110] Wasted work in "TestNonLoginAndBasicAuthenticator.doTestBasic"

2013-06-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55110 Adrian Nistor changed: What|Removed |Added Keywords||PatchAvailable CC|

svn commit: r1493908 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestFormAuthenticator.java

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 19:57:41 2013 New Revision: 1493908 URL: http://svn.apache.org/r1493908 Log: Fix indents Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java Propchange: tomcat/tc7.0.x/tru

svn commit: r1493910 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 20:07:01 2013 New Revision: 1493910 URL: http://svn.apache.org/r1493910 Log: Make base class abstract Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestFo

svn commit: r1493918 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java test/org/apache/catalina/authenticator/TestFormAuthenticator.java webapps/docs/changel

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 20:17:03 2013 New Revision: 1493918 URL: http://svn.apache.org/r1493918 Log: If GET is not protected but other methods are, the redirect after authentication (that normally uses GET) fails. Because it is unprotected it is not passed to the FORM authenticator for pr

svn commit: r1493927 - /tomcat/trunk/java/org/apache/catalina/deploy/SecurityConstraint.java

2013-06-17 Thread markt
Author: markt Date: Mon Jun 17 20:37:33 2013 New Revision: 1493927 URL: http://svn.apache.org/r1493927 Log: Make addAuthRole() and removeAuthRole() consistent Modified: tomcat/trunk/java/org/apache/catalina/deploy/SecurityConstraint.java Modified: tomcat/trunk/java/org/apache/catalina/deploy