Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Konstantin Kolinko
2011/9/20 : > Author: markt > Date: Tue Sep 20 17:05:08 2011 > New Revision: 1173251 > > URL: http://svn.apache.org/viewvc?rev=1173251&view=rev > Log: > Don't add to Poller when socket is closing to prevent NPEs. > > Modified: >    tomcat/tc7.0.x/trunk/   (props changed) >    tomcat/tc7.0.x/trunk/

DO NOT REPLY [Bug 43478] Using client flush before commit loses headers

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43478 --- Comment #5 from Konstantin Kolinko 2011-09-26 07:17:40 UTC --- (In reply to comment #4) > is there any plan to backport this patch to Apache 2.2? As far as I see this is already covered by the following commit in mod_jk: http://svn.ap

Re: Mailing list for the Tomcat Maven Plugin

2011-09-26 Thread Olivier Lamy
2011/9/25 Konstantin Kolinko : > 2011/9/14 Olivier Lamy : >> Hello Folks, >> I wonder if we have to create separates mailing lists or using the >> default tomcat mls ? (some users ping me directly to have separates) >> Let me know what is your opinion on that ? > > There is a precedent: the Taglibs

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2011-09-26 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-09-26 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

svn commit: r1175713 - /tomcat/trunk/java/org/apache/juli/OneLineFormatter.java

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 08:39:05 2011 New Revision: 1175713 URL: http://svn.apache.org/viewvc?rev=1175713&view=rev Log: Add thread name to OneLineFormatter. Modified: tomcat/trunk/java/org/apache/juli/OneLineFormatter.java Modified: tomcat/trunk/java/org/apache/juli/OneLineFormatter.j

svn commit: r1175717 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 08:43:03 2011 New Revision: 1175717 URL: http://svn.apache.org/viewvc?rev=1175717&view=rev Log: Add thread name to juli OneLineFormatter. Merge of r1175713 from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jul

svn commit: r1175721 - in /tomcat/tc6.0.x/trunk: java/org/apache/juli/DateFormatCache.java java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 08:55:14 2011 New Revision: 1175721 URL: http://svn.apache.org/viewvc?rev=1175721&view=rev Log: Backport (copy in) JULI OneLineFormatter plus DateFormatCache helper class from TC 7 JULI. Added: tomcat/tc6.0.x/trunk/java/org/apache/juli/DateFormatCache.java (wi

svn commit: r1175723 - in /tomcat/tc6.0.x/trunk: java/org/apache/juli/DateFormatCache.java java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 09:00:26 2011 New Revision: 1175723 URL: http://svn.apache.org/viewvc?rev=1175723&view=rev Log: Oups, revert r1175721, we are RTC. Will propose instead, sorry for the noise. Removed: tomcat/tc6.0.x/trunk/java/org/apache/juli/DateFormatCache.java tomcat/tc6.0

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-09-26 Thread Konstantin Kolinko
2011/9/26 Bill Barker > [checkstyle] Running Checkstyle 5.5-SNAPSHOT on 2069 files > [checkstyle] > /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/http/fileupload/util/Streams.java:179:59: > Got an exception - expecting '5', found '0' > [checkstyle] > /srv/gump/public/works

svn commit: r1175736 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/modeler/BaseModelMBean.java

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 09:16:33 2011 New Revision: 1175736 URL: http://svn.apache.org/viewvc?rev=1175736&view=rev Log: Merged revisions r1174322, r1174329 from tomcat/trunk: Document thrown exception. This suppresses "Exception is never thrown" warning in Eclipse. Modified: tomcat

svn commit: r1175744 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 09:31:52 2011 New Revision: 1175744 URL: http://svn.apache.org/viewvc?rev=1175744&view=rev Log: Proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r1175778 - in /tomcat/site/trunk: docs/security-5.html docs/security-6.html docs/security-7.html xdocs/security-5.xml xdocs/security-6.xml xdocs/security-7.xml

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 10:36:53 2011 New Revision: 1175778 URL: http://svn.apache.org/viewvc?rev=1175778&view=rev Log: Add CVE-2011-1184 Modified: tomcat/site/trunk/docs/security-5.html tomcat/site/trunk/docs/security-6.html tomcat/site/trunk/docs/security-7.html tomcat/si

svn propchange: r1159309 - svn:log

2011-09-26 Thread markt
Author: markt Revision: 1159309 Modified property: svn:log Modified: svn:log at Mon Sep 26 10:38:59 2011 -- --- svn:log (original) +++ svn:log Mon Sep 26 10:38:59 2011 @@ -1 +1,2 @@ Add additional configuration options to

svn propchange: r1158180 - svn:log

2011-09-26 Thread markt
Author: markt Revision: 1158180 Modified property: svn:log Modified: svn:log at Mon Sep 26 10:39:23 2011 -- --- svn:log (original) +++ svn:log Mon Sep 26 10:39:23 2011 @@ -1 +1,2 @@ Add additional configuration options to

svn propchange: r1087655 - svn:log

2011-09-26 Thread markt
Author: markt Revision: 1087655 Modified property: svn:log Modified: svn:log at Mon Sep 26 10:40:00 2011 -- --- svn:log (original) +++ svn:log Mon Sep 26 10:40:00 2011 @@ -1 +1,2 @@ Add additional configuration options to

[SECURITY] CVE-2011-1184 Apache Tomcat - Multiple weaknesses in HTTP DIGEST authentication

2011-09-26 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CVE-2011-1184 Apache Tomcat - Multiple weaknesses in HTTP DIGEST authentication Severity: Moderate Vendor: The Apache Software Foundation Versions Affected: - - Tomcat 7.0.0 to 7.0.11 - - Tomcat 6.0.0 to 6.0.32 - - Tomcat 5.5.0 to 5.5.33 - - Earlier

svn commit: r1175798 - /tomcat/trunk/RUNNING.txt

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 11:14:23 2011 New Revision: 1175798 URL: http://svn.apache.org/viewvc?rev=1175798&view=rev Log: Improve RUNNING.txt by adding the following: - Mention that CATALINA_HOME should have a correct value or be absent (BZ 51806) - Mention environment variables that are u

Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Mark Thomas
On 26/09/2011 08:00, Konstantin Kolinko wrote: > 2011/9/20 : >> Author: markt >> Date: Tue Sep 20 17:05:08 2011 >> New Revision: 1173251 >> >> URL: http://svn.apache.org/viewvc?rev=1173251&view=rev >> Log: >> Don't add to Poller when socket is closing to prevent NPEs. >> >> Modified: >>tomcat/

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #14 from Harikrishnadhas Krishnaraj 2011-09-26 13:06:20 UTC --- I'm Eagerly looking out tomcat to implement the Web Socket -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are r

svn commit: r1175889 - in /tomcat/trunk/test/org/apache/catalina/tribes/test/channel: TestDataIntegrity.java TestMulticastPackages.java TestUdpPackages.java

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 14:44:48 2011 New Revision: 1175889 URL: http://svn.apache.org/viewvc?rev=1175889&view=rev Log: Remove unused code Modified: tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java tomcat/trunk/test/org/apache/catalina/tribes/test/

svn commit: r1175891 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/tribes/test/channel/ webapps/docs/

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 14:46:50 2011 New Revision: 1175891 URL: http://svn.apache.org/viewvc?rev=1175891&view=rev Log: Remove unused code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java

DO NOT REPLY [Bug 51893] New: JMX notification/Exception for empty/exhausted connection pool

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51893 Bug #: 51893 Summary: JMX notification/Exception for empty/exhausted connection pool Product: Tomcat Modules Version: unspecified Platform: PC OS/Version: Li

svn commit: r1175896 - in /tomcat/trunk: java/org/apache/catalina/startup/Embedded.java java/org/apache/catalina/valves/StuckThreadDetectionValve.java test/org/apache/tomcat/util/threads/TestLimitLatc

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 14:59:59 2011 New Revision: 1175896 URL: http://svn.apache.org/viewvc?rev=1175896&view=rev Log: Fix some FindBugs warnings Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetection

svn commit: r1175897 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Embedded.java java/org/apache/catalina/valves/StuckThreadDetectionValve.java test/org/apache/tomcat/util/threads/Te

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 15:01:21 2011 New Revision: 1175897 URL: http://svn.apache.org/viewvc?rev=1175897&view=rev Log: Fix some FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Embedded.java tomcat/tc7.0

svn commit: r1175907 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 15:32:07 2011 New Revision: 1175907 URL: http://svn.apache.org/viewvc?rev=1175907&view=rev Log: Fix a FindBugs warning Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java URL:

svn commit: r1175908 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 15:32:53 2011 New Revision: 1175908 URL: http://svn.apache.org/viewvc?rev=1175908&view=rev Log: Fix a FindBugs warning Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java Propchange: tomcat/tc

Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Mark Thomas
On 26/09/2011 13:46, Mark Thomas wrote: > On 26/09/2011 08:00, Konstantin Kolinko wrote: >> 2011/9/20 : >>> Author: markt >>> Date: Tue Sep 20 17:05:08 2011 >>> New Revision: 1173251 >>> >>> URL: http://svn.apache.org/viewvc?rev=1173251&view=rev >>> Log: >>> Don't add to Poller when socket is clos

svn commit: r1175933 - /tomcat/trunk/TOMCAT-NEXT.txt

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 16:15:25 2011 New Revision: 1175933 URL: http://svn.apache.org/viewvc?rev=1175933&view=rev Log: Add to the Tomcat 8 TODOs Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.t

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 --- Comment #3 from Stephan Maminakis 2011-09-26 17:48:19 UTC --- Mark, I have just upgraded from 7.0.20 to 7.0.21 and I think this resolution has affected a very simple error page that I have had in my web app since Tomcat 5. We have ou

DO NOT REPLY [Bug 51894] New: Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 Bug #: 51894 Summary: Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat Product: Tomcat 7 Version: 7.0.21 Platform: PC

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #1 from Jacob Wu 2011-09-26 18:32:13 UTC --- Created attachment 27598 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27598 Demonstration -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=e

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #2 from Christopher Schultz 2011-09-26 19:01:24 UTC --- I'm not a Spring user: does the "" in demo-servlet.xml configure Spring's front controller to act like the "default" servlet and therefore serve static content? Otherwise,

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #3 from Jacob Wu 2011-09-26 19:08:08 UTC --- "" configures spring to forward requests for static content along to the servlet container's default servlet. http://static.springsource.org/spring/docs/current/spring-framework-ref

DO NOT REPLY [Bug 18500] Host aliases to match by regular expression

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=18500 --- Comment #9 from Christopher Schultz 2011-09-26 19:10:58 UTC --- Suffix-matching would certainly be faster than regular expression matching, but it has the same problems the regex's have with not being sortable, etc. Suffix-matching se

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #4 from Jacob Wu 2011-09-26 19:14:26 UTC --- I should also mention that we tried dynamically including static content in Jetty and it worked as we had expected. The attached sample also works in Jetty but not on tomcat. Tomca

svn commit: r1176101 - in /tomcat/site/trunk: docs/security-6.html xdocs/security-6.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:18:25 2011 New Revision: 1176101 URL: http://svn.apache.org/viewvc?rev=1176101&view=rev Log: Add release date Modified: tomcat/site/trunk/docs/security-6.html tomcat/site/trunk/xdocs/security-6.xml Modified: tomcat/site/trunk/docs/security-6.html URL:

svn commit: r1176103 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:33:11 2011 New Revision: 1176103 URL: http://svn.apache.org/viewvc?rev=1176103&view=rev Log: Add CVE number. Sort issues by number. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: h

svn commit: r1176109 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:47:03 2011 New Revision: 1176109 URL: http://svn.apache.org/viewvc?rev=1176109&view=rev Log: Add CVE number. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/vi

svn commit: r1176126 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 23:12:02 2011 New Revision: 1176126 URL: http://svn.apache.org/viewvc?rev=1176126&view=rev Log: Simplify code in NioEndpoint$Poller. The events.size() call is costly, because it is a loop that counts entries in a linked queue. Actually it is not needed here at al

svn commit: r1176118 - /tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:54:37 2011 New Revision: 1176118 URL: http://svn.apache.org/viewvc?rev=1176118&view=rev Log: Add issue that was missed in changelog (r1172317). Add CVE number to DIGEST authentication issue. Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.x

svn commit: r1176128 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 23:23:20 2011 New Revision: 1176128 URL: http://svn.apache.org/viewvc?rev=1176128&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=11

svn commit: r1176132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 23:44:05 2011 New Revision: 1176132 URL: http://svn.apache.org/viewvc?rev=1176132&view=rev Log: Add revision numbers for issues that have been fixed in TC7: r1138132, r1175897 Remove ConcurrentHashMap tuning proposal (it is unlikely to have so many CPUs that it w

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #5 from Konstantin Kolinko 2011-09-27 00:30:44 UTC --- Please provide a WAR file (without Spring libraries - those can be downloaded), so that it can be tested. Thus I cannot test the app itself. Testing the views and reviewin

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 --- Comment #4 from Konstantin Kolinko 2011-09-27 00:49:36 UTC --- (In reply to comment #3) > I have just upgraded from 7.0.20 to 7.0.21 and I think this resolution has > affected a very simple error page that I have had in my web app sinc

DO NOT REPLY [Bug 51883] NullPointerException in StandardContextValve.invoke

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51883 --- Comment #3 from Konstantin Kolinko 2011-09-27 00:55:40 UTC --- It looks a lot like bug 51494 (NPE in StandardContextValve if request is being processed while webapp is being redeployed), but that should have been fixed in 7.0.19. Note

DO NOT REPLY [Bug 18500] Host aliases to match by regular expression

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=18500 --- Comment #10 from Konstantin Kolinko 2011-09-27 01:12:47 UTC --- (In reply to comment #9) > I just wouldn't watch to mix-and-match too many name-matching styles or things > are going to get seriously ridiculous (exact-match, then suffix

svn commit: r1176157 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/modeler/ManagedBean.java java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDigesterSource.java java/org/apach

2011-09-26 Thread kkolinko
Author: kkolinko Date: Tue Sep 27 01:21:08 2011 New Revision: 1176157 URL: http://svn.apache.org/viewvc?rev=1176157&view=rev Log: Merged revision 1174325 from tomcat/trunk: Fix a small number of Eclipse warnings. - Unused code - Unnecessary null checks Modified: tomcat/tc7.0.x/trunk/ (pro

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 Mike Slinn changed: What|Removed |Added Version|7.0.12 |7.0.21 --- Comment #15 from Mike Slin