Review request: LOG4J2-3393 JsonTemplateLayout performance improvements

2022-03-15 Thread Volkan Yazıcı
I will appreciate it if somebody can take a look at #797 . I plan to merge it next Monday.

Re: Order of property sources

2022-03-15 Thread Ralph Goers
I would not be in favor of this change. Providers have been designed since day one that highest wins and it is documented - https://logging.apache.org/log4j/2.x/manual/extending.html#LoggerContextFactory . The fa

Re: Order of property sources

2022-03-15 Thread Tim Perry
In that case, should log4j log a warning if more than one provider is included? Tim > On Mar 15, 2022, at 1:44 PM, Ralph Goers wrote: > > I would not be in favor of this change. Providers have been designed since > day one that highest wins and it is documented - > https://logging.apache.or

Re: Order of property sources

2022-03-15 Thread Ralph Goers
That is actually an interesting question. If you look at the logic, all the providers are loaded. They are then looped through and the first one that returns a LoggerFactory is used. I really consider this code unfinished. When I wrote it I considered supporting multiple logging implementations