Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/486
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/485
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/489
+1 LGTM, Dan. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user joeymcallister opened a pull request:
https://github.com/apache/geode-site/pull/2
GEODE-2554 Add htaccess file for docs redirect
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joeymcallister/geode-site feature/GEODE
Github user joeymcallister commented on the issue:
https://github.com/apache/geode-site/pull/2
@metatype Thanks for looking at the Travis issue.
I get what you're saying with the second RewriteRule, but my concern is
that it also would impact directories that shouldn
GitHub user joeymcallister opened a pull request:
https://github.com/apache/geode-site/pull/3
GEODE-2935: Add Events link to footer, events img to Community
This adds a text-only Events link to the website footer to
accommodate the Apache TLP Website Link Checker. It
also
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117119685
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -35,85 +35,67 @@ The Apache Lucene integration:
For more details, see
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117121920
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117122461
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117122540
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117122734
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117122942
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117123228
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/518#discussion_r117123398
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -135,4 +117,164 @@ gfsh> lucene search --regionName=/orders
-queryStri
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/542
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user joeymcallister commented on the issue:
https://github.com/apache/geode-site/pull/6
+1 Thanks, @upthewaterspout!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/550#discussion_r119217398
--- Diff: geode-docs/tools_modules/gfsh/command-pages/search.html.md.erb ---
@@ -62,12 +62,12 @@ search lucene --name=value --region=value
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/543#discussion_r119218480
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName
--region=/ord
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/543#discussion_r119232692
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName
--region=/ord
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/553
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/554
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/559#discussion_r120199524
--- Diff:
geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb ---
@@ -276,8 +276,83 @@ find the reason.
Description
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/559#discussion_r120200477
--- Diff:
geode-docs/managing/troubleshooting/system_failure_and_recovery.html.md.erb ---
@@ -276,8 +276,83 @@ find the reason.
Description
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/559
Added a couple of small notes for review, then +1. Looks great, Dave!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/583#discussion_r122320206
--- Diff: geode-docs/rest_apps/setup_config.html.md.erb ---
@@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR
files are
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/583#discussion_r122320074
--- Diff: geode-docs/rest_apps/setup_config.html.md.erb ---
@@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR
files are
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/583#discussion_r122319962
--- Diff: geode-docs/rest_apps/setup_config.html.md.erb ---
@@ -29,162 +31,233 @@ All Geode REST interface classes and required JAR
files are
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/581
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/637#discussion_r127525516
--- Diff: geode-docs/tools_modules/gfsh/command-pages/import.html.md.erb ---
@@ -40,16 +40,17 @@ Import user data from a file to a region
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/644#discussion_r128320777
--- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb ---
@@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/660
+1 with JinMei's changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/686
I think the helpers file needs a license. Otherwise, this LGTM. +1 with
license fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user joeymcallister commented on the pull request:
https://github.com/apache/geode/commit/319304e28fa33f685ccab51d7574fc8696cee50b#commitcomment-21113152
In geode-docs/getting_started/product_intro.html.md.erb:
In geode-docs/getting_started/product_intro.html.md.erb on line
Github user joeymcallister commented on the issue:
https://github.com/apache/geode-native/pull/49
+1 (after @echobravopapa's suggested change of "gfcpp.properties" to
"geode.properties," if that file name has changed)
---
If your project is set up for it, yo
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105233328
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/453
+1. Updated config works correctly. Scanned and spot-checked subnav links,
and found no issues. New redirect for archived 1.1 version looks correct.
---
If your project is set up for it, you
Github user joeymcallister commented on the issue:
https://github.com/apache/geode-native/pull/91
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/462
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user joeymcallister opened a pull request:
https://github.com/apache/geode/pull/334
Feature/geode 2031
This PR accomplishes a few things:
1. As outlined in the GEODE-2031 ticket, I've adjusted the flow so we can
now publish older versions of the docs in addition t
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/334#discussion_r95706396
--- Diff: geode-book/README.md ---
@@ -63,30 +63,19 @@ For Geode, a preconfigured **book** is provided in the
directory `{geode-project
Github user joeymcallister closed the pull request at:
https://github.com/apache/geode/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user joeymcallister reopened a pull request:
https://github.com/apache/geode/pull/334
Feature/geode 2031
This PR accomplishes a few things:
1. As outlined in the GEODE-2031 ticket, I've adjusted the flow so we can
now publish older versions of the docs in addition t
Github user joeymcallister closed the pull request at:
https://github.com/apache/geode/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode/pull/366#discussion_r98112556
--- Diff:
geode-docs/developing/data_serialization/jsonformatter_pdxinstances.html.md.erb
---
@@ -44,3 +44,14 @@ After executing a Geode query or
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/380
+1 - Looks great, Jared.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
45 matches
Mail list logo
