Re: [PROPOSAL] eliminate file count loophole in PR StressNewTest

2020-03-01 Thread Dan Smith
Won't this make it impossible to merge refactoring changes that touch a lot of tests? -Dan On Sat, Feb 29, 2020, 12:37 PM Robert Houghton wrote: > Yes, as it should > > On Sat, Feb 29, 2020, 12:25 Dan Smith wrote: > > > Doesn't the build fail when concourse times out? > >

Re: [PROPOSAL] eliminate file count loophole in PR StressNewTest

2020-03-01 Thread Owen Nichols
Impossible, no. Inconvenient, perhaps, but a small price to pay for being able to trust that green means green. With or without this proposed change, if anyone is having trouble getting their PR to pass StressNew, please bring it up on the dev list and we can discuss the appropriate solution on a

Re: [PROPOSAL] eliminate file count loophole in PR StressNewTest

2020-03-01 Thread Anthony Baker
What percentage of PR’s are currently subject to the 25 test file rule? How many would be subject to the concourse timeout? I’d like to understand the scope of the impact for this change. Anthony > On Mar 1, 2020, at 8:58 AM, Owen Nichols wrote: > > Impossible, no. Inconvenient, perhaps, bu

Re: [PROPOSAL] eliminate file count loophole in PR StressNewTest

2020-03-01 Thread Owen Nichols
We don’t tend to look too closely at successful PR checks to see whether they actually checked anything at all. One example I found is https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-pr/jobs/StressNewTestOpenJDK11/builds/5957