Odg: PRs review

Thank you @Bruce Schuchardt! 🙂 Šalje: Bruce Schuchardt Poslano: 10. prosinca 2019. 23:53 Prima: dev@geode.apache.org Predmet: Re: PRs review Mario, I've merged GEODE-6927. You can close the JIRA ticket. On 12/10/19 4:20 AM, Mario

Odg: Odg: Odg: Lucene upgrade

Hi Jason, This change fix IndexFormatTooNewException, but now we have org.apache.geode.cache.lucene.LuceneQueryException: Lucene Index is not available, currently indexing So this means that query doesn't wait until all indexes are created. In LuceneQueryFunction.java it is set to not wait for

Request GEODE-7510/GEODE-7538 be cherry-picked into release 1.11

Hello, GEODE-7538 was highlighted as blocking the 1.11 release. This has now been addressed and propose that this gets merged over to release 1.11. This issue solves a few things, most notably: GEODE-7510 shows inconsistency between secondaries and primaries. GEODE-7538 showed operations not co

Re: Request GEODE-7510/GEODE-7538 be cherry-picked into release 1.11

Can I get the SHA of the commit? Thanks, Mark > On Dec 11, 2019, at 11:02 AM, Jason Huynh wrote: > > Hello, > > GEODE-7538 was highlighted as blocking the 1.11 release. This has now been > addressed and propose that this gets merged over to release 1.11. > > This issue solves a few things, m

Re: Request GEODE-7510/GEODE-7538 be cherry-picked into release 1.11

I believe we'll have to cherry-pick 1448c83c2a910b2891b4c13f1b4cbed2920252de across. Unfortunately it went in as a merge (there was a hiccup on squash and merge where the try-again didn't do a squash merge :-(. On Wed, Dec 11, 2019 at 11:30 AM Mark Hanson wrote: > Can I get the SHA of the co

Re: Odg: Odg: Odg: Lucene upgrade

Hi Mario, Is the same test failing? If it's a different test, could you tell us which one? If it's a rolling upgrade test, then we might have to mark this as expected behavior and modify the tests to waitForFlush (wait until the queue is drained). As long as the test is able to roll all the serv

[DISCUSS] Adding a couple user APIs dealing with RegionFactory.

Hi All, There was a suggestion that since I am making a couple user visible API changes that I might want to ask the dev list. Basically I was migrating code from AttributesFactory to RegionFactory and hit a few snags along the way. Please see https://github.com/apache/geode/pull/4409

Request GEODE-7537 fix to be cherry-picked into release 1.11

Hello, GEODE-7537 was highlighted as blocking 1.11 release. This issue is being addressed now. I would like to have this fix to be merged into release 1.11. The commit sha is 3a3db82afdf0668e98ca49bcbdfa478e0ac94e10 Regards, Eric

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

I see a lot of PR comments on those PRs. What is the new API you added? -Dan On Wed, Dec 11, 2019 at 2:57 PM Mark Hanson wrote: > Hi All, > > There was a suggestion that since I am making a couple user visible API > changes that I might want to ask the dev list. > > Basically I was migrating co

Re: Request GEODE-7537 fix to be cherry-picked into release 1.11

+1 for bringing this to release/1.11.0 > On Dec 11, 2019, at 2:57 PM, Eric Shu wrote: > > Hello, > > GEODE-7537 was highlighted as blocking 1.11 release. This issue is being > addressed now. > > I would like to have this fix to be merged into release 1.11. > > The commit sha is 3a3db82afdf066

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

In Cache.java + RegionFactory createRegionFactory(RegionFactory regionFactory); In RegionFactory.java + public RegionFactory(InternalCache cache, RegionFactory regionFactory) and + public RegionFactory(RegionFactory regionFactory) Lastly in GemfireCacheImpl.java + public RegionFactory cre

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

Don't expose "InternalCache" on RegionFactory. You probably want it to be "Cache". On Wed, Dec 11, 2019 at 3:35 PM Mark Hanson wrote: > > In Cache.java > > + RegionFactory createRegionFactory(RegionFactory > regionFactory); > > In RegionFactory.java > + public RegionFactory(InternalCache cach

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

Mark, Can you share how the API changes will help the user? Thanks, Anthony > On Dec 11, 2019, at 2:57 PM, Mark Hanson wrote: > > Hi All, > > There was a suggestion that since I am making a couple user visible API > changes that I might want to ask the dev list. > > Basically I was migra

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

In discussion with Dan, I made a few realizations, so I have new API coming. Basically dropping the use of InternalCache below. Please hold off on reviewing. Thanks, Mark > On Dec 11, 2019, at 3:34 PM, Mark Hanson wrote: > > > In Cache.java > > + RegionFactory createRegionFactory(RegionF

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

Basically the point is to allow a use to copy a RegionFactory because under certain circumstances it is necessary. I found that when migrating from AttributesFactory. Thanks, Mark > On Dec 11, 2019, at 3:48 PM, Anthony Baker wrote: > > Mark, > > Can you share how the API changes will help th

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

Yup, fixing that. > On Dec 11, 2019, at 3:38 PM, Darrel Schneider wrote: > > Don't expose "InternalCache" on RegionFactory. You probably want it to be > "Cache". > > On Wed, Dec 11, 2019 at 3:35 PM Mark Hanson wrote: > >> >> In Cache.java >> >> + RegionFactory createRegionFactory(RegionFa

Re: [VOTE] Release candidate for Apache Geode version 1.11.0.RC3.

Hi All, It does not look like we have an assignee for GEODE-7531. Any takers? Thanks, Mark > On Dec 4, 2019, at 2:35 PM, Mark Hanson wrote: > > So, outstanding issues that I see right now are > > GEODE-7531 > GEODE-7537 > GEODE-7538 > > Thanks, > Mark > >> On Dec 4, 2019, at 2:11 PM, John

Re: [DISCUSS] Adding a couple user APIs dealing with RegionFactory.

I think at this point I'd be looking at the new V2 Management API's for Regions. I think any new "public" effort that we'd be adding to the product should be done through the Management API's for Regions, rather than exposing new public API's that in reality should not be made "public". --Ud