Thanks for your reply, I'll fix them next version.
On 2023/9/1 19:54, David Marchand wrote:
On Fri, Sep 1, 2023 at 11:35 AM wrote:
From: Renyong Wan
Adding minimum PMD code, doc and build infrastructure for sssnic.
Signed-off-by: Steven Song
Signed-off-by: Renyong Wan
---
v2:
*
/9/6 23:09, Stephen Hemminger wrote:
On Tue, 29 Aug 2023 15:58:05 +0800w
wrote:
From: Renyong Wan
Work queue is used to maintain hardware queue information by
driver, it is usually used in control queue, rx queue
and tx queue.
Signed-off-by: Steven Song
Signed-off-by: Renyong Wan
Looks
ect/dpdk/list/?series=29409>
Thanks.
--
Regards,
Renyong Wan
Hello Stephen,
SSSNIC PMD does not support primary/secondary process right now, it can
only run in primary process. We are going to support multiprocessnext
release.
Thanks.
On 2023/9/18 10:37, Stephen Hemminger wrote:
On Mon, 4 Sep 2023 12:56:26 +0800
wrote:
From: Renyong Wan
The
structure is on the same NUMA node as PCI device.
--
Regards,
Renyong Wan
c int
+sssnic_msg_buf_alloc(struct sssnic_msg *msg, size_t size)
+{
+ msg->data_buf = rte_zmalloc("sssnic_msg_data", size, 1);
Putting message buffer on same NUMA node as device might help
performance on NUMA architecture.
--
Regards,
Renyong Wan
esult back to DMA address of sending result */
+ uint32_t wb : 1;
Minor nit: the comment above has odd word spacing.
--
Regards,
Renyong Wan
do it for you.
--
Regards,
Renyong Wan
;
For small sizes, regular memcpy is going to be the same or faster than
rte_memcpy
--
Regards,
Renyong Wan
here.
--
Regards,
Renyong Wan
Hello Stephen,
I'll fix it in next version of patch.
Thanks.
On 2023/9/19 11:19, Stephen Hemminger wrote:
On Mon, 4 Sep 2023 12:56:26 +0800
wrote:
From: Renyong Wan
The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support
for 3SNIC 9x0 serials family of Ethernet ada
Hello Stephen,
I'll fix it in next version of patch.
Thanks.
On 2023/9/19 11:21, Stephen Hemminger wrote:
On Mon, 4 Sep 2023 12:56:26 +0800
wrote:
From: Renyong Wan
The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support
for 3SNIC 9x0 serials family of Ethernet ada
Hello Stephen,
I'll fix it in next version of patch.
Thanks.
On 2023/9/19 11:23, Stephen Hemminger wrote:
On Mon, 4 Sep 2023 12:56:26 +0800
wrote:
From: Renyong Wan
The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support
for 3SNIC 9x0 serials family of Ethernet ada
On 2025/2/5 22:43, Thomas Monjalon wrote:
> 05/02/2025 15:37, Renyong Wan:
>> On 2025/2/5 19:44, Thomas Monjalon wrote:
>>> 28/01/2025 15:46, Renyong Wan:
>>>> XSC PMD is designed to support both VFIO and private kernel drivers.
>>> What's the benefit
On 2025/2/5 23:45, Thomas Monjalon wrote:
> 05/02/2025 16:37, Renyong Wan:
>> On 2025/2/5 22:43, Thomas Monjalon wrote:
>>> 05/02/2025 15:37, Renyong Wan:
>>>> On 2025/2/5 19:44, Thomas Monjalon wrote:
>>>>> 28/01/2025 15:46, Renyong Wan:
>>>&g
side note, this means that this driver should probably call
> rte_pci_unmap_device() in its release path, though I see none)
Hello David,
You're absolutely right, thank you very much for the notice, it does
seem like an oversight that rte_pci_unmap_device() is missing in the
driver's release path, I will fix it in the next submission.
--
Best regards,
Renyong Wan
On 2025/2/5 19:44, Thomas Monjalon wrote:
> 28/01/2025 15:46, Renyong Wan:
>> XSC PMD is designed to support both VFIO and private kernel drivers.
> What's the benefit of private kernel drivers?
> Why are they private?
>
>
>
Hello Thomas,
Thanks for your review.
I
XSC PMD is designed to support both VFIO and private kernel drivers.
This commit add xsc dev ops to support VFIO driver.
Signed-off-by: Na Na
Signed-off-by: Renyong Wan
---
v7:
* Delete the packed attributes of sub structures and unions.
v6:
* Replace __rte_packed with __rte_packed_begin and
XSC mailbox is a mechanism used for interaction between PMD and firmware.
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
v7:
* Remove the cast of xdev->dev_priv.
* Remove the cast of malloc return value.
---
drivers/net/xsc/meson.build | 1 +
drivers/net/xsc/xsc_cm
PCT is the abbreviation of Packet classifier table, which is built
in NP to define behavior of various packets.
Signed-off-by: Renyong Wan
---
v6:
* Replace __rte_packed with __rte_packed_begin and __rte_packed_end.
---
drivers/net/xsc/meson.build | 1 +
drivers/net/xsc/xsc_defs.h | 29
For the design of the xsc PMD, each ethdev corresponds to a representor.
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_defs.h | 11 +++
drivers/net/xsc/xsc_dev.c| 95
drivers/net/xsc/xsc_dev.h| 3 +
drivers/net/xsc/xsc_ethdev.c | 170
Add xsc PMD framework, doc and build infrastructure, supporting
PCI probe.
Signed-off-by: Renyong Wan
---
v7:
* Change the name of Wanrenyong to Renyong Wan.
v6:
* Delete the included header file net/if.h.
* Rebase the main branch to merge release notes.
---
.mailmap
XSC device is a hardware abstract level device serving as a handle
to interact with hardware.
Signed-off-by: Renyong Wan
---
v7:
* Define the size of xdev->name to PCI_PRI_STR_SIZE.
v5:
* Fix coding style issue with misspelling
* Rearrange the elements in struct xsc_hwinfo to reduce ho
Implement xsc ethdev configure and RSS hash functions.
Signed-off-by: Renyong Wan
---
v6:
* Use memcpy instead of rte_memcpy.
v5:
* Remove some unnecessary parameter checks.
---
doc/guides/nics/features/xsc.ini | 3 ++
drivers/net/xsc/xsc_defs.h | 15 ++
drivers/net/xsc/xsc_dev.c
Implement xsc ethdev Rx and Tx queue setup functions.
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
v7:
* Delete the packed attributes of sub structures and unions.
v6:
* Replace __rte_packed with __rte_packed_begin and __rte_packed_end.
---
drivers/net/xsc/xsc_defs.h | 4
Implement xsc ethdev start function.
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
v5:
* Remove unnecessary call of rte_wmb.
---
drivers/net/xsc/meson.build | 2 +
drivers/net/xsc/xsc_dev.c| 33
drivers/net/xsc/xsc_dev.h| 8 +
drivers/net/xsc/xsc_ethdev.c | 172
Implement xsc ethdev basic statatics ops.
Signed-off-by: Renyong Wan
---
v6:
* Remove unnecessary paren.
* Add the feature of stats per queue in xsc.ini.
---
doc/guides/nics/features/xsc.ini | 2 +
drivers/net/xsc/xsc_ethdev.c | 75
2 files changed, 77
Implement xsc ethdev Rx burst function.
Signed-off-by: Xiaoxiong Zhang
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_ethdev.c | 3 +
drivers/net/xsc/xsc_rx.c | 174 +++
drivers/net/xsc/xsc_rx.h | 1 +
drivers/net/xsc/xsc_rxtx.h | 13 +++
4
Implement xsc ethdev close and stop functions.
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_dev.c| 12
drivers/net/xsc/xsc_dev.h| 2 +
drivers/net/xsc/xsc_ethdev.c | 108 +++
drivers/net/xsc/xsc_rx.c | 47 +++
drivers/net
Implement xsc ethdev information get ops.
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_ethdev.c | 61
1 file changed, 61 insertions(+)
diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c
index 63c64ce547..5d548adb2d 100644
--- a
Implement xsc ethdev Tx burst function.
Signed-off-by: Dongwei Xu
Signed-off-by: Renyong Wan
---
doc/guides/nics/features/xsc.ini | 4 +
drivers/net/xsc/xsc_ethdev.c | 1 +
drivers/net/xsc/xsc_tx.c | 228 +++
drivers/net/xsc/xsc_tx.h | 1
Implement xsc ethdev link and MTU ops.
Signed-off-by: Renyong Wan
---
doc/guides/nics/features/xsc.ini | 1 +
drivers/net/xsc/xsc_dev.c| 33 ++
drivers/net/xsc/xsc_dev.h| 4 +++
drivers/net/xsc/xsc_ethdev.c | 60
4 files
unions.
* Remove the cast of xdev->dev_priv.
* Remove the cast of malloc return value.
* Define the size of xdev->name to PCI_PRI_STR_SIZE.
* Change the name of Wanrenyong to Renyong Wan
v6:
* Remove unnecessary paren.
* Add the feature of stats per queue in xsc.ini.
* Use memcpy inst
Optimized the code of release path to prevent potential resource leaks.
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_dev.c| 5 -
drivers/net/xsc/xsc_ethdev.c | 12 ++--
drivers/net/xsc/xsc_np.c | 1 +
drivers/net/xsc/xsc_vfio.c | 1 +
4
Fixed the Coverity-detected issue that resource leaks.
Coverity issue: 457741
Fixes: 3d57851720d4 ("net/xsc: check null pointer dereference")
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_rx.c | 14 ++
1 file changed, 10 insertions(+), 4
This patchset focuses on optimizing the code to avoid resource leaks.
Renyong Wan (2):
net/xsc: fix resource leaks
net/xsc: optimize release path
drivers/net/xsc/xsc_dev.c| 5 -
drivers/net/xsc/xsc_ethdev.c | 12 ++--
drivers/net/xsc/xsc_np.c | 1 +
drivers/net/xsc
On 2025/2/15 7:27, Stephen Hemminger wrote:
> On Tue, 28 Jan 2025 22:47:22 +0800
> "Renyong Wan" wrote:
>
>> This xsc PMD (**librte_net_xsc**) provides poll mode driver for
>> Yunsilicon metaScale serials NICs.
>>
>> Features:
>> -
&g
Address incorrect expression (USELESS_CALL) reported by Coverity Scan.
Coverity issue: 456590
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_np.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/xsc/xsc_np.c b/drivers/net/xsc/xsc_np.c
index d4eb833bf6..f032a0dbc2 100644
--- a
Address the integer overflow issue reported by Coverity Scan.
Coverity issue: 456589
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xsc/xsc_tx.c b/drivers/net/xsc/xsc_tx.c
index 406fa95381..1d31e84d69
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v1001/
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_ethdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc
These warnings reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v576/
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_dev.c | 2 +-
drivers/net/xsc/xsc_rx.c| 4 ++--
drivers/net/xsc/xsc_tx.c| 4 ++--
drivers/net/xsc
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v1048/
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_np.c | 4
drivers/net/xsc/xsc_tx.c | 1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/net/xsc/xsc_np.c
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v547/
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_ethdev.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v656
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_rx.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/xsc/xsc_rx.c b/drivers/net/xsc/xsc_rx.c
index
This patch series resolves several issues reported by PVS and Coverity Scan,
which were earlier forwarded to us by Stephen Hemminger.
---
Renyong Wan (12):
net/xsc: avoid integer overflow
net/xsc: remove useless call
net/xsc: address incorrect format warnings
net/xsc: remove always-true
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v560/
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/xsc/xsc_rx.c b/drivers/net/xsc/xsc_rx.c
index
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v526/
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xsc/xsc_ethdev.c b/drivers/net/xsc/xsc_ethdev.c
index
This issue reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v595/
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_np.c | 2 +-
drivers/net/xsc/xsc_rx.c | 2 +-
drivers/net/xsc/xsc_vfio.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v1027/
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_np.c | 10 +++--
drivers/net/xsc/xsc_rx.c | 12 ++---
drivers/net/xsc/xsc_vfio.c | 91 +++---
3 files
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v522/
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_ethdev.c | 15 +--
drivers/net/xsc/xsc_rx.c | 5 +
2 files changed, 18 insertions(+), 2 deletions
This patch series resolves two warnings reported by PVS studio.
---
Renyong Wan (2):
net/xsc: check possible null pointer dereference
net/xsc: suppress assign the same value warning
drivers/net/xsc/xsc_rx.c| 6 +-
drivers/net/xsc/xsc_vfio_mbox.c | 2 +-
2 files changed, 6
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v522/
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net/xsc/xsc_rx.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/xsc/xsc_rx.c b/drivers/net
This issue was reported by PVS studio, described as:
https://pvs-studio.com/en/docs/warnings/v1048/
This warning is harmless since both structs have the same size.
The tool is just being annoying, so we should suppress it.
Signed-off-by: Rong Qian
Signed-off-by: Renyong Wan
---
drivers/net
Hello Stephen,
Thank you for your review. I appreciate the detailed analysis and the
suggestions for improvements.
Please find my feedback bellow.
On 2025/2/23 1:30, Stephen Hemminger wrote:
> On Sat, 22 Feb 2025 11:57:59 +0800
> "Renyong Wan" wrote:
>
>> This patc
54 matches
Mail list logo
