[PATCH dpdk v3 0/2] Fix race in ethdev telemetry

2024-10-14 Thread Robin Jarry
Following a discussion we had during the summit, here is one series to fix a race between an application thread and the telemetry thread handling requests on ethdev ports. The problem may be generic to other device classes providing telemetry callbacks, but for now, this series goes with a simple

Re: [PATCH dpdk v3 2/2] ethdev: fix potential race in telemetry endpoints

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 21:32:37 +0200 Robin Jarry wrote: > While invoking telemetry commands (which may happen at any time, out of > control of the application), an application thread may concurrently > add/remove ports. The telemetry callbacks may then access partially > initialized/uninitialised e

Re: [PATCH v6 2/3] doc: update graph layout and node anatomy images

2024-10-14 Thread Robin Jarry
, Oct 14, 2024 at 18:10: From: Pavan Nikhilesh update the graph memory layout and node anatomy images to reflect the xstats memory region. Signed-off-by: Pavan Nikhilesh --- Reviewed-by: Robin Jarry

[PATCH dpdk v3 1/2] telemetry: add api to register command with private argument

2024-10-14 Thread Robin Jarry
Add a new rte_telemetry_register_cmd_arg public function to register a telemetry endpoint with a callback that takes an additional private argument. This will be used in the next commit to protect ethdev endpoints with a lock. Update perform_command() to take a struct callback object copied from

Re: [PATCH v4 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue

2024-10-14 Thread Stephen Hemminger
On Fri, 4 Oct 2024 23:22:52 +0530 Sriharsha Basavapatna wrote: > From: Shahaji Bhosle > > FW tries to update the HWRM request data in the > delete case to update the mode bit and also > update invalid profile id. This update only > happens when the data is send over DMA. HWRM > requests are re

[PATCH dpdk v3 2/2] ethdev: fix potential race in telemetry endpoints

2024-10-14 Thread Robin Jarry
While invoking telemetry commands (which may happen at any time, out of control of the application), an application thread may concurrently add/remove ports. The telemetry callbacks may then access partially initialized/uninitialised ethdev data. Reuse the ethdev lock that protects port allocation

Re: [PATCH v5 4/5] test/graph_feature_arc: add functional tests

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 20:03:57 +0530 Nitin Saxena wrote: > Added functional unit test case for verifying feature arc control plane > and fast path APIs > > How to run: > $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test > > Signed-off-by: Nitin Saxena With current upstream kernel checkpatch

[PATCH v1 12/18] net/r8169: implement Tx path

2024-10-14 Thread Howard Wang
Add implementation for TX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 7 + drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 687 ++- 4 files changed, 695 insertions

[PATCH v1 13/18] net/r8169: implement device statistics

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 16 +++ drivers/net/r8169/r8169_ethdev.c | 49 ++- drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_hw.c | 80 drivers/net/r8169/r8169_hw.h | 6 +++ 5 f

[PATCH v1 09/18] net/r8169: add support for hw initialization

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 43 +++ drivers/net/r8169/r8169_dash.c | 89 + drivers/net/r8169/r8169_dash.h | 35 ++ drivers/net/r8169/r8169_ethdev.c | 47 ++- drivers/net/r8169/r8169_ethdev.h | 30 +- driv

[PATCH v1 11/18] net/r8169: implement Rx path

2024-10-14 Thread Howard Wang
Add implementation for RX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 27 ++ drivers/net/r8169/r8169_ethdev.c | 76 ++- drivers/net/r8169/r8169_ethdev.h | 18 + drivers/net/r8169/r8169_rxtx.c | 787 ++- 4 files changed, 905 inserti

[PATCH v1 10/18] net/r8169: add link status and interrupt management

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 5 +- drivers/net/r8169/r8169_ethdev.c | 279 ++- drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_hw.c | 8 +- drivers/net/r8169/r8169_hw.h | 3 + drivers/net/r8169/r8169_

[PATCH v1 08/18] net/r8169: add support for phy configuration

2024-10-14 Thread Howard Wang
This patch contains phy config, ephy config and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 10 + drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_phy.c| 445 +++ drivers/net/r8169/r8169_phy.h| 100 +++ 4 file

[PATCH v1 14/18] net/r8169: implement promisc and allmulti modes

2024-10-14 Thread Howard Wang
Add support for promiscuous/allmulticast modes configuration. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 68 1 file changed, 68 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index cf9ea4dca4

[PATCH v1 15/18] net/r8169: impelment MTU configuration

2024-10-14 Thread Howard Wang
Add support for updating MTU value. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 3e6bc570d6..70c3661691 100644 --- a/dri

[PATCH v1 05/18] net/r8169: add support for hw config

2024-10-14 Thread Howard Wang
Implement the rtl_hw_config function to configure the hardware. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 125 ++ drivers/net/r8169/r8169_ethdev.c | 2 + drivers/net/r8169/r8169_ethdev.h | 15 +- drivers/net/r8169/r8169_hw.

[PATCH v1 03/18] net/r8169: add hardware registers access routines

2024-10-14 Thread Howard Wang
Add implementation for hardware registers access routines. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 389 +++ drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_hw.c | 94 d

[PATCH v1 06/18] net/r8169: add phy registers access routines

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.h | 1 + drivers/net/r8169/r8169_phy.c| 219 +++ drivers/net/r8169/r8169_phy.h| 18 +++ 3 files changed, 238 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.h b/drivers/net/r8169/r8169_

[PATCH v1 01/18] net/r8169: add PMD driver skeleton

2024-10-14 Thread Howard Wang
Meson build infrastructure, r8169_ethdev minimal skeleton, header with Realtek NIC device and vendor IDs. Signed-off-by: Howard Wang --- MAINTAINERS | 7 ++ drivers/net/meson.build | 1 + drivers/net/r8169/meson.build| 7 ++ drivers/net/r8169/r8169_base.h

[PATCH v1 00/18] net/r8169: add r8169 pmd to dpdk

2024-10-14 Thread Howard Wang
R8169 pmd supports Realtek 2.5G and 5G ethernet nics. Howard Wang (18): net/r8169: add PMD driver skeleton net/r8169: add logging structure net/r8169: add hardware registers access routines net/r8169: implement core logic for Tx/Rx net/r8169: add support for hw config net/r8169: add ph

[PATCH v1 04/18] net/r8169: implement core logic for Tx/Rx

2024-10-14 Thread Howard Wang
Add RX/TX function prototypes for further datapath development. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.c | 17 ++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_rxtx.c | 57 ++

[PATCH v1 02/18] net/r8169: add logging structure

2024-10-14 Thread Howard Wang
Implement logging macros for debug purposes. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 40 drivers/net/r8169/r8169_logs.h | 53 2 files changed, 93 insertions(+) create mode 100644 drivers/net/r8169/r8169_logs.h

[PATCH v1 17/18] net/r8169: add driver_start and driver_stop

2024-10-14 Thread Howard Wang
rtl8125ap and rtl8125bp need driver start and stop whether dash is enabled or not. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8126a_mcu.h | 1 + drivers/net/r8169/r8169_base.h| 6 +- drivers/net/r8169/r8169_dash.c| 149 +- drivers/net/r81

[PATCH v1 18/18] doc/guides/nics: add documents for r8169 pmd

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- MAINTAINERS| 2 ++ doc/guides/nics/features/r8169.ini | 32 ++ doc/guides/nics/r8169.rst | 17 3 files changed, 51 insertions(+) create mode 100644 doc/guides/nics/features/r8169.ini cr

[PATCH v1 16/18] net/r8169: add support for getting fw version

2024-10-14 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 70c3661691..dd2c7dda24 100644 --- a/drivers/net/r8169/r8169_ethdev.c +++ b/drivers/ne

Re: [PATCH v6] devtools: add .clang-format file

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 22:15:45 + Abdullah Ömer Yamaç wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style a

Re: [PATCH v4 0/5] power: refactor power management library

2024-10-14 Thread Stephen Hemminger
On Tue, 15 Oct 2024 02:49:53 + Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers

[PATCH v5 0/9] net/zxdh: introduce net zxdh driver

2024-10-14 Thread Junlong Wang
V5: - split driver into multiple patches,part of the zxdh driver, later provide dev start/stop,queue_setup,mac,vlan,rss ,etc. - fix errors reported by scripts. - move the product link in zxdh.rst. - fix meson check use RTE_ARCH_X86_64/RTE_ARCH_ARM64. - modify other comments according

[PATCH v5 3/9] net/zxdh: add zxdh device pci init implementation

2024-10-14 Thread Junlong Wang
Add device pci init implementation, to obtain PCI capability and read configuration, etc Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 5 +- drivers/net/zxdh/zxdh_ethdev.c | 43 + drivers/net/zxdh/zxdh_ethdev.h | 20 ++- drivers/net/zxdh/zxdh_pci.c| 290 +++

[PATCH v5 5/9] net/zxdh: add msg chan enable implementation

2024-10-14 Thread Junlong Wang
Add msg chan enable implementation to support send msg to get infos. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 + drivers/net/zxdh/zxdh_ethdev.h | 12 + drivers/net/zxdh/zxdh_msg.c| 655 - drivers/net/zxdh/zxdh_msg.h| 127 ++

[PATCH v5 4/9] net/zxdh: add msg chan and msg hwlock init

2024-10-14 Thread Junlong Wang
Add msg channel and hwlock init implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 15 +++ drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_msg.c| 161 + drivers/net/zxdh/zxdh_

[PATCH v5 7/9] net/zxdh: add configure zxdh intr implementation

2024-10-14 Thread Junlong Wang
configure zxdh intr include risc,dtb. and release intr. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 302 - drivers/net/zxdh/zxdh_ethdev.h | 8 + drivers/net/zxdh/zxdh_msg.c| 187 drivers/net/zxdh/zxdh_msg.h| 11

[PATCH v5 6/9] net/zxdh: add zxdh get device backend infos

2024-10-14 Thread Junlong Wang
Add zxdh get device backend infos, use msg chan to send msg get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_common.c | 249 + drivers/net/zxdh/zxdh_common.h | 30 drivers/net/zxdh/zxdh_ethdev.c | 35 +

[PATCH v5 1/9] net/zxdh: add zxdh ethdev pmd driver

2024-10-14 Thread Junlong Wang
Add basic zxdh ethdev init and register PCI probe functions Update doc files Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 9 +++ doc/guides/nics/index.rst | 1 + doc/guides/nics/zxdh.rst | 30 ++ drivers/net/meson.build | 1 + drivers/

[PATCH v5 2/9] net/zxdh: add logging implementation

2024-10-14 Thread Junlong Wang
Adds zxdh logging implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 15 +-- drivers/net/zxdh/zxdh_logs.h | 35 ++ 2 files changed, 48 insertions(+), 2 deletions(-) create mode 100644 drivers/net/zxdh/zxdh_logs.h diff

Re: [PATCH v2 1/6] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 09:56, Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Wednesday, 18 September 2024 12.12 On Thu, Sep 12, 2024 at 8:52 PM Jerin Jacob wrote: On Thu, Sep 12, 2024 at 7:11 PM Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sen

[PATCH v5 8/9] net/zxdh: add zxdh dev infos get ops

2024-10-14 Thread Junlong Wang
Add support for zxdh infos get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 62 +- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c index 4f6711c9af..e0f2c1985b 10064

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 10:17, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Monday, 14 October 2024 09.44 +struct lcore_var_buffer { + char data[RTE_MAX_LCORE_VAR * RTE_MAX_LCORE]; + struct lcore_var_buffer *prev; +}; In relation to Jerin's requ

Re: [PATCH v11 7/7] eal: keep per-lcore power intrinsics state in lcore variable

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 18:30, Stephen Hemminger wrote: On Mon, 14 Oct 2024 09:43:48 +0200 Mattias Rönnblom wrote: Keep per-lcore power intrinsics state in a lcore variable to reduce cache working set size and avoid any CPU next-line-prefetching causing false sharing. Signed-off-by: Mattias Rönnblom A

Re: [PATCH v6 3/3] node: add xstats for ip4 nodes

2024-10-14 Thread Robin Jarry
, Oct 14, 2024 at 18:10: From: Pavan Nikhilesh Add xstat counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure xstat counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K --- Reviewed-by: Robin Jarry

[DPDK/cryptodev Bug 1565] Lots of warnings from Clang Asan build in Openssl PMD

2024-10-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1565 Bug ID: 1565 Summary: Lots of warnings from Clang Asan build in Openssl PMD Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: criti

[PATCH v4 1/5] power: refactor core power management library

2024-10-14 Thread Sivaprasad Tummala
This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories within 'drivers/power/core/*'. The adjustment of m

[PATCH v4 2/5] power: refactor uncore power management library

2024-10-14 Thread Sivaprasad Tummala
This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. This

[PATCH v4 0/5] power: refactor power management library

2024-10-14 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organiza

[PATCH v4 4/5] power/amd_uncore: uncore support for AMD EPYC processors

2024-10-14 Thread Sivaprasad Tummala
This patch introduces driver support for power management of uncore components in AMD EPYC processors. v2: - fixed typo in comments section. - added fabric frequency get support for legacy platforms. Signed-off-by: Sivaprasad Tummala --- drivers/power/amd_uncore/amd_uncore.c | 329 +++

[PATCH v4 0/5] power: refactor power management library

2024-10-14 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organiza

[PATCH v4 3/5] test/power: removed function pointer validations

2024-10-14 Thread Sivaprasad Tummala
After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Siv

[PATCH v4 5/5] maintainers: update for drivers/power

2024-10-14 Thread Sivaprasad Tummala
Update maintainers for drivers/power/*. Signed-off-by: Sivaprasad Tummala --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6814991735..9f14e8f8d6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1744,6 +1744,7 @@ M: Anatoly Burakov M: David Hunt

Re: [v6 08/15] dma/dpaa: refactor driver

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 15:06:32 +0530 Gagandeep Singh wrote: > @@ -551,7 +485,7 @@ fsl_qdma_reg_init(struct fsl_qdma_engine *fsl_qdma) > > /* Initialize the status queue mode. */ > reg = FSL_QDMA_BSQMR_EN; > - val = ilog2(fsl_qdma->status[j]->n_cq) - 6; > +

Re: [PATCH v6 1/3] graph: add support for node specific xstats

2024-10-14 Thread Jerin Jacob
On Mon, Oct 14, 2024 at 9:41 PM wrote: > > From: Pavan Nikhilesh > > Add ability for Nodes to advertise xstat counters > during registration and increment them in fastpath. > Add support for retrieving/printing stats for node > specific xstats using rte_graph_cluster_stats_get(). > Add `rte_node_

[PATCH v3 2/2] dts: port over unified packet suite

2024-10-14 Thread Dean Marx
Port over unified packet testing suite from old DTS. This suite tests the ability of the PMD to recognize valid or invalid packet flags. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_uni_pkt.py | 229

[PATCH v3 0/2] dts: port over unified packet type suite

2024-10-14 Thread Dean Marx
Port over unified packet type flag testing suite from old DTS. According to DPDK documentation, each Poll Mode Driver should reserve 32 bits of packet headers for unified packet type flags. These flags serve as an identifier for user applications, and are divided into subcategories: L2, L3, L4, tu

[PATCH v3 1/2] dts: add VXLAN port method to testpmd shell

2024-10-14 Thread Dean Marx
Add rx_vxlan_port add/rm method to testpmd shell for adding or removing a vxlan id to the specified port filter list. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/remote_session/testpmd_shell.py | 21 +++ 1 file changed, 21 insertions(+) diff --git a/d

Re: [v3 43/43] net/dpaa2: dpdmux single flow/multiple rules support

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:31:26 +0530 vanshika.shu...@nxp.com wrote: > From: Jun Yang > > Support multiple extractions as well as hardware descriptions > instead of hard code. > > Signed-off-by: Jun Yang > --- > drivers/net/dpaa2/dpaa2_ethdev.h | 1 + > drivers/net/dpaa2/dpaa2_flow.c

Re: [v3 14/43] bus/fslmc: enhance MC VFIO multiprocess support

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:30:57 +0530 vanshika.shu...@nxp.com wrote: > +#ifndef RTE_LIBRTE_DPAA2_USE_PHYS_IOVA > + if (vaddr != iovaddr) { > + DPAA2_BUS_WARN("vaddr(0x%lx) != iovaddr(0x%lx)", > + vaddr, iovaddr); > + } > #endif Checkpatch complain shere. Warn

Re: [v3 13/43] bus/fslmc: get MC VFIO group FD directly

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:30:56 +0530 vanshika.shu...@nxp.com wrote: > +static int > +fslmc_vfio_open_group_fd(int iommu_group_num) > +{ > + int vfio_group_fd; > + char filename[PATH_MAX]; > + struct rte_mp_msg mp_req, *mp_rep; > + struct rte_mp_reply mp_reply = {0}; > + struct ti

Re: [v3 16/43] bus/fslmc: dynamic IOVA mode configuration

2024-10-14 Thread Stephen Hemminger
On Mon, 14 Oct 2024 17:30:59 +0530 vanshika.shu...@nxp.com wrote: > iff --git a/drivers/bus/fslmc/fslmc_vfio.h b/drivers/bus/fslmc/fslmc_vfio.h > index 1695b6c078..408b35680d 100644 > --- a/drivers/bus/fslmc/fslmc_vfio.h > +++ b/drivers/bus/fslmc/fslmc_vfio.h > @@ -11,6 +11,10 @@ > #include > #

[PATCH v1 1/2] baseband/acc: FFT support in VRB2 PRQ device

2024-10-14 Thread Nicolas Chautru
Supporting recent change in the device to extend FFT capability processing in latest stepping. Also including cosmetic change to VRB2 register definition. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 2 +- drivers/baseband/acc/rte_vrb_pmd.c | 30

[PATCH v1 2/2] baseband/acc: saturate input to 6 bits for VRB decoder

2024-10-14 Thread Nicolas Chautru
Making the decoder more robust by forcing a default 6 bits LLR saturation to LDPC Decoder input. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c i

[PATCH v1 0/2] baseband/acc: vrb2 FFT support

2024-10-14 Thread Nicolas Chautru
Hi, Additional and final series for the VRB2 PMD. Now supporting latest FFT processing (available on final stepping of the device ) and generic improvement to decoder configuration. Thanks Nic Nicolas Chautru (2): baseband/acc: FFT support in VRB2 PRQ device baseband/acc: saturate input to 6

[PATCH v2] net/mlx5: fix potential memory leak in meter

2024-10-14 Thread Shun Hao
When meter not enabled, avoid allocate memory for meter profile table, which will not be freed in close process when meter not enabled Fixes: a295c69a8b24 ("net/mlx5: optimize meter profile lookup") Cc: sta...@dpdk.org Signed-off-by: Shun Hao Acked-by: Bing Zhao --- drivers/net/mlx5/linux/mlx5

[PATCH v7 1/3] graph: add support for node specific xstats

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add ability for Nodes to advertise xstat counters during registration and increment them in fastpath. Add support for retrieving/printing stats for node specific xstats using rte_graph_cluster_stats_get(). Add `rte_node_xstat_increment` API to increment node specific xstat c

[PATCH v7 3/3] node: add xstats for ip4 nodes

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Add xstat counters for ip4 LPM lookup failures in ip4_lookup node. Add reassembly failure xstat counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh Acked-by: Kiran Kumar K Reviewed-by: Robin Jarry --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lo

[PATCH v7 0/3] Introduce node-specific xstats in graph library

2024-10-14 Thread pbhagavatula
From: Pavan Nikhilesh Introduce the ability for nodes to advertise xstats counters during registration and increment them during the node process function in the graph library. This enhancement allows for better stats tracking and debugging capabilities within the graph framework. The number of

[PATCH v6] devtools: add .clang-format file

2024-10-14 Thread Abdullah Ömer Yamaç
clang-format is a tool to format C/C++/Objective-C code. It can be used to reformat code to match a given coding style, or to ensure that code adheres to a specific coding style. It helps to maintain a consistent coding style across the DPDK codebase. .clang-format file overrides the default style

[PATCH v6] devtools: add .clang-format file

2024-10-14 Thread Abdullah Ömer Yamaç
clang-format is a tool to format C/C++/Objective-C code. It can be used to reformat code to match a given coding style, or to ensure that code adheres to a specific coding style. It helps to maintain a consistent coding style across the DPDK codebase. .clang-format file overrides the default style

[PATCH v3] hash: separate param checks in hash create func

2024-10-14 Thread Niall Meade
Separated name, entries and key_len parameter checks in rte_hash_create(). Also made the error messages more informative/verbose to help with debugging. Also added myself to the mailing list. Signed-off-by: Niall Meade --- v3: * code indentation fix and rte_errno set correctly v2: * change hash

Re: [PATCH] ip_frag: support IPv6 reassembly with extensions

2024-10-14 Thread Vignesh Purushotham Srinivas
-Original Message- From: Konstantin Ananyev To: Stephen Hemminger , vignesh.purushotham.srini...@ericsson.com Cc: konstantin.v.anan...@yandex.ru , dev@dpdk.org Subject: RE: [PATCH] ip_frag: support IPv6 reassembly with extensions Date: Tue, 17 Sep 2024 17:57:59 + [You don't often ge

[PATCH v3] test: fix option devices

2024-10-14 Thread Mingjin Ye
Without using allow (-a) or block (-b), EAL loads all devices by default. Unexpected devices may be loaded when running test cases in sub-processes. This patch fixes the issue by copying the parameters of the master process if the allow (-a) or block (-b) option is not used when starting the child

RE: [PATCH v2] test: fix option block

2024-10-14 Thread Ye, MingjinX
> -Original Message- > From: Stephen Hemminger > Sent: Sunday, October 13, 2024 6:21 AM > To: Ye, MingjinX > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] test: fix option block > > On Sat, 12 Oct 2024 09:35:19 + > Mingjin Ye wrote: > > > The options allow (-a) and

Re: [PATCH v3 10/12] baseband/acc: cosmetic changes

2024-10-14 Thread Maxime Coquelin
On 10/9/24 23:13, Hernan Vargas wrote: Cosmetic code changes. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- drivers/baseband/acc/rte_vrb_pmd.c| 54 +-- 2 files changed, 36 insertions(+), 20 deletions(-)

[PATCH v2 00/10] net/ice: base code update for RC2

2024-10-14 Thread Bruce Richardson
A number of small fixes and other changes to enable Tx scheduler enhancements to our DPDK driver have been added to the base code. Upstream these changes for 24.11 RC2. Most have previously been submitted as part of the scheduler changes [1] [1] https://patches.dpdk.org/project/dpdk/list/?series=3

[PATCH v2 01/10] net/ice/base: re-enable bypass mode for E822

2024-10-14 Thread Bruce Richardson
From: Jacob Keller When removing bypass mode, the code for E822 bypass was completely removed in error. This code should be maintained in DPDK so re-add the necessary functions. Fixes: ce9ad8c5bc6d ("net/ice/base: remove PHY port timer bypass mode") Cc: sta...@dpdk.org Signed-off-by: Jacob Kell

[PATCH v2 04/10] net/ice/base: remove 255 limit on sched child nodes

2024-10-14 Thread Bruce Richardson
The Tx scheduler in the ice driver can be configured to have large numbers of child nodes at a given layer, but the driver code implicitly limited the number of nodes to 255 by using a u8 datatype for the number of children. Increase this to a 16-bit value throughout the code. Signed-off-by: Bruce

[PATCH v2 02/10] net/ice/base: add bounds check

2024-10-14 Thread Bruce Richardson
From: Fabio Pricoco Refactor while loop to add a check that the values read are in the correct range. Fixes: 6c1f26be50a2 ("net/ice/base: add control queue information") Cc: sta...@dpdk.org Signed-off-by: Fabio Pricoco Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_controlq.c |

[PATCH v2 03/10] net/ice/base: fix VLAN replay after reset

2024-10-14 Thread Bruce Richardson
From: Dave Ertman If there is more than one VLAN defined when any reset that affects the PF is initiated, after the reset rebuild, no traffic will pass on any VLAN but the last one created. This is caused by the iteration though the VLANs during replay each clearing the vsi_map bitmap of the VSI

Re: [PATCH v3 06/12] baseband/acc: enhance SW ring alignment

2024-10-14 Thread Maxime Coquelin
On 10/9/24 23:12, Hernan Vargas wrote: Calculate the aligned total size required for queue rings, ensuring that the size is a power of two for proper memory allocation. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 7 --- 1 file changed, 4 insertions(+), 3 delet

[PATCH v2 08/10] net/ice/base: allow init without TC class sched nodes

2024-10-14 Thread Bruce Richardson
If DCB support is disabled via DDP image, there will not be any traffic class (TC) nodes in the scheduler tree immediately above the root level. To allow the driver to work with this scenario, we allow use of the root node as a dummy TC0 node in case where there are no TC nodes in the tree. For use

[PATCH v2 09/10] net/ice/base: read VSI layer info from VSI

2024-10-14 Thread Bruce Richardson
Rather than computing from the number of HW layers the layer of the VSI, we can instead just read that info from the VSI node itself. This allows the layer to be changed at runtime. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v3 11/12] baseband/acc: rte free refactor

2024-10-14 Thread Maxime Coquelin
I would rename the title to: "baseband/acc: refactor resources freeing" I can fix while applying. On 10/9/24 23:13, Hernan Vargas wrote: Refactor to explicitly set pointer to NULL after free to avoid double free. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 23 +

[PATCH v2 05/10] net/ice/base: set VSI index on newly created nodes

2024-10-14 Thread Bruce Richardson
The ice_sched_node type has got a field for the vsi to which the node belongs. This field was not getting set in "ice_sched_add_node", so add a line configuring this field for each node from its parent node. Similarly, when searching for a qgroup node, we can check for each node that the VSI inform

[PATCH v2 07/10] net/ice/base: remove flag checks before topology upload

2024-10-14 Thread Bruce Richardson
DPDK should support more than just 9-level or 5-level topologies, so remove the checks for those particular settings. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 33 - 1 file changed, 33 deletions(-) diff --git a/drivers/net/ice/base/ice_

[PATCH v2 06/10] net/ice/base: optimize subtree searches

2024-10-14 Thread Bruce Richardson
In a number of places throughout the driver code, we want to confirm that a scheduler node is indeed a child of another node. Currently, this is confirmed by searching down the tree from the base until the desired node is hit, a search which may hit many irrelevant tree nodes when recursing down wr

[PATCH v2 10/10] net/ice/base: update README

2024-10-14 Thread Bruce Richardson
Update the README file with the date of that latest base code snapshot. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 3c2dc43856..c32e530789 10064

Re: [PATCH v3 12/12] baseband/acc: clean up of VRB1 capabilities

2024-10-14 Thread Maxime Coquelin
On 10/9/24 23:13, Hernan Vargas wrote: The interrupt support was defeatured on the VRB1 device. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/vrb1.rst | 3 --- drivers/baseband/acc/rte_vrb_pmd.c | 8 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) Reviewed-by:

[PATCH] common/cnxk: allow enabling IOVA field in mbuf

2024-10-14 Thread Shijith Thotton
Value of RTE_IOVA_IN_MBUF was always disabled on cnxk platforms, as IOVA in the mbuf is not required. This change modifies that behavior, allowing RTE_IOVA_IN_MBUF to be enabled if the build option -Denable_iova_as_pa=true is explicitly specified. Signed-off-by: Shijith Thotton --- config/arm/me

RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-14 Thread Nitin Saxena
Hi David and all, >> I see no non-RFC series following this original submission. >> It will slip to next release unless there is an objection. I had pushed non RFC patch series before -rc1 date (11th oct). We have an ABI change in this patch series https://patches.dpdk.org/project/dpdk/patch/20

Re: [PATCH] net: improve vlan header type alignment

2024-10-14 Thread Bruce Richardson
On Sun, Oct 13, 2024 at 08:35:54AM +, Morten Brørup wrote: > Ethernet packets can be VLAN tagged, i.e. an Ethernet header can have a > VLAN tag (a.k.a. VLAN header) embedded. > Since the Ethernet header is 2 byte aligned, and the VLAN tag is directly > related to the Ethernet header, the VLAN t

[PATCH v2 2/4] net/mlx5: fix real time counter reading from PCI BAR

2024-10-14 Thread Viacheslav Ovsiienko
From: Tim Martin There is the mlx5_txpp_read_clock() routine reading the 64-bit real time counter from the device PCI BAR. It introduced two issues: - it checks the PCI BAR mapping into process address space and tries to map this on demand. This might be problematic if something goes w

[PATCH v2 3/4] net/mlx5: fix Tx tracing to use single clock source

2024-10-14 Thread Viacheslav Ovsiienko
From: Tim Martin The prior commit introduced tracing for mlx5, but there is a mixture of two unrelated clocks used: the TSC for host work submission timestamps and the NIC HW clock for CQE completion times. It is necessary to have timestamps from a single common clock, and the NIC HW clock is the

[PATCH v2 0/4] net/mlx5: series to fix and improve tx trace capabilitie

2024-10-14 Thread Viacheslav Ovsiienko
Signed-off-by: Viacheslav Ovsiienko --- v1: https://inbox.dpdk.org/dev/20241009114028.973284-1-viachesl...@nvidia.com/ v2: move part of code between 2nd and 3rd patches to fix single patch compilation issue. Tim Martin (2): net/mlx5: fix real time counter reading from PCI BAR net/mlx5: fix

[PATCH v2 1/4] net/mlx5/tools: fix trace dump multiple burst completions

2024-10-14 Thread Viacheslav Ovsiienko
In case if there were multiple bursts completed in the single completion the first only burst was moved to the done list. The situation is not typical, because usually tracing was used for scheduled traffic debugging and for this case each burst had its own completion requested, and there were no c

Re: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

2024-10-14 Thread Bruce Richardson
On Fri, Oct 11, 2024 at 10:57:10AM -0700, Stephen Hemminger wrote: > The zero length array warning can be re-enabled. > The zero length marker fields are now removed by > commit 9e152e674c77 ("mbuf: remove marker fields") > in DPDK 24.03. > > This reverts commit cfacbcb5a23bc26cb913528c372adddabbb

[PATCH v2 4/4] net/mlx5: update dump script to show incomplete records

2024-10-14 Thread Viacheslav Ovsiienko
If the trace dump is stored at the moment when there is some incomplete Tx transfers - WQE is pushed but hardware did not sent the completions yet - this incomplete was not dumped by the script mlx5_trace. For some cases (for example, if queue was stuck) the valuable debug information was lost. To

[v3 1/5] raw/gdtc: introduce gdtc raw device driver

2024-10-14 Thread Yong Zhang
Introduce rawdev driver support for GDTC which can help to connect two separate hosts with each other. Signed-off-by: Yong Zhang --- MAINTAINERS| 5 + doc/guides/rawdevs/gdtc.rst| 35 ++ doc/guides/rawdevs/index.rst | 1 + drivers/raw/gdtc/gdtc_rawdev.c | 212 +

[v3 4/5] raw/gdtc: add support for enqueue operation

2024-10-14 Thread Yong Zhang
Add rawdev enqueue operation for gdtc devices. Signed-off-by: Yong Zhang --- drivers/raw/gdtc/gdtc_rawdev.c | 220 + drivers/raw/gdtc/gdtc_rawdev.h | 19 +++ 2 files changed, 239 insertions(+) diff --git a/drivers/raw/gdtc/gdtc_rawdev.c b/drivers/raw/gdtc/gdtc_r

[v3 2/5] raw/gdtc: add support for queue setup operation

2024-10-14 Thread Yong Zhang
Add queue initialization and release interface. Signed-off-by: Yong Zhang --- drivers/raw/gdtc/gdtc_rawdev.c | 242 + drivers/raw/gdtc/gdtc_rawdev.h | 19 +++ 2 files changed, 261 insertions(+) diff --git a/drivers/raw/gdtc/gdtc_rawdev.c b/drivers/raw/gdtc/gdtc_

[v3 3/5] raw/gdtc: add support for standard rawdev operations

2024-10-14 Thread Yong Zhang
Add support for rawdev operations such as dev_start and dev_stop. Signed-off-by: Yong Zhang --- drivers/raw/gdtc/gdtc_rawdev.c | 136 - drivers/raw/gdtc/gdtc_rawdev.h | 10 +++ 2 files changed, 145 insertions(+), 1 deletion(-) diff --git a/drivers/raw/gdtc/gdtc_

[v3 5/5] raw/gdtc: add support for dequeue operation

2024-10-14 Thread Yong Zhang
Add rawdev dequeue operation for gdtc devices. Signed-off-by: Yong Zhang --- drivers/raw/gdtc/gdtc_rawdev.c | 113 + 1 file changed, 113 insertions(+) diff --git a/drivers/raw/gdtc/gdtc_rawdev.c b/drivers/raw/gdtc/gdtc_rawdev.c index 03f7cc1a8e..8e9543f402 100644

RE: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 14 October 2024 09.44 > +struct lcore_var_buffer { > + char data[RTE_MAX_LCORE_VAR * RTE_MAX_LCORE]; > + struct lcore_var_buffer *prev; > +}; In relation to Jerin's request for using hugepages when available,

  1   2   3   >