Add more rules to checkstyle.xml in fe

Hi, devs, Currently, we only have two rules in checkstyle.xml in fe. These are all about import. So, the code style in fe is very casual. I want to add more rules to checkstyle.xml in fe to Improve code readability, and adjust all fe code to satisfy new code style step by step. What do you think

Re: Add more rules to checkstyle.xml in fe

vide code style scheme for ides to format code automatically after we add rules to checkstyle.xml > 2022年4月14日 17:02，ling miao 写道： > > It is best to check the code style at compile time. > > Ling Miao > > morrysnow 于2022年4月14日周四 16:37写道： > >> Hi, devs, >> >

Re: Add more rules to checkstyle.xml in fe

gt; On Thu, Apr 14, 2022 at 4:37 PM morrysnow wrote: > >> Hi, devs, >> >> Currently, we only have two rules in checkstyle.xml in fe. These are all >> about import. So, the code style in fe is very casual. >> I want to add more rules to checkstyle.xml in fe to Imp

Re: Add more rules to checkstyle.xml in fe

. > 2. If the many lines of code change after applying the code style rule, we > would lose the original changelog via `git blame`. > > vin jake 于2022年4月14日周四 17:12写道： > >> I have add it in PR https://github.com/apache/incubator-doris/pull/8987 >> >> On Thu, A

Re: Add more rules to checkstyle.xml in fe

t up your thoughts. > > We can add it in the issue: > https://github.com/apache/incubator-doris/issues/8985 > > > On Thu, Apr 14, 2022 at 6:52 PM vin jake wrote: > >> great, I will trim it in my PR. >> >> checkstyle.xml need more discussion >&

Re: Add more rules to checkstyle.xml in fe

d. Empty Line Separator e. Separator Wrap f. Overload Methods Declaration Order g. Variable Declaration Usage Distance i. One Top Level Class Step 5: 1. Add java doc check to CheckStyle and set severity to warning. 2. Fix java doc warning gradually > 20

Re: Add more rules to checkstyle.xml in fe

to check license header, is this rule still > needed? > > >> adjust the order of import to "static, org.apache.doris, third party, java" > Better not using static import > > > > > -- > > 此致！Best Regards > 陈明雨 Mingyu Chen > > Email:

Re: Add more rules to checkstyle.xml in fe

yle> Demo: https://github.com/morrySnow/test_checkstyle/pull/5 <https://github.com/morrySnow/test_checkstyle/pull/5> > 2022年4月29日 13:40，morrysnow 写道： > > Hi, mingyu > > 1. Check license is needed for local check. > 2. Add a rule to forbidden static import is ok for me

Re: Add more rules to checkstyle.xml in fe

Step3: https://github.com/apache/incubator-doris/issues/9405 Step4: https://github.com/apache/incubator-doris/issues/9406 > 2022年4月29日 13:43，morrysnow 写道： > > Hi, devs > > I want to add Step 0 before all steps. > > Step 0: > > Add checkstyle action to github acti

Re: Add more rules to checkstyle.xml in fe

r code style seperately by run following command under fe directory: mvn checkstyle:check > 2022年5月6日 16:16，ling miao 写道： > > Regarding the code format correction of the old code, do we currently need > to do it manually? > > Ling Miao > > morrysnow 于2022年5月6日周五 15:03写

Re:Re: Add more rules to checkstyle.xml in fe

r fe directory: mvn checkstyle:check At 2022-04-29 13:43:18, "morrysnow" wrote: >Hi, devs > >I want to add Step 0 before all steps. > >Step 0: > >Add checkstyle action to github action to check pr style. This action checks >incremental code and adds comment to pr auto

Re: 订阅邮件

Hi, vinleexiao, If you want to subscribe dev mailing list of Doris, you should send an email to dev-subscr...@doris.apache.org , not to dev@doris.apache.org . you can follow this: https://doris.apache.org/community/subscribe-ma