Re: Some tests are never executed in CI due to their name

2022-10-25 Thread Miklosovic, Stefan
I think that was already communicated and understood. From: Berenguer Blasi Sent: Tuesday, October 25, 2022 7:26 To: dev@cassandra.apache.org Subject: Re: Some tests are never executed in CI due to their name NetApp Security WARNING: This is an external e

Re: Some tests are never executed in CI due to their name

2022-10-25 Thread Miklosovic, Stefan
I think that what you wrote is not entirely correct. It will prevent it from happening again when there are tests ending on "Tests" or starting on "Test". The only case it will not cover is "SplitN" issue we plan to cover with relaxed test.name property. It seems like what you wrote means that

Re: Some tests are never executed in CI due to their name

2022-10-25 Thread Berenguer Blasi
IIUC we're relying on catching the word 'Split' in the file name for option 1. If somebody named his test i.e. 'MyTestGroup1', 'MyTestGroup2', 'TTLTestPre2038', 'TTLTestPost2038',... I think we would leak tests again? or any other word that is not specifically accounted for. Unless I am missing

Re: Some tests are never executed in CI due to their name

2022-10-25 Thread Miklosovic, Stefan
Hi Berenguer, I am glad you asked. I was expecting this question. I think there is a fundamental difference in how we approach this problem. I do not say mine is better, I just find it important to describe it clearly. Let's say we are on a ship which leaks. When I detect that, my course of act

Re: Some tests are never executed in CI due to their name

2022-10-25 Thread Andrés de la Peña
Note that the test multiplexer also searches for tests ending with "Test", so it will also miss new or modified tests with nonstandard names. The automatically detected tests are listed when running generate.sh, and they are added to the repeated run jobs. That gives us another opportunity to detec

CEP-23: Enhancement for Sparse Data Serialization

2022-10-25 Thread Claude Warren, Jr via dev
I would like to discard CEP-23. As I am the proposer, is a vote required? What is the process? Claude

Re: Some tests are never executed in CI due to their name

2022-10-25 Thread Berenguer Blasi
Well examples lend themselves to many things. I am sure I could come up with examples in the opposite direction. I'd rather talk in terms of the actual files and tests we have. What I was trying to clarify is what I was misunderstanding as I had the impression now we were saying option 1 would

Re: CEP-23: Enhancement for Sparse Data Serialization

2022-10-25 Thread Josh McKenzie
... I don't know that we've navigate that question before. My immediate reaction is as the proposer you should be able to close it down unless it's gone to a vote and/or a vote has passed. If someone else wants to pick it up later that's fine. On Tue, Oct 25, 2022, at 7:35 AM, Claude Warren, Jr

Re: CEP-23: Enhancement for Sparse Data Serialization

2022-10-25 Thread Claude Warren, Jr via dev
I see that there is one proposal that was discarded. I wonder how that got there. On Tue, Oct 25, 2022 at 2:52 PM Josh McKenzie wrote: > ... I don't know that we've navigate that question before. My immediate > reaction is as the proposer you should be able to close it down unless it's > gone t

Re: [DISCUSS] Potential circleci config and workflow changes

2022-10-25 Thread David Capwell
> This could also be a pipeline parameter instead of hacking it in generate.sh Curious how this works… I run a script that deletes all the approvals and removes the testing workflows… I really don’t want to use the UI at all…. I assumed pipeline params are a UI thing, but I think the goal here

Re: [DISCUSS] Potential circleci config and workflow changes

2022-10-25 Thread Derek Chen-Becker
I'm writing up a more complete proposal, but here are some examples. Parameters can be set from either the UI (not my intent) or via the circleci CLI. Effectively, the config-2_1.yml can have parameters specified like: parameters: run_extra_test: type: boolean default: false jobs: ex