On Wed, 22 May 2024 08:07:59 GMT, Magnus Ihse Bursie wrote:
>> Actually, this is a bit strange. I thought jcheck would look for missing
>> newline at EOF, and that properties files were included in the check
>> nowadays. I'll need to check this out.
>
> I did some testing and it turns out that
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
> jdk.
On Wed, 22 May 2024 12:25:09 GMT, Severin Gehwolf wrote:
>> I did some testing and it turns out that this is indeed not checked. I
>> believe this is a miss in the Skara reimplementation of jcheck. I've opened
>> https://bugs.openjdk.org/browse/SKARA-2265 to track this.
On Thu, 16 May 2024 13:47:20 GMT, Alan Bateman wrote:
>>> If I understand you correctly, this would be no longer a build-time only
>>> approach to produce the "linkable runtime"? It would be some-kind of
>>> jlink-option driven approach (as it would run some code that should only
>>> run when
On Thu, 23 May 2024 18:52:53 GMT, Alan Bateman wrote:
> Yes, I want to help you get this one over the line.
Thanks! Appreciate that.
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2133375454
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote:
> The original way of building static libraries in the JDK was to use the
> configure argument --enable-static-build, which set the value of the make
> variable STATIC_BUILD. (Note that this is not the same as the source code
> defini
On Fri, 3 May 2024 16:05:30 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that e
On Sun, 2 Jun 2024 17:41:55 GMT, Alan Bateman wrote:
> I've been looking through the changes. One thing that I'm wondering about is
> whether --generate-runtime-link-image should disable the keeping of packaged
> modules (set JLINK_KEEP_PACKAGED_MODULES to false). It seems surprising to
> use
On Mon, 3 Jun 2024 12:55:54 GMT, Alan Bateman wrote:
> So I think we may have the wrong default. Yes, they are separate configure
> and jlink options but I'm wondering if it would be more sensible to
> opt-in(not opt-out) to keep the packaged modules when configured with
> --enable-runtime-lin
On Tue, 4 Jun 2024 09:04:30 GMT, Magnus Ihse Bursie wrote:
> > Does that proposal sound good?
>
> What you basically is saying is that the default value of `packaged-modules`
> should be `! runtime-link-image` (i.e. the inverse)?
Yes. **default** of the `packaged-modules` value being the key.
Please review this PR which adds test support for systemd slices so that bugs
like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
cgroups v1 and fails on cgroups v2 due to the way how
[JDK-8217338](htt
On Mon, 3 Jun 2024 17:28:09 GMT, Severin Gehwolf wrote:
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently
On Mon, 3 Jun 2024 19:10:22 GMT, Alan Bateman wrote:
> I've read through most of the changes now. Overall I think it's looking good,
> just a few terminology and minor points that I'll add as comments.
@AlanBateman I don't see those comments. Should I?
-
PR Comment: https://git.op
On Mon, 3 Jun 2024 19:10:22 GMT, Alan Bateman wrote:
> > Does that proposal sound good?
>
> That table is useful, I think it's right. No change to default behavior. If
> someone configures with --enable-runtime-image then they get a JDK run-time
> image that supports jlink (with some limitatio
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
> jdk.
On Sun, 2 Jun 2024 17:41:55 GMT, Alan Bateman wrote:
> (Doing that would of course mean that several existing jlink tests would need
> some changes, either to `@requires` or to remove the checks for the `jmods`
> directory)
I've added a couple of `@requires jlink.packagedModules` (new with thi
On Wed, 5 Jun 2024 13:52:43 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> -
On Wed, 5 Jun 2024 13:54:07 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> -
On Wed, 5 Jun 2024 13:46:59 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> -
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
>
On Wed, 5 Jun 2024 13:21:20 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 113 commits:
>>
>> - Mark some tests with requiring packaged modules
>> -
On Tue, 4 Jun 2024 09:04:30 GMT, Magnus Ihse Bursie wrote:
>>> Does that proposal sound good?
>>
>> That table is useful, I think it's right. No change to default behavior. If
>> someone configures with --enable-runtime-image then they get a JDK run-time
>> image that supports jlink (with some
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
>
On Thu, 6 Jun 2024 09:33:43 GMT, Magnus Ihse Bursie wrote:
> As Erik says. You need to add something like: `DEFAULT_DESC: [the inverse of
> --enable-runtime-link-image]`.
https://github.com/openjdk/jdk/pull/14787/commits/7a8f839e55c5109deeb5022d2338b37387c95c85
does that. Sorry it clashed with
On Thu, 6 Jun 2024 10:42:20 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix default description of keep-packaged-modules
>
> I've read through all src ch
On Thu, 6 Jun 2024 09:47:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlin
rrent situation of
> claiming a containerized system being present when it's actually just a
> regular Linux system.
>
> Testing:
>
> - [x] GHA (risc-v failure seems infra related)
> - [x] Container tests on Linux x86_64 of cgroups v1 and cgroups v2 (including
> gtests)
&
On Fri, 7 Jun 2024 12:59:26 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that e
On Thu, 6 Jun 2024 15:35:20 GMT, Severin Gehwolf wrote:
> My aim will be to bring this into JDK 24 with a JEP then. Hopefully we can
> bring this to a successful conclusion that way.
@AlanBateman JEP draft is here:
https://openjdk.org/jeps/8333799
Could you please help review it?
On Fri, 14 Jun 2024 06:49:34 GMT, Alan Bateman wrote:
> Yes, on my list.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2167591811
On Wed, 22 May 2024 15:02:18 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request with
On Thu, 20 Jun 2024 08:34:45 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
rrent situation of
> claiming a containerized system being present when it's actually just a
> regular Linux system.
>
> Testing:
>
> - [x] GHA (risc-v failure seems infra related)
> - [x] Container tests on Linux x86_64 of cgroups v1 and cgroups v2 (including
> gtests)
&
rrent situation of
> claiming a containerized system being present when it's actually just a
> regular Linux system.
>
> Testing:
>
> - [x] GHA (risc-v failure seems infra related)
> - [x] Container tests on Linux x86_64 of cgroups v1 and cgroups v2 (including
> gtest
On Tue, 16 Apr 2024 18:25:52 GMT, Thomas Stuefe wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
> jdk.
On Tue, 25 Jun 2024 13:39:07 GMT, Jan Kratochvil
wrote:
> Currently this patch conflicts a lot with #19085
> (jerboaa:jdk-8331560-cgroup-controller-delegation).
Yes, I'll resolve it one way or another depending on which one goes in first.
-
PR Comment: https://git.openjdk.org/jdk
rrent situation of
> claiming a containerized system being present when it's actually just a
> regular Linux system.
>
> Testing:
>
> - [x] GHA (risc-v failure seems infra related)
> - [x] Container tests on Linux x86_64 of cgroups v1 and cgroups v2 (including
> gtests)
&
On Thu, 20 Jun 2024 17:37:05 GMT, Thomas Stuefe wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove problem listing of PlainRead which is reworked here
>
> src/hotspot/os/linux/
On Mon, 24 Jun 2024 14:33:51 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlin
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that e
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that e
On Thu, 27 Jun 2024 18:40:09 GMT, Larry Cable wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Refactor mount info matching to helper function
>> -
rrent situation of
> claiming a containerized system being present when it's actually just a
> regular Linux system.
>
> Testing:
>
> - [x] GHA (risc-v failure seems infra related)
> - [x] Container tests on Linux x86_64 of cgroups v1 and cgroups v2 (including
> gtests)
&
On Fri, 28 Jun 2024 15:41:48 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that e
On Mon, 11 Mar 2024 16:55:36 GMT, Severin Gehwolf wrote:
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
>
On Fri, 28 Jun 2024 15:41:48 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that e
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request with
On Wed, 8 May 2024 03:00:50 GMT, Jan Kratochvil wrote:
>> Jan Kratochvil has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 49 commits:
>>
>> - centos7 compat
>> - 64a5feb6:
>> - fixes
>> - e514824f:
>> - ebb459e9:
>> - Merg
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
Please review this simple test fix to exclude the test from being run on an
Alpine Linux system. Apparently default Alpine Linux systems don't have cgroups
set up by default the way other distros do. More info on the bug. I propose to
not run the test on musl systems.
-
Commit mess
On Mon, 8 Jul 2024 14:19:21 GMT, Severin Gehwolf wrote:
> Please review this simple test fix to exclude the test from being run on an
> Alpine Linux system. Apparently default Alpine Linux systems don't have
> cgroups set up by default the way other distros do. More info
On Mon, 8 Jul 2024 14:26:29 GMT, Matthias Baesken wrote:
> Hi Severin, sure ! I put it into our build/test setup .
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/20076#issuecomment-2214368557
On Mon, 8 Jul 2024 14:19:21 GMT, Severin Gehwolf wrote:
> Please review this simple test fix to exclude the test from being run on an
> Alpine Linux system. Apparently default Alpine Linux systems don't have
> cgroups set up by default the way other distros do. More info
On Mon, 8 Jul 2024 14:19:21 GMT, Severin Gehwolf wrote:
> Please review this simple test fix to exclude the test from being run on an
> Alpine Linux system. Apparently default Alpine Linux systems don't have
> cgroups set up by default the way other distros do. More info
On Thu, 11 Jul 2024 03:39:37 GMT, Jan Kratochvil
wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Thu, 11 Jul 2024 03:42:27 GMT, Jan Kratochvil
wrote:
> [test.patch.txt](https://github.com/user-attachments/files/16171122/test.patch.txt)
>
> * `CPUQuota` (changed it to `AllowedCPUs`) does not work for me - it
> properly distributes the load but JDK still sees all available CPU cores
On Thu, 11 Jul 2024 06:54:27 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Thu, 11 Jul 2024 14:26:23 GMT, Jan Kratochvil
wrote:
> > > ```
> > > * `CPUQuota` (changed it to `AllowedCPUs`) does not work for me - it
> > > properly distributes the load but JDK still sees all available CPU cores
> > > (4 of my VM).
> > > ```
> >
> >
> > Could you elaborate on that? W
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request with
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
On Fri, 12 Jul 2024 12:28:16 GMT, Jan Kratochvil
wrote:
> With #17198 and this updated patch I still get the a FAIL due to:
>
> ```
> [0.333s][trace][os,container] OSContainer::active_processor_count: 4
> ```
>
> But let's resolve it after #17198 gets final/approved.
Because the #17198 is inc
On Thu, 11 Jul 2024 06:54:27 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a r
On Mon, 15 Jul 2024 07:02:11 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit sinc
On Thu, 18 Jul 2024 14:48:02 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since
On Thu, 18 Jul 2024 14:48:02 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since
Please review this fix for cgroups-based metrics reporting in the
`jdk.internal.platform` package. This fix is supposed to address wrong
reporting of certain limits if the limits aren't set at the leaf nodes.
For example, on cg v2, the memory limit interface file is `memory.max`.
Consider a cgr
On Mon, 22 Jul 2024 16:56:00 GMT, Severin Gehwolf wrote:
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
On Thu, 11 Jul 2024 16:46:13 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
On Mon, 24 Jun 2024 14:33:51 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlin
On Tue, 30 Jul 2024 07:47:55 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with two additional
> commits since
On Wed, 14 Aug 2024 02:59:33 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Fix by Severin Gehwolf.
>> Testcase by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request incrementally with one additional
> commit since t
On Wed, 14 Aug 2024 03:26:02 GMT, Jan Kratochvil
wrote:
>> test/hotspot/jtreg/containers/cgroup/NestedCgroup.java line 217:
>>
>>> 215:
>>> 216: // KFAIL - verify the
>>> CgroupSubsystem::initialize_hierarchy() and
>>> jdk.internal.platform.CgroupSubsystem.initializeHierarchy() b
On Mon, 19 Aug 2024 08:12:25 GMT, Jan Kratochvil
wrote:
> As we cannot find an agreement even on the comment in the testcase and this
> pull request will have soon an anniversary, proposing:
>
> * check-in the fix from a separate pull request as it is whole your fix
> anyway
> * I wil
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request with
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
> jdk.
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated t
On Mon, 29 Jul 2024 14:18:24 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf no
On Tue, 20 Aug 2024 17:34:46 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
> jdk.
On Tue, 27 Aug 2024 14:12:40 GMT, Zdenek Zambersky wrote:
> If I am not mistaken, new test requires, that testsuite is ran as superuser
> (root). (Because it writes `/etc/systemd/system`, runs certain systemd
> commands). Should test be skipped for non-root?
Thanks! I can add that. FWIW, conta
On Tue, 27 Aug 2024 14:24:18 GMT, Matthias Baesken wrote:
> I added the PR to our internal build/test queue .
Thanks, Matthias!
-
PR Comment: https://git.openjdk.org/jdk/pull/19530#issuecomment-2312813813
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request with
On Wed, 28 Aug 2024 14:21:09 GMT, Zdenek Zambersky wrote:
> > > If I am not mistaken, new test requires, that testsuite is ran as
> > > superuser (root). (Because it writes `/etc/systemd/system`, runs certain
> > > systemd commands). Should test be skipped for non-root?
> >
> >
> > Thanks! I
On Thu, 29 Aug 2024 15:22:02 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Wed, 28 Aug 2024 16:13:07 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
On Fri, 30 Aug 2024 11:02:52 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Fri, 30 Aug 2024 11:05:24 GMT, Matthias Baesken wrote:
> Not saying that this is a very bad thing, maybe it is just the way it is,
> that 'root' is needed ?
I'll do some more research whether or not that is a hard requirement. Thanks
for the comments so far.
-
PR Comment: http
On Fri, 30 Aug 2024 11:46:51 GMT, Severin Gehwolf wrote:
> > Not saying that this is a very bad thing, maybe it is just the way it is,
> > that 'root' is needed ?
>
> I'll do some more research whether or not that is a hard requirement. Thanks
> for the com
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request incremen
On Fri, 30 Aug 2024 14:14:05 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` c
On Fri, 30 Aug 2024 11:40:45 GMT, Severin Gehwolf wrote:
>> src/hotspot/share/prims/whitebox.cpp line 2507:
>>
>>> 2505: WB_END
>>> 2506:
>>> 2507: // Physical cpus of the host machine (including containers), Linux
>>> only.
>>
&g
333446). This
> patch adds a test using that framework among some simpler unit tests.
>
> Thoughts?
>
> Testing:
>
> - [x] GHA
> - [x] Container tests on Linux x86_64 on cg v1 and cg v2 systems
> - [x] Some manual testing using systemd slices
Severin Gehwolf has updated
n order to not regress another time.
>
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to JDK-8322420)
> - [x] GHA
Severin Gehwolf has updated the pull request with
atatransfer.jmodjava.rmi.jmodjava.xml.crypto.jmod
> jdk.editpad.jmod jdk.internal.vm.compiler.jmod
> jdk.jfr.jmod jdk.management.jmodjdk.unsupported.desktop.jmod
> java.desktop.jmod java.scripting.jmod java.xml.jmod
> jdk.
On Wed, 28 Sep 2022 05:45:14 GMT, Ioi Lam wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> 8293540: [Metrics] Potentially incorrectly detected resource li
1 - 100 of 677 matches
Mail list logo
