[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. wangleiat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repos

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat updated this revision to Diff 466349. wangleiat added a comment. Address @SixWeining's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 Files: clang/lib/Basic/Targets/LoongArch.h cla

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat marked 2 inline comments as done. wangleiat added a comment. Thanks. @SixWeining Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 ___ cfe-commits maili

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat added a comment. In D135526#3849117 , @thakis wrote: > This seems to break check-clang: http://45.33.8.238/linux/88687/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks a lot, I'll fix it right away. Repo

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

wangleiat updated this revision to Diff 466775. wangleiat added a comment. Fix `Preprocessor/init-loongarch.c` test failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/ https://reviews.llvm.org/D135526 Files: clang/lib/Basic/Targets

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat abandoned this revision. wangleiat added a comment. We have decided to keep it unchanged. Thank you, everyone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151298/new/ https://reviews.llvm.org/D151298 ___

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin, XiaodongLoong. Herald added a subscriber: hiraditya. Herald added a project: All. wangleiat requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-comm

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

wangleiat updated this revision to Diff 547072. wangleiat added a comment. Address @SixWeining's commonts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156866/new/ https://reviews.llvm.org/D156866 Files: clang/include/clang/Basic/BuiltinsLoongA

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8d3b1f9f2d: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support… (authored by wangleiat). Changed prior to commit: https://reviews.llvm.org/D156866?vs=547072&id=548511#toc

[PATCH] D139177: [LoongArch] Specify registers used for exception handling

wangleiat accepted this revision. wangleiat added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139177/new/ https://reviews.llvm.org/D139177 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D151297: [clang][test][LoongArch] Pre-commit test for empty struct in C++ mode

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin. Herald added a subscriber: mstorsjo. Herald added a project: All. wangleiat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prelim

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin. Herald added a project: All. wangleiat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, paramter or return value whose t

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. In D151298#4367163 , @xry111 wrote: > Blocking this as it's a deliberate decision made in D132285 > . > > Is there any imperative reason we must really pass the empty struct? The C++ > standa

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. In D151298#4367225 , @xry111 wrote: > In D151298#4367215 , @wangleiat > wrote: > >> In D151298#4367163 , @xry111 wrote: >> >>> Blocking this as

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. > I think the paragraph means: > > class Empty {}; > int test(Empty empty, int a); > > Then we should put `a` into `a1`, not `a0`. And we are indeed doing so. yes. with this patch, `a` will be passed with `a1` register. > I mean now GCC and Clang have the same beh

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. >>> If we want to ignore empty structures, it is not enough to only modify >>> psABI, because the current implementations of gcc and clang do not ignore >>> empty structures in all cases. For example: >>> >>> struct { struct{}; int i; }; // in this case, the empty st