Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-09-16 Thread strager via cfe-commits
strager marked 4 inline comments as done. Comment at: lib/Format/UnwrappedLineParser.cpp:1057-1058 @@ +1056,4 @@ + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using parseAssigmentExpression() in

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-09-16 Thread strager via cfe-commits
strager updated this revision to Diff 34946. strager marked 2 inline comments as done. strager added a comment. Address @djasper's comments. http://reviews.llvm.org/D11693 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-09-16 Thread strager via cfe-commits
strager updated this revision to Diff 34947. strager added a comment. Rebase. http://reviews.llvm.org/D10370 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp unittests/Format

Re: [PATCH] D10371: clang-format: Support @synchronized.

2015-09-16 Thread strager via cfe-commits
strager updated this revision to Diff 34957. strager added a comment. Rebase. Fix style issues. http://reviews.llvm.org/D10371 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D12921: clang-format: Support 'template<>' (no space).

2015-09-16 Thread strager via cfe-commits
strager created this revision. strager added a reviewer: djasper. strager added subscribers: cfe-commits, abdulras, sas. Herald added a subscriber: klimek. Some styles don't put a space between 'template' and the opening '<'. Introduce SpaceAfterTemplateKeyword which, when set to false, causes 'te

Re: [PATCH] D12921: clang-format: Support 'template<>' (no space).

2015-09-17 Thread strager via cfe-commits
strager added a comment. Should we remove `ObjCSpaceBeforeProtocolList`? It has the same problem as the `SpaceAfterTemplateKeyword` I am introducing. http://reviews.llvm.org/D12921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-09-17 Thread strager via cfe-commits
strager marked 2 inline comments as done. Comment at: lib/Format/UnwrappedLineParser.cpp:1060-1061 @@ +1059,4 @@ + nextToken(); + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using parseAssi

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-09-17 Thread strager via cfe-commits
strager added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:221-235 @@ -220,3 +220,17 @@ -**AlwaysBreakAfterDefinitionReturnType** (``DefinitionReturnTypeBreakingStyle``) +**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle``) + The function de

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-09-17 Thread strager via cfe-commits
strager updated this revision to Diff 35038. strager added a comment. Fix missing IsDefinition check in ContinuationIndenter::canBreak. http://reviews.llvm.org/D10370 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/For

Re: [PATCH] D10371: clang-format: Support @synchronized.

2015-08-11 Thread strager via cfe-commits
strager added a comment. ping http://reviews.llvm.org/D10371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-08-11 Thread strager via cfe-commits
strager planned changes to this revision. Comment at: lib/Format/UnwrappedLineParser.cpp:1057-1058 @@ +1056,4 @@ + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using parseAssigmentExpression() in

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

2015-08-07 Thread strager via cfe-commits
strager added a comment. (Sorry for the late feedback.) Comment at: docs/ClangFormatStyleOptions.rst:221 @@ -220,2 +220,3 @@ -**AlwaysBreakAfterDefinitionReturnType** (``DefinitionReturnTypeBreakingStyle``) +**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

2015-08-07 Thread strager via cfe-commits
strager added a comment. ping http://reviews.llvm.org/D11693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits