https://github.com/chelini commented:
Thanks!
https://github.com/llvm/llvm-project/pull/75494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chelini edited
https://github.com/llvm/llvm-project/pull/75494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -434,8 +429,21 @@ FailureOr
linalg::lowerUnPack(RewriterBase &rewriter,
RankedTensorType::Builder(packedTensorType).setShape(stripMinedShape);
RankedTensorType collapsedType = tensor::CollapseShapeOp::inferCollapsedType(
stripMinedTensorType, packingMetadata.r
@@ -434,8 +429,21 @@ FailureOr
linalg::lowerUnPack(RewriterBase &rewriter,
RankedTensorType::Builder(packedTensorType).setShape(stripMinedShape);
RankedTensorType collapsedType = tensor::CollapseShapeOp::inferCollapsedType(
stripMinedTensorType, packingMetadata.r
@@ -381,11 +381,6 @@ FailureOr
linalg::lowerUnPack(RewriterBase &rewriter,
return rewriter.notifyMatchFailure(unPackOp, "outer dims perm NYI");
RankedTensorType packedTensorType = unPackOp.getSourceType();
chelini wrote:
nit: I would move this line aft
@@ -434,8 +428,14 @@ FailureOr
linalg::lowerUnPack(RewriterBase &rewriter,
RankedTensorType::Builder(packedTensorType).setShape(stripMinedShape);
RankedTensorType collapsedType = tensor::CollapseShapeOp::inferCollapsedType(
stripMinedTensorType, packingMetadata.r
https://github.com/chelini edited
https://github.com/llvm/llvm-project/pull/75494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -464,6 +464,129 @@ module attributes {transform.with_named_sequence} {
// -
+// Check that we can lower unpack with dynamic dimensions in the input and
destination.
+// CHECK-LABEL: func.func @unpack_with_dynamic_input_dest(
+// CHECK-SAME: %[[ARG0:.*]]: tensor, %[[AR
https://github.com/chelini approved this pull request.
Thanks, it looks good to me.
https://github.com/llvm/llvm-project/pull/75494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chelini closed
https://github.com/llvm/llvm-project/pull/75494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chelini wrote:
> It was suggested to me by @chelini to only have the `reshape` op to handle
> all cases and get rid of the `expand_shape` op. We can then implement a
> canonicalizer to convert when valid. I'm all for this, however want to make
> sure this is the direction we want to go before
chelini wrote:
Is it ready for review? Is marked as "draft".
https://github.com/llvm/llvm-project/pull/79626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
12 matches
Mail list logo