[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke created this revision. Sockke added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Calls to **sto

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 440517. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/test/clang-ti

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 441241. Sockke added a comment. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/do

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. In D128697#3615404 , @Eugene.Zelenko wrote: > I think will be good idea to make check more generic and allow user-defined > list of unsafe functions. I understand that user-defined is implemented through the config, but some ty

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. In D128697#3619310 , @LegalizeAdulthood wrote: > This whole check seems weird to me. I mean, almost every use of a standard > container could throw `std::bad_alloc` but we don't insist on a local `catch` > for `bad_alloc` at ev

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128697/new/ https://reviews.llvm.org/D128697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 449188. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/docs/ReleaseNo

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke updated this revision to Diff 358820. Sockke edited the summary of this revision. Sockke added a comment. Thanks for your review! I have run clang/docs/tools/dump_ast_matchers.py to regenerate the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://r

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke updated this revision to Diff 358835. Sockke added a comment. update to display context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke added a comment. I would appreciate it if you could submit it on my behalf. Thanks a lot! Name: liuke Email: liuke.ge...@bytedance.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://reviews.llvm.org/D105973 ___ cfe-

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke created this revision. Sockke added reviewers: aaron.ballman, MTC, steven.zhang. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In C++, the enumerat

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke added a comment. At present, Our views on preventing UB are basically the same, so a warning still needs to be reported (BTW, the original version will not report warnings for enum class types). The final question is what is the recommended value for initialization and whether to provide

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke added a comment. In D106431#2896472 , @whisperity wrote: > In D106431#2896441 , @aaron.ballman > wrote: > >> However, I don't recall how clang-tidy interacts with fix-its on notes off >> the top of my he

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke added a comment. Any thoughts? : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362291. Sockke retitled this revision from "[clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement" to "[clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.". Soc

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362320. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/docs/ReleaseNotes.r

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362345. Sockke added a comment. Thanks for your reply @whisperity. I have updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362651. Sockke marked 2 inline comments as done. Sockke added a comment. Thank you for your reply! I generally understand what you mean, but there are three cases, namely, no diagnosis, providing diagnosis, and providing diagnosis & FixIt. Only by judging wh

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke updated this revision to Diff 362663. Sockke added a comment. You made it very clear, thanks a lot！ @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106431/new/ https://reviews.llvm.org/D106431 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.c

[PATCH] D123924: [clang-apply-replacements] Added support for adjusting conflict offset.

Sockke created this revision. Sockke added reviewers: malcolm.parsons, hokein, alexfh. Herald added a project: All. Sockke requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. If two different texts are inserted at the same off

[PATCH] D123924: [clang-apply-replacements] Added support for adjusting conflict offset.

Sockke updated this revision to Diff 423355. Sockke retitled this revision from "[WIP][clang-apply-replacements] Added support for adjusting conflict offset." to "[clang-apply-replacements] Added support for adjusting conflict offset.". Sockke added a comment. Herald added a subscriber: carlosgal

[PATCH] D123924: [clang-apply-replacements] Added support for adjusting conflict offset.

Sockke added a comment. It stands to reason that there should be no insert conflicts in the YAML generated by clang-tidy except for the header insertion. The two checks that caused the conflict should be fixed in clang-tidy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ ht

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 423359. Sockke retitled this revision from "[clang-apply-replacements] Added support for adjusting conflict offset." to "[clang-apply-replacements] Added an option to ignore insert conflict.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 425166. Sockke added a comment. Rename the function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplac

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke marked an inline comment as done. Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128697/new/ https://reviews.llvm.org/D128697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 445792. Sockke added a comment. Added test cases where there is a struct with an anonymous union and another field that does need an initializer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: cl

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 430621. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tools-extra/docs/ReleaseNote

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke added a comment. Hi, Could anyone please review this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke added a comment. I'm not quite sure why the test case is not passing on Windows, could you please check this problem? @flx CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 ___ cfe-commits mail

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Hi, Could you please take some time to review this diff again? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-co

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 374430. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/test/clang-tid

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:484 + AnyMemberHasInitPerUnion, [&](const FieldDecl *F) { if (!FieldsToInit.count(F)) return; aaron.ballman wr

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke added a comment. Hi, Could you please take some time to review this diff again? @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. In D108370#3017800 , @aaron.ballman wrote: > LGTM! Thanks for your review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. In D108370#3017800 , @aaron.ballman wrote: > LGTM! Thanks for your review! I don't have commit access, here is my information: Name: liuke Email: liuke.ge...@bytedance.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke marked 2 inline comments as done. Sockke added a comment. In D106431#2913101 , @aaron.ballman wrote: > In D106431#2912589 , @Sockke wrote: > >> Thank you for your reply! I generally understand what you mea

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

Sockke added a comment. In D106431#2916551 , @whisperity wrote: > In D106431#2916542 , @Sockke wrote: > >> Cheers! Can it be merged? @aaron.ballman > > Yes, but I think the patch needs to be rebased first as the

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke created this revision. Sockke added reviewers: alexfh, aaron.ballman, whisperity, steven.zhang, MTC. Herald added subscribers: rnkovacs, xazax.hun. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. There are incorrec

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke updated this revision to Diff 364404. Sockke added a comment. format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/test/clang-tidy/checkers/p

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke added a comment. Thank you for your reviews, @Quuxplusone, @whisperity, @MTC. I was also considering adding new diagnoses to the current check for these special cases, but I am not sure how to classify and describe them correctly, and whether they need to be added to the new check. First

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke created this revision. Sockke added reviewers: aaron.ballman, gribozavr, flx, whisperity, steven.zhang, MTC. Herald added subscribers: shchenz, rnkovacs, kbarton, xazax.hun, nemanjai. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscri

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 365159. Sockke added a comment. Format and add some description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-to

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke updated this revision to Diff 365448. Sockke added a comment. update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/clang-tidy/performance/Mov

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke updated this revision to Diff 365455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.h clang-tools-ext

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke marked 2 inline comments as done. Sockke added a comment. Any thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke marked an inline comment as done. Sockke added a comment. Any thoughts? : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 365916. Sockke added a comment. update! @aaron.ballman @MTC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-e

[PATCH] D107450: [clang-tidy] Fix wrong and missing warnings in performance-move-const-arg

Sockke marked 8 inline comments as done. Sockke added a comment. In D107450#2938824 , @MTC wrote: > I think we're a bit off track, and @Sockke wants to accomplish more than one > goal in the same patch. I have summarized what we are currently discussing

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke updated this revision to Diff 366225. Sockke retitled this revision from "[clang-tidy] Fix wrong and missing warnings in performance-move-const-arg" to "[clang-tidy] Fix wrong FIxIt in performance-move-const-arg". Sockke edited the summary of this revision. Sockke added a comment. Fix the

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke updated this revision to Diff 366815. Sockke added a comment. update! Fixed some diagnostic descriptions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-to

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke created this revision. Sockke added reviewers: aaron.ballman, bkramer, alexfh, malcolm.parsons, MTC, steven.zhang. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke updated this revision to Diff 367474. Sockke marked 2 inline comments as done. Sockke added a comment. Herald added a subscriber: jfb. Thanks for your reply @Quuxplusone. I have updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 F

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke created this revision. Sockke added reviewers: ymandel, aaron.ballman, MTC. Sockke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The annotation about ignoringImpCasts is wrong, which will cause misunderstanding. Fix it. Reposito

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Herald added a subscriber: carlosgalvezp. Kindly ping. @whisperity, @aaron.ballman, @Quuxplusone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list c

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 382632. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/clang-tidy/performance/Mov

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke marked 2 inline comments as done. Sockke added a comment. In D107450#3087103 , @whisperity wrote: > I think this is becoming okay and looks safe enough. I can't really grasp > what `HasCheckedMoveSet` means, and how it synergises with storing >

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

Sockke added a comment. This seems to be an existing check. Have you compared it with **bugprone-string-constructor**? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 384706. Sockke added a comment. I improved the logic of judgments needing to report suggesting notes in some cases. And more tests were added here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files:

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 384728. Sockke added a comment. In addition, the splicing logics of "FunctionName" and "ExpectParmTypeName" were improved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-t

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

Sockke added subscribers: whisperity, aaron.ballman. Sockke added a comment. In D113148#3108705 , @CJ-Johnson wrote: > In D113148#3107897 , @Sockke wrote: > >> This seems to be an existing check. Have you compare

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Hi, Could anyone please review this diff? @whisperity, @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. In D107450#3155019 , @whisperity wrote: > This generally looks fine for me, but I'd rather have other people who are > more knowledgeable about the standard's intricacies looked at it too. > > AFAIK Aaron is busy this week and th

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Hi, @LegalizeAdulthood, are you okay with the way this has progressed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping @LegalizeAdulthood. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 455516. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/docs/ReleaseNo

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d8e91a5d359: [clang-tidy] Ignore other members in a union if any

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. This patch has been around for a long time, I have added the release notes. There are users waiting for this fix and I committed it myself first. @LegalizeAdulthood I'm looking forward to your follow-up reply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 484210. Sockke added a comment. Added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/test/clang-

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 484765. Sockke added a comment. Improved the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/te

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke marked 6 inline comments as done. Sockke added a comment. Mark comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Hi, Could anyone please review this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 438295. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/test/clang-ti

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 432520. Sockke added a comment. Rebased and added '-fno-delayed-template-parsing' option for the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 432522. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h c

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98b3a8cd985: Fix `performance-unnecessary-value-param` for template specialization (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11659

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 432829. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h clang-tools-extra/clang-apply-replac

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3a235aa2e6: [clang-apply-replacements] Added an option to ignore insert conflict. (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12392

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke created this revision. Sockke added reviewers: aaron.ballman, MTC. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 435409. Sockke edited the summary of this revision. Sockke added a comment. Fix test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemb

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke created this revision. Sockke added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. Sockke requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 477861. Sockke added a comment. Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/test/clang-tid

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 478529. Sockke added a comment. Added test in existing `init-variables.cpp` file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.c

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 495413. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/test/clang-tidy/c

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGce6de98b80ad: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. @carlosgalvezp Thanks for your review! I committed it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing li

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

Sockke accepted this revision. Sockke added a comment. This revision is now accepted and ready to land. I think it looks great and safe enough. It would be better to turn `!(*ptr).empty()` into `!ptr->empty()`, but I have no particular opinions at this point. Let's see if @aaron.ballman has an

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 401470. Sockke added a comment. Improve some description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/clang-ti

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7f8aea71485: [clang-tidy] Fix wrong FixIt in performance-move-const-arg (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ htt

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. In D107450#3257877 , @aaron.ballman wrote: > Do you need someone to commit on your behalf? Thanks for your review, I committed it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

  1   2   >