Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar added a comment. Hello :) I will prepare another patch as you suggested, is this patch good? Can it be submitted? Ziv https://reviews.llvm.org/D15075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D24958: Test linked to D24957

zizhar created this revision. zizhar added a reviewer: rnk. zizhar added a subscriber: cfe-commits. zizhar set the repository for this revision to rL LLVM. A test for the patch in https://reviews.llvm.org/D24957 Repository: rL LLVM https://reviews.llvm.org/D24958 Files: test/CodeGen/ms-inli

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 73617. zizhar added a comment. Changed the '^' to point to the clobber which conflicts. Changed the relevant comments. However, regarding the point about the non-alphabetical characters - It's a different behavior for these specific characters, since these sho

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 73760. zizhar added a comment. fixed :) https://reviews.llvm.org/D15075 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp lib/Headers/intrin.h lib/Sema/SemaStmtAsm.cp

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 74068. zizhar added a comment. I hope this last update finishes it, Thanks for the review :) https://reviews.llvm.org/D15075 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 74500. zizhar added a comment. changed :) Thanks for the review :> https://reviews.llvm.org/D15075 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets.cpp lib/Headers/intrin.

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 70660. zizhar added a comment. Hi, I have moved the relevant code to TargetInfo as previously discussed, and created a default implementation and the x86 implementation. Regarding the intrinsics, I believe it should be a separate fix, as it is not related to

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar added a comment. You understood corectly :) After going a bit through the log, I think that there is no reason for clang to not detect it, probably the check was just forgotten. This patch is the check. "r" constraint means (taken from the spec:) A register operand is allowed provided

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar updated this revision to Diff 60996. zizhar added a comment. A redo, investigated a bit more, had to fix some things, moved it to ActOnGCCAsmStmt. fixed intrin.h (the patch reveals a problem in it). added tests to check for regression and examples. http://reviews.llvm.org/D15075 Files:

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar added a comment. Hello Hans, Regarding the changes in intrin.h, You're the last to change/add these lines, I found out that there is a conflict between the clobber list and input or output lists. Can you review this change? Thanks, Ziv Izhar https://reviews.llvm.org/D15075 __

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

zizhar added a comment. Akira, You've mentioned a good point, this X86 logic should indeed be moved to X86TargetInfo. The current convertConstraint() implementation is not doing what I need – it doesn’t handle all the input/output constraints I need, and it returns the constraint in a different