upsuper added a comment.
I'm not familiar with LLVM / Clang codebase. I was asked by @MaskRay to help
review the bidi-related part of this patch.
Generally I believe the algorithm here is too naive that it produces both false
positives and false negatives. I'm not sure how important those edge
upsuper added a comment.
I think the core algorithm looks correct now. I'll leave the code review to
LLVM reviewers. Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112913/new/
https://reviews.llvm.org/D112913
___
cfe-commits mailing l
upsuper added a comment.
I'd like to clarify that what I think is correct now is the algorithm to detect
unclosed explicit formatting scopes in a given string.
I haven't been following very closely with the whole spoofing issue, so I can't
say that there is no other ways to construct a spoof th
