[PATCH] D36767: Implement the standard for timeouts for std::condition_variable

2019-07-26 Thread Tom via Phabricator via cfe-commits
tomcherry abandoned this revision. tomcherry added a comment. Herald added a subscriber: jfb. See https://reviews.llvm.org/D65339 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36767/new/ https://reviews.llvm.org/D36767 ___ cfe-commits maili

[PATCH] D36767: Implement the standard for timeouts for std::condition_variable

2017-08-15 Thread Tom via Phabricator via cfe-commits
tomcherry created this revision. The C++ standard calls for wait_for() to use steady clock and wait_until() to use the clock that is provided as an argument. This is not currently done in libc++ and is not possible with the pthreads API, however it is possible with the underlying futex system

[PATCH] D36767: Implement the standard for timeouts for std::condition_variable

2017-08-15 Thread Tom via Phabricator via cfe-commits
tomcherry added a comment. This is mostly an RFC. The underlying issue is that we cannot use timed waits based on CLOCK_REALTIME on Android. In trying to fix that, I figured I might as well try implementing the standard as described, though I understand that there'd be resistance to such a re

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

2017-03-08 Thread Tom via Phabricator via cfe-commits
tomcherry updated this revision to Diff 9. tomcherry added a comment. Moved comments to an appropriate line https://reviews.llvm.org/D30764 Files: include/string Index: include/string === --- include/string +++ include/stri

[PATCH] D30764: Disable unsigned integer sanitizer for basic_string::replace()

2017-03-08 Thread Tom via Phabricator via cfe-commits
tomcherry added a comment. I don't have commit access, so please commit for me. Thank you https://reviews.llvm.org/D30764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits