tcanens added a subscriber: tcanens.
Comment at: include/string:2523
@@ +2522,3 @@
+ call_input();
+ basic_string temp(__first, __last);
+this->swap(temp);
This default constructs the allocator, but the allocator may not be default
constructible.
tcanens added inline comments.
Comment at: include/string:2677-2678
@@ +2676,4 @@
+#endif
+for (; __first != __last; ++__first)
+push_back(*__first);
+
If an exception is thrown after a `push_back()` causes reallocation, existing
iterators/poi
tcanens added inline comments.
Comment at: include/string:2673
@@ -2654,1 +2672,3 @@
+ basic_string __temp (__first, __last, __alloc());
+ append(__temp.begin(), __temp.end());
return *this;
Likewise - should probably be `append(__temp.data(), __t
tcanens added inline comments.
Comment at: include/string:2826-2827
@@ -2787,13 +2825,4 @@
#endif
-size_type __old_sz = size();
-difference_type __ip = __pos - begin();
-for (; __first != __last; ++__first)
-push_back(*__first);
-pointer __p = __get_pointe