sdefresne created this revision.
sdefresne added a reviewer: rjmccall.
sdefresne added a subscriber: cfe-commits.
When a function/method use a parameter with "ns_consumed" attribute,
ensure that the mangled name is the same whether -fobjc-arc is used
or not.
Since "ns_consumed" attribute is gener
sdefresne added a comment.
In http://reviews.llvm.org/D20113#425984, @rjmccall wrote:
> This is a good catch, thanks!
Thank you for the quick reply.
Please excuse me if I misunderstood you or if my remark appear off the mark,
this is my first time sending patches to clang. I'm not yet complet
sdefresne updated this revision to Diff 57924.
sdefresne added a comment.
Ok, this make sense. I've updated my change to follow your recommendation. Can
you take another look?
Using 'extern "C" { ... }" would probably not be an option in my case as I want
to use "ns_consumed" for the parameter
sdefresne added a comment.
Thank you for the comment.
I think my change still needs to be reviewed and approved by someone (at least
in the Phabricator interface it still appears as "Need review"). Can you do the
review and give approval if it looks good to you?
Once this is approved, should I
