Author: ssrivastava
Date: Tue May 15 11:28:42 2018
New Revision: 332384
URL: http://llvm.org/viewvc/llvm-project?rev=332384&view=rev
Log:
Fixed some rtti-options tests.
Certain tests in rtti-options.cpp are not really testing anything because they
are testing for the absence of -frtti option to
Author: ssrivastava
Date: Fri May 18 16:32:01 2018
New Revision: 332784
URL: http://llvm.org/viewvc/llvm-project?rev=332784&view=rev
Log:
Do not enable RTTI with -fexceptions, for PS4
NFC for targets other than PS4.
This patch is a change in behavior for PS4, in that PS4 will no longer enable
RT
Author: ssrivastava
Date: Tue Jun 20 17:08:44 2017
New Revision: 305862
URL: http://llvm.org/viewvc/llvm-project?rev=305862&view=rev
Log:
Prevent devirtualization of calls to un-instantiated functions.
PR 27895
Differential Revision: https://reviews.llvm.org/D22057
Added:
cfe/trunk/test/Cod
Author: ssrivastava
Date: Wed Jun 6 17:42:59 2018
New Revision: 334153
URL: http://llvm.org/viewvc/llvm-project?rev=334153&view=rev
Log:
Change the wording of RTTI errors to make them more generic.
An attempt to use dynamic_cast while rtti is disabled, used to emit the error:
cannot use dynam
Author: ssrivastava
Date: Wed Jul 17 13:41:26 2019
New Revision: 366368
URL: http://llvm.org/viewvc/llvm-project?rev=366368&view=rev
Log:
Renamed and changed the wording of warn_cconv_ignored
As discussed in D64780 the wording of this warning message is being
changed to say 'is not supported' ins
Author: ssrivastava
Date: Fri Jul 19 14:38:34 2019
New Revision: 366617
URL: http://llvm.org/viewvc/llvm-project?rev=366617&view=rev
Log:
Disallow most calling convention attributes on PS4
PS4 now only allows "cdecl", and its equivalent on PS4, "sysv_abi".
Differential Revision: https://reviews.
Sunil_Srivastava added a comment.
Ping
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sunil Srivastava
Date: 2022-07-12T11:14:56-07:00
New Revision: a844378b2bc2c0a7f18e8d7cdd259b6c4d443128
URL:
https://github.com/llvm/llvm-project/commit/a844378b2bc2c0a7f18e8d7cdd259b6c4d443128
DIFF:
https://github.com/llvm/llvm-project/commit/a844378b2bc2c0a7f18e8d7cdd259b6c4d443128.di
Author: Sunil Srivastava
Date: 2023-07-21T18:18:21-07:00
New Revision: aa34b34e93d444efec6cd894e5e55927d0e413e6
URL:
https://github.com/llvm/llvm-project/commit/aa34b34e93d444efec6cd894e5e55927d0e413e6
DIFF:
https://github.com/llvm/llvm-project/commit/aa34b34e93d444efec6cd894e5e55927d0e413e6.di
Sunil_Srivastava added inline comments.
Comment at: test/CodeGen/no-devirt.cpp:16
@@ +15,3 @@
+ if (a > 6) return data[a] ; // Should not devirtualize
+ if (a > 4) return data.func1(a); // Should devirtualize
+ return data.func2(a);// Should devirtualize
---
Sunil_Srivastava updated this revision to Diff 71432.
Sunil_Srivastava added a comment.
This is an update to address points raised by Richard Smith:
1. The bit and the access functions have been renamed from
MarkedForPendingInstantiation to InstantiationIsPending.
2. It closely, though not entir
Sunil_Srivastava added a comment.
ping
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ssrivastava
Date: Mon Jul 25 12:17:06 2016
New Revision: 276653
URL: http://llvm.org/viewvc/llvm-project?rev=276653&view=rev
Log:
Support '#pragma once' in headers when using PCH
The '#pragma once' directive was erroneously ignored when encountered
in the header-file specified in gene
Sunil_Srivastava created this revision.
Sunil_Srivastava added reviewers: rjmccall, DmitryPolukhin, rsmith, probinson.
Sunil_Srivastava added a subscriber: cfe-commits.
This is the round 2 of the PS4 ABI. In this round:
1) A new value PS4 has been added to TargetCXXABI::Kind. It is being used for
Sunil_Srivastava updated this revision to Diff 47026.
Sunil_Srivastava added a comment.
Changed the patch based of feedback from John McCall.
There is new bit UseExplicitBitFieldAlignment, which is set for everything
except for PS4. The r257462 change has been made conditional on this bit.
htt
Author: ssrivastava
Date: Fri Feb 5 14:50:02 2016
New Revision: 259916
URL: http://llvm.org/viewvc/llvm-project?rev=259916&view=rev
Log:
Do not honor explicit alignment attribute on fields for PS4.
This change reverts r257462 for PS4 triple.
Differential Revision: http://reviews.llvm.org/D16788
Sunil_Srivastava added a reviewer: rsmith.
Sunil_Srivastava updated this revision to Diff 47509.
Sunil_Srivastava added a comment.
Changed the test, but the compiler code is still same, pending reply from
Richard Smith
http://reviews.llvm.org/D15095
Files:
lib/Basic/Diagnostic.cpp
test/Pre
Sunil_Srivastava added a comment.
Richard, Your comment and my concern about the getDiagnosticsInGroup is still
visible in the greyed out area.
Given that do you still want to modify getDiagnosticsInGroup ?
I have removed the separate test and added the new tests to existing files, as
you sugg
Sunil_Srivastava updated this revision to Diff 47707.
Sunil_Srivastava added a comment.
Hi Richard,
> Can you move the special case code out of DiagnosticsEngine and into the
> pragma handler for now?
Yes. This is that approach.
http://reviews.llvm.org/D15095
Files:
lib/Lex/Pragma.cpp
t
Sunil_Srivastava updated this revision to Diff 47865.
Sunil_Srivastava added a comment.
Hi Richard,
Good point about that extra test. I suppose I need another LGTM for the new
test.
No other changes.
http://reviews.llvm.org/D15095
Files:
Preprocessor/Weverything_pragma.c
Preprocessor/pra
Sunil_Srivastava updated this revision to Diff 47866.
Sunil_Srivastava added a comment.
Hi Richard,
Good point about that extra test. I suppose I need another LGTM for the new
test.
No other changes.
(Sorry I had missed the code change in the last round)
http://reviews.llvm.org/D15095
Files:
Author: ssrivastava
Date: Fri Feb 12 19:44:05 2016
New Revision: 260788
URL: http://llvm.org/viewvc/llvm-project?rev=260788&view=rev
Log:
Accept "-Weverything" in clang diagnistic pragmas
Differential Revision: http://reviews.llvm.org/D15095
Added:
cfe/trunk/test/Preprocessor/Weverything_pra
Author: ssrivastava
Date: Fri Feb 26 12:01:12 2016
New Revision: 262042
URL: http://llvm.org/viewvc/llvm-project?rev=262042&view=rev
Log:
Minor tweak to match the overall style.
Modified:
cfe/trunk/test/Sema/bitfield-layout.c
Modified: cfe/trunk/test/Sema/bitfield-layout.c
URL:
http://llvm.
Sunil_Srivastava created this revision.
Sunil_Srivastava added a reviewer: dim.
Sunil_Srivastava added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
This is an addendum to r229921.
http://reviews.llvm.org/D19552
Files:
lib/Analysis/FormatString.cpp
test/Sema/format-strings-f
Sunil_Srivastava added a comment.
I had put these 'h' test lines to test the first of my changes, and this
sufficed, but you are correct. I should add %y too. I am going to add '%hr' and
'%hy'.
Comment at: test/Sema/format-strings-freebsd.c:39
@@ -35,1 +38,3 @@
+ freebsd_kern
Author: ssrivastava
Date: Tue Apr 26 18:19:00 2016
New Revision: 267625
URL: http://llvm.org/viewvc/llvm-project?rev=267625&view=rev
Log:
Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4
This is an addendum to r229921.
Modified:
cfe/trunk/lib/Analysis/FormatString.c
Sunil_Srivastava closed this revision.
Sunil_Srivastava added a comment.
Submitted as r267625.
http://reviews.llvm.org/D19552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ssrivastava
Date: Wed Apr 27 14:53:03 2016
New Revision: 267772
URL: http://llvm.org/viewvc/llvm-project?rev=267772&view=rev
Log:
Set the default C standard to C99 when targeting the PS4.
Patch by Douglas Yung!
Differential Revision: http://reviews.llvm.org/D19003
Modified:
cfe/trun
Author: ssrivastava
Date: Mon Apr 4 17:56:05 2016
New Revision: 265359
URL: http://llvm.org/viewvc/llvm-project?rev=265359&view=rev
Log:
Set the default C standard to C99 when targeting the PS4.
Patch by Douglas Yung!
Differential Revision: http://reviews.llvm.org/D18708
Modified:
cfe/trun
Sunil_Srivastava created this revision.
Sunil_Srivastava added a reviewer: rsmith.
Sunil_Srivastava added a subscriber: cfe-commits.
This review is for a fix for PR 27895, but it requires some discussion. The
bugzilla and the email exchange with Richard Smith in
http://lists.llvm.org/pipermail/c
Sunil_Srivastava added a comment.
Ping.
https://reviews.llvm.org/D22057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sunil_Srivastava created this revision.
Sunil_Srivastava added a reviewer: rsmith.
Sunil_Srivastava added a subscriber: cfe-commits.
We are planning to upstream changes needed for maintaining PS4 ABI across
future releases.
Unlike many other targets, we need to maintain, in most cases, strict ob
Author: ssrivastava
Date: Thu Jan 28 15:36:31 2016
New Revision: 259095
URL: http://llvm.org/viewvc/llvm-project?rev=259095&view=rev
Log:
Implementation of PS4 ABI, Round 1
Added a test to safeguard linux ABI.
Differential Revision: http://reviews.llvm.org/D16607
Modified:
cfe/trunk/test/Sem
Sunil_Srivastava created this revision.
Sunil_Srivastava added a subscriber: cfe-commits.
Special handling for “-Weverything” in ‘pragma clang diagnostic handling’
There is no formal diagnostic group named “everything”, so this code is needed.
http://reviews.llvm.org/D15095
Files:
lib/Basic/D
Sunil_Srivastava added a comment.
Please see the comment about getAllDiagnostics
Comment at: lib/Basic/Diagnostic.cpp:251-257
@@ -250,2 +250,9 @@
SourceLocation Loc) {
+ // Special handling for pragma clang diagnostic ... "-Weverythi
Author: Sunil Srivastava
Date: 2021-01-12T12:37:18-08:00
New Revision: f706486eaf07020b11f2088274c757e4070fe6d1
URL:
https://github.com/llvm/llvm-project/commit/f706486eaf07020b11f2088274c757e4070fe6d1
DIFF:
https://github.com/llvm/llvm-project/commit/f706486eaf07020b11f2088274c757e4070fe6d1.di
36 matches
Mail list logo
