steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50346
Files:
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/DeclObjC.h
include/cla
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50348
Files:
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/DeclObjC.h
include/cla
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50349
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/Analysis/CloneDetection.cpp
lib/CodeGen/CoverageMappingGen.cpp
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50347
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Analysis/CloneDetection.h
lib/CodeGen/CoverageMappi
steveire created this revision.
Herald added subscribers: cfe-commits, jfb, whisperity, jholewinski.
Herald added a reviewer: teemperor.
Repository:
rC Clang
https://reviews.llvm.org/D50350
Files:
docs/RAVFrontendAction.rst
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/c
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Herald added a reviewer: teemperor.
Repository:
rC Clang
https://reviews.llvm.org/D50353
Files:
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
steveire created this revision.
Herald added subscribers: cfe-commits, kbarton, ioeric, nemanjai.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50355
Files:
change-namespace/ChangeNamespace.cpp
clang-move/ClangMove.cpp
clang-tidy/android/CloexecCheck.cpp
clang-tidy/bugpr
steveire added a comment.
Thanks Hans. Yes, I made these patches with some simple sed oneliners.
Once these are approved in principle, I'll re-generate them before pushing.
I have also run clang-format on them, but didn't update Phab with the results
to reduce noise.
Repository:
rC Clang
h
steveire created this revision.
steveire added reviewers: rsmith, dblaikie.
Herald added a subscriber: cfe-commits.
Case case of the switch statement here makes the same call, but it is
already done at the start of the function.
Repository:
rC Clang
https://reviews.llvm.org/D50409
Files:
l
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339372: Add getBeginLoc API to replace getLocStart (authored
by steveire, committed by ).
Herald added a subscriber: llvm-
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339372: Add getBeginLoc API to replace getLocStart (authored
by steveire, committed by ).
Changed prior to commit:
http
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339373: Add getBeginLoc API to replace getStartLoc (authored
by steveire, committed by ).
Changed prior to commit:
http
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339373: Add getBeginLoc API to replace getStartLoc (authored
by steveire, committed by ).
Herald added a subscriber: llvm-
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339374: Add getEndLoc API to replace getLocEnd (authored by
steveire, committed by ).
Herald added a subscriber: llvm-comm
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rC Clang
https://reviews.llvm.org/D50346
___
cfe-commits mailing list
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rC Clang
https://reviews.llvm.org/D50347
___
cfe-commits mailing list
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rL LLVM
https://reviews.llvm.org/D50348
___
cfe-commits mailing list
steveire accepted this revision.
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rC Clang
https://reviews.llvm.org/D50349
___
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rC Clang
https://reviews.llvm.org/D50350
___
cfe-commits mailing list
steveire accepted this revision.
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rC Clang
https://reviews.llvm.org/D50351
___
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339384: Port getStartLoc -> getBeginLoc (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339385: Port getLocStart -> getBeginLoc (authored by
steveire, committed by ).
Herald added a subscriber: llvm-commits.
C
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339385: Port getLocStart -> getBeginLoc (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews
steveire added a comment.
Accepted as part of a whole-branch review here:
http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50354
___
cfe-commit
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339401: Port getLocEnd -> getEndLoc (authored by
steveire, committed by ).
Herald added a subscriber: llvm-commits.
Chang
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339402: Remove obsolete set call (authored by steveire,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50409?vs=159602&id=160026#toc
Repository:
rL LLVM
https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339402: Remove obsolete set call (authored by steveire,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50409
Files:
cfe/trunk/lib/Sema/SemaDec
steveire created this revision.
Herald added a subscriber: cfe-commits.
Migrate callers to print().
dump() should be useful to downstreams and third parties as a debugging
aid. Everyone trips up on this and creates confusing output.
Repository:
rC Clang
https://reviews.llvm.org/D50661
File
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.cpp
Index: lib/Basic/SourceLocation.cpp
==
steveire added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:3063
SourceRange getSourceRange() const override LLVM_READONLY {
-return SourceRange(getLocation(), getLocation());
+return SourceRange(getLocation(), getConstraintExpr()->getLocEnd());
}
-
steveire created this revision.
steveire added reviewers: rsmith, dblaikie, klimek.
Herald added a subscriber: cfe-commits.
A CXXBindTemporaryExpr can appear inside an ImplicitCastExpr, and was
not ignored previously.
Fixes the case reported in PR37327.
Repository:
rC Clang
https://reviews.l
steveire created this revision.
Herald added subscribers: cfe-commits, mgorny.
Remove also the condition to allow in-source builds when using MSVC_IDE.
This may be vestigial and date from a time when llvm CMakeLists.txt had
a similar condition. The llvm file does not have such a condition, so
thi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339730: Fix Stmt::ignoreImplicit (authored by steveire,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50666
Files:
cfe/trunk/lib/AST/Stmt.cpp
steveire added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:272
bool HasLeadingEmptyMacro = Tok.hasLeadingEmptyMacro();
-return Actions.ActOnNullStmt(ConsumeToken(), HasLeadingEmptyMacro);
+SourceLocation SemiLoc = ConsumeToken();
+return Actions.ActOnNul
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
This looks like a NFC change.
Given that the next patch moves these methods out of line, you might consider
introducing them out of line here (and moving the constructors out of line).
Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339810: Add a newline to SourceLocation dump output
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50661
Files:
cfe/tru
steveire updated this revision to Diff 161570.
steveire added a comment.
Add dump() and supporting methods to SourceRange
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.cpp
Index: lib/Basic/SourceLocation.cpp
==
steveire added a comment.
Thanks, I've done that now.
Repository:
rC Clang
https://reviews.llvm.org/D50662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D51069
Files:
ReleaseNotes.rst
Index: ReleaseNotes.rst
===
--- ReleaseNotes.rst
+++ ReleaseNotes.rst
@@ -265
steveire created this revision.
steveire added a reviewer: hans.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D51079
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs
steveire added a comment.
@hans Could you commit this on my behalf? I was not able to do it myself for
some reason.
$ svn commit
svn: E175002: Commit failed (details follow):
svn: E175002: Unexpected HTTP status 400 'Bad Request' on
'/svn/llvm-project/!svn/act/2ca88059-6dd7-44fe-aa3e-9fc9f021f
steveire added a comment.
@hans Consider backporting this.
Repository:
rC Clang
https://reviews.llvm.org/D51079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340376: Update the docs for using LLVM toolset in Visual
Studio (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51079?v
steveire updated this revision to Diff 162280.
steveire added a comment.
Add dump() and supporting methods to SourceRange
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.cpp
unittests/Basic/SourceManagerTest.cpp
steveire updated this revision to Diff 162282.
steveire marked 3 inline comments as done.
steveire added a comment.
Add dump() and supporting methods to SourceRange
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.c
steveire added inline comments.
Comment at: unittests/Basic/SourceManagerTest.cpp:189
+
+ // TODO: How do I get a loc in another file?
+ auto headerLoc =
SourceMgr.getSpellingLoc(SourceMgr.translateLineCol(MainFileID, 3, 5));
I don't know how to resolve this T
steveire updated this revision to Diff 162283.
steveire added a comment.
Remove vestiges of configure buildsystem
Repository:
rC Clang
https://reviews.llvm.org/D50738
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMake
steveire created this revision.
steveire added reviewers: klimek, rsmith.
Herald added a subscriber: cfe-commits.
Fixes bug: 38678
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
==
steveire updated this revision to Diff 162288.
steveire added a comment.
Fix reported range of partial token replacement
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D51258
Files:
include/clang/ASTMatchers/Dynamic/Parser.h
lib/ASTMatchers/Dynamic/Parser.cpp
Index: lib/ASTMatchers/Dynamic/Parser.cpp
=
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D51259
Files:
lib/ASTMatchers/Dynamic/Parser.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
Index: unittests/ASTMatchers/Dynamic/ParserTest.cpp
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51260
Files:
clang-query/tool/ClangQuery.cpp
Index: clang-query/tool/ClangQuery.cpp
===
--- c
steveire created this revision.
Herald added a subscriber: cfe-commits.
This allows loading a file with pre-defined let commands for example.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51261
Files:
clang-query/tool/ClangQuery.cpp
Index: clang-query/tool/ClangQuery.cpp
=
steveire added a comment.
@rsmith Could you approve this please?
Repository:
rC Clang
https://reviews.llvm.org/D50353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341140: Add dump() method for SourceRange (authored by
steveire, committed by ).
Herald added a subscriber: llvm-commits.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341141: Extract parseBindID method (authored by steveire,
committed by ).
Herald added a subscriber: llvm-commits.
Change
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341142: Allow binding to NamedValue resulting from let
expression (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51259
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341142: Allow binding to NamedValue resulting from let
expression (authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51259?vs=162553&id=163443#toc
Repository:
r
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:362
+bool Parser::parseBindID(std::string &BindID, TokenInfo &CloseToken) {
+ // Parse .bind("foo")
klimek wrote:
> CloseToken seems to no
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341145: Add preload option to clang-query (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51261?vs=162555&id=163445#toc
Repository:
rCTE Clang Tools Extra
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341144: Extract runCommandsInFile method (authored by
steveire, committed by ).
Herald added a subscriber: llvm-commits.
steveire marked 2 inline comments as done.
steveire added a comment.
Thanks, I fixed the issues before committing. This commit was a prerequisite to
https://reviews.llvm.org/D51261
Repository:
rL LLVM
https://reviews.llvm.org/D51260
___
cfe-comm
steveire updated this revision to Diff 163447.
steveire added a comment.
Move comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
===
---
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341146: Remove vestiges of configure buildsystem (authored
by steveire, committed by ).
Herald added a subscriber: llvm-co
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
Brilliant, I've wanted to do this for years, and I still have many improvements
to the LLVM/Clang cmake files on my todo list. Good to know others are
similarly motivated.
=
steveire added a comment.
How? This is 'private' code. I don't think it's worth changing that or creating
a test with a huge amount of infrastructure in order to test this indirectly.
Am I missing something?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
_
steveire added a comment.
In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
> In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
>
> > How? This is 'private' code. I don't think it's worth changing that or
> > creating a test with a huge amount of infrastructure in or
steveire added a comment.
As far as I know, no existing clang-tidy checks are affected. I discovered this
while implementing a custom check. See
https://bugs.llvm.org/show_bug.cgi?id=38678
By the way, is there some keyword I should use in commit messages to link to
bugs properly?
Repository:
steveire added a comment.
Thanks.
The `arc` tool already inserted `Differential Revision:` into my git commit,
but that's not what I wonder about. I'm looking for something I can insert into
my git commit so that the bug will automatically be closed when I commit (and
so that the bug will get
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341583: Fix reported range of partial token replacement
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51192?vs=163447&id=164275#toc
Repository:
rCTE Clan
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
steveire updated this revision to Diff 157116.
steveire retitled this revision from "Inline DeclarationNameInfo::getLocEnd
into callers" to "Avoid returning an invalid end source loc".
steveire edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D49100
Files:
steveire added a comment.
In https://reviews.llvm.org/D49840#1176405, @klimek wrote:
> Usually we use match(anyOf(node), hasDescendant(node)). Or did I
> misunderstand what you want?
See http://lists.llvm.org/pipermail/cfe-dev/2018-July/058625.html for a bug
that prevents this working.
Repo
steveire closed this revision.
steveire added a comment.
Committed in SVN revision 338301.
Repository:
rC Clang
https://reviews.llvm.org/D49100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
steveire added a comment.
- The scripts will continue to work at least until `set output` is removed,
which is not going to happen soon.
- A comma-delimited list of options means that if I have `foo, bar, bat`
enabled and want to add `bang`, I need to `set output foo, bar, bat, bang`. Or
alter
steveire added a comment.
> What's more, given that clang-output has no real documentation to speak of,
> how will users even *know* to update their scripts?
The release notes will tell them.
But your comment also raises a different point: If there is so little
clang-query documentation, what
steveire added a comment.
> you have to find the right place to stick the `set dump-output true` in
> order to enable it.
What do you mean "the right place"?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits m
steveire added a comment.
> I don't see this functionality being so critical that we need to deprecate
> the existing spelling when there are backwards compatible options available,
> which is why I'm opposed to this patch going in with the proposed syntax.
I don't think we're going to go anywh
steveire updated this revision to Diff 170304.
steveire added a comment.
Rename dump-output to ast-output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unit
steveire updated this revision to Diff 170305.
steveire added a comment.
Fix tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/QueryE
steveire updated this revision to Diff 170306.
steveire added a comment.
Fix test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/QueryEn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344840: [clang-query] Add option to print matcher expression
(authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52859?vs=1
steveire updated this revision to Diff 170308.
steveire added a comment.
Update test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/Quer
steveire added a comment.
Perhaps the best solution is to introduce this new API, but not deprecate the
existing 'exclusive' API.
What do you think?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits mailing list
steveire updated this revision to Diff 170310.
steveire added a comment.
Don't deprecate existing API
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
This will make it possible to easily
- Add new commands which accept parameters
- Extend the list of features
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53498
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Future development can then dump other content than AST.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
Files:
clang-query/Query.cpp
clang-query/Query.h
steveire updated this revision to Diff 170419.
steveire added a comment.
Format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53498
Files:
clang-query/Query.cpp
Index: clang-query/Query.cpp
===
--- clang-query
steveire updated this revision to Diff 170420.
steveire added a comment.
Format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
Index: clang-query/QueryParser.cpp
=
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
This will make it possible to add non-exclusive mode output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53501
Files:
clang-query/Query.cpp
clang-query/Query
steveire updated this revision to Diff 170427.
steveire added a comment.
Update tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53500
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
unittests/clang-query/QueryEngineTest.cpp
unittests/
steveire updated this revision to Diff 170431.
steveire added a comment.
Update tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53501
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/Que
steveire updated this revision to Diff 170435.
steveire retitled this revision from "[clang-query] Add non-exclusive output
API " to "[clang-query] Add non-exclusive output API".
steveire added a comment.
New design
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
steveire updated this revision to Diff 170439.
steveire added a comment.
Update docs
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QueryParser.h
unittests/clang-query/Query
steveire added a comment.
> This seems confusing to me because I would expect set foo bar to set the
> value of a variable foo to bar,
This is already not the case with `set output diag` etc.
That said, I don't mind spelling this ` output foo`. It's not
my decision. It's up to the reviewers.
steveire added a comment.
> This is already not the case with set output diag etc.
Oh, I'm wrong here. I misread your post, sorry.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits mailing list
cfe-commits@lists.
steveire added a comment.
I prefer the API from Peter. I think it's a good additional step from where
Aaron and I reached in IRC discussion (this patch currently).
I can change the patch to use that later if you agree Aaron?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
steveire added a comment.
Yep, that's the suggestion. That will result in commands such as:
- `enable output detailed-ast`
- `disable output detailed-ast`
- `set output detailed-ast`
- `enable output diag`
- `disable output diag`
- `set output diag`
etc, which I think addresses all concerns.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345192: [clang-query] Re-word command help (authored by
steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53498?vs=170419&id=170972#toc
Repository:
rCTE Clang Tools Extra
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345193: [clang-query] Add 'detailed-ast' output
as an alias for 'dump' (authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53500?vs=170427&id=170973#toc
Reposito
1 - 100 of 1016 matches
Mail list logo
