stelios-arm created this revision.
stelios-arm added reviewers: dmgreen, SjoerdMeijer, fhahn, simon_tatham,
ostannard, c-rhodes.
stelios-arm added a project: LLVM.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
stelios-arm requested review of this revision.
Herald added a project:
stelios-arm added a comment.
@SjoerdMeijer @dmgreen Thanks for your reviews, I will be looking into this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98264/new/
https://reviews.llvm.org/D98264
___
cfe-
stelios-arm marked 4 inline comments as done.
stelios-arm added inline comments.
Comment at: clang/lib/Basic/Targets/AArch64.cpp:363
+ if (HasRandGen)
+Builder.defineMacro("__ARM_FEATURE_RNG", "1");
SjoerdMeijer wrote:
> Where/when is `HasRandGen` set?
Oh,
stelios-arm updated this revision to Diff 329799.
stelios-arm marked 2 inline comments as done.
stelios-arm added a comment.
Addressed the comments made by @SjoerdMeijer and @dmgreen.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98264/new/
https://reviews.llvm.org/D98264
Files:
clan
stelios-arm updated this revision to Diff 329931.
stelios-arm marked an inline comment as done.
stelios-arm added a comment.
1. Addressed the comment made by @SjoerdMeijer and added the comment for the
MRS instruction.
2. Added the `+rang` feature in `arm_acle.c `
CHANGES SINCE LAST ACTION
stelios-arm updated this revision to Diff 329941.
stelios-arm added a comment.
Rephrased a comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98264/new/
https://reviews.llvm.org/D98264
Files:
clang/include/clang/Basic/BuiltinsAArch64.def
clang/lib/Basic/Targets/AArch64.cpp
cl
stelios-arm updated this revision to Diff 330230.
stelios-arm marked an inline comment as done.
stelios-arm added a comment.
1. Removed a redundant comment
2. Removed the changes made in the `test/CodeGen/arm_acle.c`, since the test is
disabled.
3. Added a clang preprocessor test to check the pre
stelios-arm added inline comments.
Comment at: clang/test/CodeGen/arm_acle.c:908
+#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG)
+// AArch64-v8_3-LABEL: @test_rndr(
+// AArch64-v8_3-NEXT: entry:
SjoerdMeijer wrote:
> Not sure if I am surprised that this wor
stelios-arm added inline comments.
Comment at: clang/test/CodeGen/arm_acle.c:908
+#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG)
+// AArch64-v8_3-LABEL: @test_rndr(
+// AArch64-v8_3-NEXT: entry:
SjoerdMeijer wrote:
> stelios-arm wrote:
> > SjoerdMeijer wrot
stelios-arm updated this revision to Diff 330616.
stelios-arm added a comment.
Added tests in `arm_acle.c`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98264/new/
https://reviews.llvm.org/D98264
Files:
clang/include/clang/Basic/BuiltinsAArch64.def
clang/lib/Basic/Targets/AArch64.
stelios-arm updated this revision to Diff 330670.
stelios-arm added a comment.
Change the `rand.ll` llc arguments to the ones that are only relevant.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98264/new/
https://reviews.llvm.org/D98264
Files:
clang/include/clang/Basic/BuiltinsAAr
stelios-arm updated this revision to Diff 330694.
stelios-arm added a comment.
Typo fix for `__ARM_FEATURE_RNG` macro check in `aarch64-target-features.c`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98264/new/
https://reviews.llvm.org/D98264
Files:
clang/include/clang/Basic/Builti
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGab86edbc88fa: [AArch64] Implement __rndr, __rndrrs
intrinsics (authored by stelios-arm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
13 matches
Mail list logo
