[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

2022-02-01 Thread Sharon Xu via Phabricator via cfe-commits
SharonXu added a comment. Hi @vsapsai, I checked out the apple `stable/20211026` llvm-project branch at https://github.com/apple/llvm-project/tree/stable/20211026, and ran check-clang locally, but the tested added in the patch `clang/test/Modules/merge-objc-interface.m` failed with the error

[PATCH] D81624: [CodeGen] Simplify the way lifetime of block captures is extended

2021-04-20 Thread Sharon Xu via Phabricator via cfe-commits
SharonXu added a comment. Hi @ahatanak , @rjmccall, we found that this diff causes an issue: When -fobjc-arc is enabled, if a block is passed as an argument to a function whose corresponding parameter type is && rvalue and attributed as noescape, the object captured by the block can get destruc