[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik created this revision. Herald added a project: All. predelnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to how parseBracedList always stopped on the first closing angle bracket and was used in parsing angle bracketed exp

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. In D123896#3455299 , @curdeius wrote: > Is there an issue report for this bug already? I could create an issue if that is required. In D123896#3455301 , @curdeius wrote: > Could you p

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik updated this revision to Diff 423231. predelnik added a comment. Added annotator test, checked that it fails without a patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 Files: clang/lib/Fo

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. I've created the issue here: https://github.com/llvm/llvm-project/issues/54943 It also seems to fix the other issue I reported which was partially fixed before this change in master: https://github.com/llvm/llvm-project/issues/54837 Repository: rG LLVM Github Monore

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik updated this revision to Diff 423234. predelnik edited the summary of this revision. predelnik added a comment. Added issue links to commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. In D123896#3464171 , @HazardyKnusperkeks wrote: > As this is still on my todo list: Have you considered > > concept X = Bar<5 < 4, 5 > 8>; > concept X = Bar<5 < 4, false>; > > Or stuff like that? I think it would not work

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. I see now, would certainly like to help but it sounds like I might not be competent enough for this. I guess this review could be closed unless it's an acceptable half-measure, not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. Probably, yes. I didn't know I have to do it myself, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing l

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

predelnik added a comment. Ok I've found it on a guide here at last https://llvm.org/docs/MyFirstTypoFix.html Please land a patch for me, @curdeius, my author data is “Sergey Semushin predel...@gmail.com” Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev