Serge_Preis added a reviewer: arphaman.
Serge_Preis added a comment.
Hello,
would you please review my small fix for incorrect source positions for certain
entities. The changes were submitted more than a month ago and I understand you
all are busy people, but I hope this review won't take long
Serge_Preis added a reviewer: rsmith.
Serge_Preis added a comment.
Would you please take a look into proposed minor changes to avoid mangler
assertion in some template cases.
https://reviews.llvm.org/D32428
___
cfe-commits mailing list
cfe-commits@
Serge_Preis updated this revision to Diff 103703.
Serge_Preis added a comment.
Fixed review comments:
- Style fixed for long line
- Test moved to test/Index
- Patch context spans entire files
https://reviews.llvm.org/D32439
Files:
lib/Sema/SemaDeclCXX.cpp
test/Index/ctor-init-source-loc.cp
Serge_Preis added a comment.
Alex,
If changes are OK would you please commit them on my behalf (I don't have
commit permissions perosonally). If this is impossible/inconvenient for any
reason please let me know, I will ask Dmitry Polukhin (collegue of mine) to
commit (he's done this before).
Serge_Preis added a comment.
Thank you!
https://reviews.llvm.org/D32439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Serge_Preis added a comment.
Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't
knwo what this configuration mean) - I tested on Linux that I have at my
desposal and tesing passes.
Repository:
rL LLVM
https://reviews.llvm.org/D32439
__
Serge_Preis added a comment.
In https://reviews.llvm.org/D32439#790252, @chapuni wrote:
> In https://reviews.llvm.org/D32439#790248, @Serge_Preis wrote:
>
> > Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't
> > knwo what this configuration mean) - I tested on Linux th
Serge_Preis added a comment.
In https://reviews.llvm.org/D32439#790323, @chapuni wrote:
> Just change LLVM_DEFAULT_TARGET_TRIPLE, build and run check-clang. You may
> use ccmake for it.
> Or, modify RUN line locally like
>
> RUN: c-index-test (snip) %s -Xclang -triple -Xclang x86_64-pc-win32
Serge_Preis added a comment.
Thank you all for your help! The problem was that in Windows-targeted builds
-fdelayed-template-parsing is set by default affecting template symbols
appearance in index. Throwing -fno-delayed-template-parsing to c-index-test
fixed the situation for failed configurat
Serge_Preis updated this revision to Diff 104102.
Serge_Preis added a comment.
-fno-delayed-template-parsing atted to c-index-test arguments for consistent
testing results among all targets
https://reviews.llvm.org/D32439
Files:
lib/Sema/SemaDeclCXX.cpp
test/Index/ctor-init-source-loc.cpp
Serge_Preis created this revision.
Herald added subscribers: rengolin, aemerson.
This fixes problem described as bug:31405
https://bugs.llvm.org//show_bug.cgi?id=31405
Itanium ABI: debug assertion in template mangling with declype return
The problem is that FunctionTypeDepthState is not properly
Serge_Preis created this revision.
This patch fixes incorrect source positions of dependent c'tor initializers
like in the following code:
template
struct Derived: MyBase::InnerIterator
{
Derived() : MyBase::InnerIterator() {} /// This line is problematic: all
positions point to InnerItera
Serge_Preis added a comment.
In https://reviews.llvm.org/D32439#736503, @malcolm.parsons wrote:
> Is it possible to add a test for this change?
> There are some source range checks in test/Misc/ast-dump-decl.cpp
Yes, I think testing is quite possible. I will take a look into
test/Misc/ast-d
Serge_Preis added a comment.
In https://reviews.llvm.org/D32439#736503, @malcolm.parsons wrote:
> Is it possible to add a test for this change?
> There are some source range checks in test/Misc/ast-dump-decl.cpp
I looked into test/Misc/ast-dump-decl.cpp and other tests around, but they all
us
Serge_Preis updated this revision to Diff 96752.
Serge_Preis added a comment.
- Minor improvement to the fix: ensure that Type is of expected kind.
- Added test for various situations causing problems with source poisition in
current implementation
https://reviews.llvm.org/D32439
Files:
lib/
Serge_Preis added a comment.
Hello Richard,
This is just friendly ping. Would you please review my fix for source position
issue in CXXCtorInitializer and related structures or nominate someone as
appropriate reviewer for this code.
Thank you,
Serge.
https://reviews.llvm.org/D32439
__
16 matches
Mail list logo
