[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

sameconrad updated this revision to Diff 108812. sameconrad added a comment. Add additional tests for cases with base and derived classes. Add clarifying comments about emitting warnings for base class members during reordering checks. Add fix for bug where reordering in init lists that contain n

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

sameconrad added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:178 for (const auto *Initializer : CtorDecl->inits()) { -if (!Initializer->isWritten()) +if (!Initializer->isMemberInitializer() || !Initializer->isWritten()) continue; --

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

sameconrad added a comment. In https://reviews.llvm.org/D35972#825348, @alexshap wrote: > LGTM, thanks! > do you have commit access ? (if not i can commit this patch for you) I don't have commit access, so you will have to commit it. Thank you https://reviews.llvm.org/D35972

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

sameconrad created this revision. sameconrad added a project: clang-tools-extra. This adds a warning emitted by clang-reorder-fields when the reordering fields breaks dependencies in the initializer list (such that -Wuninitialized would warn when compiling). For example, given: Foo::Foo(int x)