Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-02-23 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. Just test changes - OK to commit? http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-04-28 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-04-29 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. No problem. Thanks for the code review. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r268075 - Improve test coverage of -Wdouble-promotion

2016-04-29 Thread Robert Lougher via cfe-commits
Author: rlougher Date: Fri Apr 29 12:44:29 2016 New Revision: 268075 URL: http://llvm.org/viewvc/llvm-project?rev=268075&view=rev Log: Improve test coverage of -Wdouble-promotion This patch adds coverage for additional cases where implicit conversion can occur (assignment and return). It also ad

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-03-03 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. Please can somebody review this? Thanks! http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-01-18 Thread Robert Lougher via cfe-commits
rob.lougher created this revision. rob.lougher added a reviewer: gbiv. rob.lougher added a subscriber: cfe-commits. The -Wdouble-promotion warning was added to clang in r251588 (fixing PR15109). The added test, however, only covered a subset of the cases where implicit conversion can occur (ass

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

2016-01-27 Thread Robert Lougher via cfe-commits
rob.lougher added a comment. Ping. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits