Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob updated this revision to Diff 52227. Rob added a comment. I tried check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp -- -- -fms-extensions and check_clang_tidy.py modernize-use-override-ms.cpp modernize-use-override temp on OSX and nethier work as expected.

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob updated this revision to Diff 52539. Rob added a comment. adding -std=c++11 and it works as expected. yay http://reviews.llvm.org/D18396 Files: clang-tidy/modernize/UseOverrideCheck.cpp docs/ReleaseNotes.rst test/clang-tidy/modernize-use-override-ms.cpp test/clang-tidy/modernize-use

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob updated this revision to Diff 52543. Rob added a comment. Adding back quotes in the docs http://reviews.llvm.org/D18396 Files: clang-tidy/modernize/UseOverrideCheck.cpp docs/ReleaseNotes.rst test/clang-tidy/modernize-use-override-ms.cpp test/clang-tidy/modernize-use-override.cpp In

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob added a comment. ok, I'm not sure if its worth rolling back the change to modernize-use-override-ms.cpp, see ammended comments above. Apart from this it should be good to go. I think I am going to need someone to submit the patch for me, I can't use svn due to 'error 400' so I've been usin

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob added a comment. Thanks :) Repository: rL LLVM http://reviews.llvm.org/D18396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

clang-tidy modernize-use-override

Hi, First time poster here, Please advise... Can I contribute these patches for clang-tidy modernize-use-override addressing two problems: 1: missing spaces on pure function decls Orig: void pure() const=0 Problem: void pure() constoverride =0 Fixed: void pure() const override =0 2: This is m

[PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob created this revision. Rob added reviewers: alexfh, aaron.ballman. Rob added a subscriber: cfe-commits. This patch is to address 2 problems I found with Clang-tidy:modernize-use-override. 1: missing spaces on pure function decls. Orig: void pure() const=0 Problem: void pure() constoverride

Re: [PATCH] D18396: Clang-tidy:modernize-use-override. Fix for __declspec attributes and const=0 without spacse

Rob updated this revision to Diff 51904. Rob added a comment. Update to address review. Clang-format applied and nit fixed. http://reviews.llvm.org/D18396 Files: clang-tidy/modernize/UseOverrideCheck.cpp test/clang-tidy/modernize-use-override-ms.cpp test/clang-tidy/modernize-use-override.